From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by mx.groups.io with SMTP id smtpd.web11.34873.1614002768472506682
 for <devel@edk2.groups.io>;
 Mon, 22 Feb 2021 06:06:09 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=a+2na4fw;
 spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 1FAFB64E77
	for <devel@edk2.groups.io>; Mon, 22 Feb 2021 14:06:07 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1614002767;
	bh=Pc9lworq785nKGYlxqR32Jp+m8ZMpIwLshOd1PrcGGE=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=a+2na4fwWrwwUv+9rNRAsDMFgSBjkvTUenJ1ge+pSxiLd5MU/TAf8FO7mFYXD+Xgp
	 cajEDAQFNwykDtLcppCeb1rN147avQQmkAepSlrO6McMIodikbeDVIyPIFjfEc58vj
	 0pEjrGuVOopNQT/RwrtfijXcM0imm8/t+2Wu06gyvXDAg45Mjh9lS8m9mq7TSpBybS
	 jABVAkA1Dec+PevjVc8PTSjfPE4DVEGBbgDE8D8Q2mpACyDO6Rs2yAj8kB938Ptw4J
	 hYLWQaiO/h5o1EcRQWW97tt2bAoNhg9CeMGqgLghS2+X9Xwx9ZaL1S7dzCOnj5Hsg1
	 4AxUDOR0t1/xA==
Received: by mail-ot1-f41.google.com with SMTP id c16so12078226otp.0
        for <devel@edk2.groups.io>; Mon, 22 Feb 2021 06:06:07 -0800 (PST)
X-Gm-Message-State: AOAM532h/lf07HnaMIZqgrlsFRAxHj/YOcm6yfRo+8BSazL2hbB39hEv
	q9aNoGN7YsEUi741X5qVnhaT72jdYIKqx9od23M=
X-Google-Smtp-Source: ABdhPJzQtOwFArTqYbTbxiYNb5nj0pTlEJ7o4HcCKXqLkLupHSBKCjJyR3GJZvbaU5g+Q0WJasOpqWtAy9jsHh4Rd+M=
X-Received: by 2002:a05:6830:135a:: with SMTP id r26mr1192616otq.77.1614002766170;
 Mon, 22 Feb 2021 06:06:06 -0800 (PST)
MIME-Version: 1.0
References: <20210219063607.27920-1-sughosh.ganu@linaro.org>
 <20210219063607.27920-5-sughosh.ganu@linaro.org> <CAMj1kXG0dK_7m20WAi7jXa0hyRGKRmRSyudoNzJ_5BnHXWatiA@mail.gmail.com>
 <CADg8p96svTiLZkyGPdjKk6NPTzieni5C6ErPVCgRLfWm7Rtdcw@mail.gmail.com>
In-Reply-To: <CADg8p96svTiLZkyGPdjKk6NPTzieni5C6ErPVCgRLfWm7Rtdcw@mail.gmail.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Mon, 22 Feb 2021 15:05:54 +0100
X-Gmail-Original-Message-ID: <CAMj1kXEzLXvA2FkYgwbsJ3jF5UdTUrRANJP9HKFAj1sBZ8Z_MQ@mail.gmail.com>
Message-ID: <CAMj1kXEzLXvA2FkYgwbsJ3jF5UdTUrRANJP9HKFAj1sBZ8Z_MQ@mail.gmail.com>
Subject: Re: [PATCH v5 04/14] ArmPkg: Introduce support for PcdFfaEnable
To: Sughosh Ganu <sughosh.ganu@linaro.org>
Cc: devel@edk2.groups.io, Sami Mujawar <sami.mujawar@arm.com>, 
	Ilias Apalodimas <ilias.apalodimas@linaro.org>, Ard Biesheuvel <ardb+tianocore@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 22 Feb 2021 at 12:47, Sughosh Ganu <sughosh.ganu@linaro.org> wrote:
>
>
> hi Ard,
>
> On Mon, 22 Feb 2021 at 16:19, Ard Biesheuvel <ardb@kernel.org> wrote:
>>
>> On Fri, 19 Feb 2021 at 07:36, Sughosh Ganu <sughosh.ganu@linaro.org> wro=
te:
>> >
>> > The Secure Partition(SP) can request services from the Secure
>> > Partition Manager Core(SPMC) either through FF-A calls or through the
>> > existing SVC calls. Add a feature flag Pcd for enabling the FF-A
>> > method -- when this is set to FALSE, the SP uses the existing SVC
>> > calls for making the requests.
>> >
>> > Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
>> > ---
>> >
>> > Changes since V4: None
>> >
>>
>> Didn't I already ack some of these patches for v3?
>>
>> In general, please carry over Rb's that have been given on the list if
>> the patches haven't changed substantially.
>
>
> The reason i did not put your R-b on this patch is because i have made a =
change in the patch where the Pcd has now been put under the [PcdsFeatureFl=
ag.AARCH64] section. In the v3 patchset, the flag was under [PcdsFeatureFla=
g.common] section. This was required to avoid the build break of Standalone=
Mm for X64 builds. I do have your R-b on other patches which have not been =
changed from the previous versions.
>

Fair enough.