From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by mx.groups.io with SMTP id smtpd.web09.9030.1666269311451776492
 for <devel@edk2.groups.io>;
 Thu, 20 Oct 2022 05:35:12 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=phvPEKC0;
 spf=pass (domain: kernel.org, ip: 145.40.73.55, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by sin.source.kernel.org (Postfix) with ESMTPS id 52B6CCE253C
	for <devel@edk2.groups.io>; Thu, 20 Oct 2022 12:35:08 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9472FC433D7
	for <devel@edk2.groups.io>; Thu, 20 Oct 2022 12:35:06 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666269306;
	bh=Em2U8TYLe8xEVs1+UxvshQ+7AOs0qv80/g+usRo2YOE=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=phvPEKC0yoONGxRE+yk8j76hqvFZVgEOQw47mbTMXsLBSRPG1VU6DxshdWX8wUv1q
	 U/EkDESX8tRtA3lnIpcbMpQluDV5SQxlq6EYkWrxfgSKCjaj8IrfyPXW5GJ1ECLshO
	 AOBPMhoTjxAJl8CZqNNePDWlOrfrdfhnXwQdg/kLjBMqhLltlubYz7QODrte5smv8e
	 MPpNovWZMOJ8EigyeBuiFOZrBRWNX4QeW/QcBKHQJ2SfdaGJsKa18lGty00eU91lsN
	 ecQAVyhdJifZRmGJ96lAV4aMc5go5ccuvqJD1c3yWU0wBU4kBJMzXyTay+QKGIvx2P
	 eMDFJ5jlfy70Q==
Received: by mail-lj1-f181.google.com with SMTP id m23so26148308lji.2
        for <devel@edk2.groups.io>; Thu, 20 Oct 2022 05:35:06 -0700 (PDT)
X-Gm-Message-State: ACrzQf3B5FAisT++z4Wyao7hJSJuUWMPxuyIBvmiLg0dO/wTsGbK0UK0
	Wu8sza5bEpiZCiYV1UZ06PEFRm/rdJy3mufX164=
X-Google-Smtp-Source: AMsMyM46GcDjmLJ+h7p3+LzS7mVkAAU2q6sjZGco4UtkFJ7JJghXlEJrtXdUzGTNZrkRi0j82gu/9yZkHD9NmUbDrhk=
X-Received: by 2002:a05:651c:b2b:b0:26f:cf40:a560 with SMTP id
 b43-20020a05651c0b2b00b0026fcf40a560mr4986863ljr.516.1666269304596; Thu, 20
 Oct 2022 05:35:04 -0700 (PDT)
MIME-Version: 1.0
References: <20221019092211.465699-1-ardb@kernel.org> <20221019092211.465699-3-ardb@kernel.org>
 <Y1EO5jRsMuqZXPYl@qc-i7.hemma.eciton.net>
In-Reply-To: <Y1EO5jRsMuqZXPYl@qc-i7.hemma.eciton.net>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Thu, 20 Oct 2022 14:34:52 +0200
X-Gmail-Original-Message-ID: <CAMj1kXEzpoBKKM0JAfpd7XEyZtBXH5R3DBufn2ARBGfG_ZPn4g@mail.gmail.com>
Message-ID: <CAMj1kXEzpoBKKM0JAfpd7XEyZtBXH5R3DBufn2ARBGfG_ZPn4g@mail.gmail.com>
Subject: Re: [PATCH v3 resend 02/11] ArmVirtPkg: do not enable iSCSI driver by default
To: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: devel@edk2.groups.io, Alexander Graf <agraf@csgraf.de>, 
	Gerd Hoffmann <kraxel@redhat.com>, Sami Mujawar <Sami.Mujawar@arm.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, 20 Oct 2022 at 11:04, Leif Lindholm <quic_llindhol@quicinc.com> wrote:
>
> On Wed, Oct 19, 2022 at 11:22:02 +0200, Ard Biesheuvel wrote:
> > The iSCSI driver slows down the boot on a pristine variable store flash
> > image, as it creates a couple of large EFI non-volatile variables to
> > preserve state between boots.
> >
> > Since iSCSI boot for VMs is kind of niche anyway, let's default to
> > disabled. If someone needs it in their build, they can use the -D build
> > command option to re-enable it on the fly.
> >
> > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
>
> Apologies for bikeshedding, but ... I find the listing of tweakable
> options in a block at the start of a .dsc very useful.
> Could we explicitly set to FALSE instead?
>

Sure

> Either way:
> Acked-by: Leif Lindholm <quic_llindhol@quicinc.com>
>

Thanks.

> > ---
> >  ArmVirtPkg/ArmVirtQemu.dsc       | 1 -
> >  ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 -
> >  2 files changed, 2 deletions(-)
> >
> > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
> > index 9369a88858fd..45c4a8fc84e0 100644
> > --- a/ArmVirtPkg/ArmVirtQemu.dsc
> > +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> > @@ -40,7 +40,6 @@ [Defines]
> >    DEFINE NETWORK_SNP_ENABLE              = FALSE
> >    DEFINE NETWORK_TLS_ENABLE              = FALSE
> >    DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS  = TRUE
> > -  DEFINE NETWORK_ISCSI_ENABLE            = TRUE
> >
> >  !if $(NETWORK_SNP_ENABLE) == TRUE
> >    !error "NETWORK_SNP_ENABLE is IA32/X64/EBC only"
> > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> > index 7f7d15d6eee3..66039f07f41b 100644
> > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
> > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> > @@ -38,7 +38,6 @@ [Defines]
> >    DEFINE NETWORK_SNP_ENABLE              = FALSE
> >    DEFINE NETWORK_TLS_ENABLE              = FALSE
> >    DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS  = TRUE
> > -  DEFINE NETWORK_ISCSI_ENABLE            = TRUE
> >
> >  !if $(NETWORK_SNP_ENABLE) == TRUE
> >    !error "NETWORK_SNP_ENABLE is IA32/X64/EBC only"
> > --
> > 2.35.1
> >