Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg/VmgExitLib: Fix uninitialized variable warning with XCODE5

["Ard Biesheuvel" <ardb@kernel.org>]

(+ Liming)

On Fri, 4 Feb 2022 at 21:28, Rebecca Cran <quic_rcran@quicinc.com> wrote:
>
> XCODE5 reported the following warning:
>
> OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1895:12: note:
> uninitialized use occurs here
>            Compacted
>            ^^^^^^^^^
>
> Initialize the 'Compacted' variable to fix the warning.
>
> Signed-off-by: Rebecca Cran <quic_rcran@quicinc.com>
> ---
>  OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
> index a40a31f7c275..ccb1300690fa 100644
> --- a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
> +++ b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
> @@ -1872,6 +1872,7 @@ GetCpuidFw (
>      UINT32                 XSaveSize;
>
>      XssMsr.Uint64 = 0;
> +    Compacted     = 0;

This should be FALSE not 0. I will fix this up before merging.

Liming: is it ok if I merge this today?


>      if (EcxIn == 1) {
>        /*
>         * The PPR and APM aren't clear on what size should be encoded in
> --
> 2.34.1
>
>
>
> 
>
>