From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by mx.groups.io with SMTP id smtpd.web11.200585.1673971456366536897
 for <devel@edk2.groups.io>;
 Tue, 17 Jan 2023 08:04:16 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uN1Dglkc;
 spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dfw.source.kernel.org (Postfix) with ESMTPS id 6FD736149C
	for <devel@edk2.groups.io>; Tue, 17 Jan 2023 16:04:15 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9F96C433F1
	for <devel@edk2.groups.io>; Tue, 17 Jan 2023 16:04:14 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1673971454;
	bh=puTeu7i62rNiVIbKQatPLh4zZPCt4xCfqRG5jpWrOuM=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=uN1DglkcasOpgPynBw82b2bN/5/PgyL81kBRTlaDS3NaXApV1/yb369AHj3rs0Asa
	 UjNhpOZ94MVWbSzAK/Zi9OOS4KrKUrlP4Ei0JqZCifacB3ab8Ka+W8CA+f4SmpjFY9
	 P3Cop69NDctIfhxOTHU2lFC+IJ4irdsg96fuQwOCJ7kqUZlMauZfLtq7LkBtkckNHS
	 A0Bk3KwxoFR77WRVsL+drNTMOxOSWiBdS04danCzG8l7Q/Kym8Jjaaj2igOPTnxgg1
	 SerDfA1lxCyqLKIyoALdqoKMC9zz11SqVTZH8MLYlzFmGRD6/BfY0h5/heLyGu81cA
	 nESBe3w8WcQmQ==
Received: by mail-lf1-f43.google.com with SMTP id a11so7642745lfg.0
        for <devel@edk2.groups.io>; Tue, 17 Jan 2023 08:04:14 -0800 (PST)
X-Gm-Message-State: AFqh2kqLeB10Ep0eOM0KnjopRy8vhH2zQYnkXE4ydijukPtNLkvi2QSP
	kWtD3EHWvncI26kbq8H8fTPXFNaKKNOzylixwso=
X-Google-Smtp-Source: AMrXdXtSEc+J61Vz0ROH6DSOckPyu0a7YPX8xe/wuGsi+Rv1Ju3fBtdGLuRsISf0nULj+KuJUQL/unf11CtpdQa5WtQ=
X-Received: by 2002:a05:6512:118a:b0:4cc:9d69:4703 with SMTP id
 g10-20020a056512118a00b004cc9d694703mr352951lfr.110.1673971452856; Tue, 17
 Jan 2023 08:04:12 -0800 (PST)
MIME-Version: 1.0
References: <20230117121629.2149112-1-kraxel@redhat.com> <20230117121629.2149112-4-kraxel@redhat.com>
 <64b79c1e-dc09-75d1-3345-4620ffe63629@redhat.com>
In-Reply-To: <64b79c1e-dc09-75d1-3345-4620ffe63629@redhat.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Tue, 17 Jan 2023 17:04:01 +0100
X-Gmail-Original-Message-ID: <CAMj1kXF-85B30foC3JYik0fGpwUWOxZ_spToCYEEUQr9aPVduQ@mail.gmail.com>
Message-ID: <CAMj1kXF-85B30foC3JYik0fGpwUWOxZ_spToCYEEUQr9aPVduQ@mail.gmail.com>
Subject: Re: [PATCH v4 3/5] OvmfPkg/PlatformInitLib: Add PlatformAddHobCB
To: Laszlo Ersek <lersek@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, devel@edk2.groups.io, 
	Jiewen Yao <jiewen.yao@intel.com>, Oliver Steffen <osteffen@redhat.com>, 
	Ard Biesheuvel <ardb+tianocore@kernel.org>, Pawel Polawski <ppolawsk@redhat.com>, 
	Jordan Justen <jordan.l.justen@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Tue, 17 Jan 2023 at 16:03, Laszlo Ersek <lersek@redhat.com> wrote:
>
> On 1/17/23 13:16, Gerd Hoffmann wrote:

> > +          PlatformAddMemoryRangeHob (Base, End);
> > +        }
> > +      }
> > +
>
> (2) Still not sure if this empty line is intentional (it may be, you
> didn't answer it under the v2 review AFAICT).
>

As it turns out, yes. Uncrustify demands a newline here, or else ....