From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 93F1CAC13AF for ; Fri, 8 Sep 2023 15:43:35 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=b8naPlh13nPEnmA8K8aPW26kmuol9//3J/I6QLqlOP8=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694187814; v=1; b=UjDcwBX51geupTq1clX6NWV66kAMRBXbHUkqpx7v3QDw8zzOC5Bcu+XmJcDORcC8IS0Vrr8A rvkmsdlPsAqsQYRbaZbGhGiF+V1HtzpKhSnDaMN+cwVNfvggBCWtz2Gm01e85MXWSNfURVIs62I O3kpL9vHN9b/rdv5wcAV2q0A= X-Received: by 127.0.0.2 with SMTP id yQT6YY7687511xNnO39SprHC; Fri, 08 Sep 2023 08:43:34 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.45.1694187810330144516 for ; Fri, 08 Sep 2023 08:43:30 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CA1DC614FF for ; Fri, 8 Sep 2023 15:43:29 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B807C433CC for ; Fri, 8 Sep 2023 15:43:29 +0000 (UTC) X-Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2bcb89b476bso37635391fa.1 for ; Fri, 08 Sep 2023 08:43:29 -0700 (PDT) X-Gm-Message-State: gGEXy5nS1ZlLtKlMdWeobPfbx7686176AA= X-Google-Smtp-Source: AGHT+IHHhDoZl6LygnzgK6ZbMFwo68SwQeitB1wMRphQV14eb6cbLOrOZDDRc21kCUwM9qCnVJOBr0RIwv2sintiGA8= X-Received: by 2002:a2e:9bcf:0:b0:2bc:dfc0:1afc with SMTP id w15-20020a2e9bcf000000b002bcdfc01afcmr2206457ljj.10.1694187807438; Fri, 08 Sep 2023 08:43:27 -0700 (PDT) MIME-Version: 1.0 References: <20230907083429.82300-1-corvink@FreeBSD.org> <20230907083429.82300-2-corvink@FreeBSD.org> <6b76efe3-6376-f7b9-1638-eb148ba8fa2a@bsdio.com> In-Reply-To: <6b76efe3-6376-f7b9-1638-eb148ba8fa2a@bsdio.com> From: "Ard Biesheuvel" Date: Fri, 8 Sep 2023 17:43:16 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: don't exit early if RSDP is not found in memory To: Rebecca Cran Cc: devel@edk2.groups.io, corvink@freebsd.org, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Peter Grehan Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=UjDcwBX5; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, 8 Sept 2023 at 15:58, Rebecca Cran wrote: > > Reviewed-by: Rebecca Cran > > On 9/7/23 02:34, Corvin K=C3=B6hne wrote: > > If OVMF fails to find the RSDP in memory, it should fall back installin= g > > the statically provided ACPI tables. > > > > Signed-off-by: Corvin K=C3=B6hne > > Cc: Ard Biesheuvel > > Cc: Jiewen Yao > > Cc: Jordan Justen > > Cc: Gerd Hoffmann > > Cc: Rebecca Cran > > Cc: Peter Grehan Merged as #4810 > > --- > > OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 19 ++++++++----------- > > 1 file changed, 8 insertions(+), 11 deletions(-) > > > > diff --git a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c b/OvmfPkg/Bhy= ve/AcpiPlatformDxe/AcpiPlatform.c > > index fb926a8bd803..57b1e7a99666 100644 > > --- a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c > > +++ b/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c > > @@ -259,19 +259,17 @@ InstallAcpiTables ( > > BHYVE_BIOS_PHYSICAL_END, > > &Rsdp > > ); > > - if (EFI_ERROR (Status)) { > > - return Status; > > - } > > - > > - Status =3D InstallAcpiTablesFromRsdp ( > > - AcpiTable, > > - Rsdp > > - ); > > if (!EFI_ERROR (Status)) { > > - return EFI_SUCCESS; > > + Status =3D InstallAcpiTablesFromRsdp ( > > + AcpiTable, > > + Rsdp > > + ); > > + if (!EFI_ERROR (Status)) { > > + return EFI_SUCCESS; > > + } > > } > > > > - if (Status !=3D EFI_NOT_FOUND) { > > + if (EFI_ERROR (Status)) { > > DEBUG ( > > ( > > DEBUG_WARN, > > @@ -280,7 +278,6 @@ InstallAcpiTables ( > > Status > > ) > > ); > > - return Status; > > } > > > > Status =3D InstallOvmfFvTables (AcpiTable); -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108450): https://edk2.groups.io/g/devel/message/108450 Mute This Topic: https://groups.io/mt/101210702/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-