* [edk2-devel] [PATCH v1 0/1] OvmfPkg/Bhyve: properly fall back to static ACPI tables @ 2023-09-07 8:33 Corvin Köhne 2023-09-07 8:34 ` [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: don't exit early if RSDP is not found in memory Corvin Köhne 0 siblings, 1 reply; 5+ messages in thread From: Corvin Köhne @ 2023-09-07 8:33 UTC (permalink / raw) To: devel CI: https://github.com/tianocore/edk2/pull/4799 Corvin Köhne (1): OvmfPkg/Bhyve: don't exit early if RSDP is not found in memory OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) -- 2.42.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108366): https://edk2.groups.io/g/devel/message/108366 Mute This Topic: https://groups.io/mt/101210701/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 5+ messages in thread
* [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: don't exit early if RSDP is not found in memory 2023-09-07 8:33 [edk2-devel] [PATCH v1 0/1] OvmfPkg/Bhyve: properly fall back to static ACPI tables Corvin Köhne @ 2023-09-07 8:34 ` Corvin Köhne 2023-09-07 9:54 ` Ard Biesheuvel 2023-09-08 13:58 ` Rebecca Cran 0 siblings, 2 replies; 5+ messages in thread From: Corvin Köhne @ 2023-09-07 8:34 UTC (permalink / raw) To: devel Cc: Ard Biesheuvel, Jiewen Yao, Jordan Justen, Gerd Hoffmann, Rebecca Cran, Peter Grehan If OVMF fails to find the RSDP in memory, it should fall back installing the statically provided ACPI tables. Signed-off-by: Corvin Köhne <corvink@FreeBSD.org> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Jiewen Yao <jiewen.yao@intel.com> Cc: Jordan Justen <jordan.l.justen@intel.com> Cc: Gerd Hoffmann <kraxel@redhat.com> Cc: Rebecca Cran <rebecca@bsdio.com> Cc: Peter Grehan <grehan@freebsd.org> --- OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c b/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c index fb926a8bd803..57b1e7a99666 100644 --- a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c +++ b/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c @@ -259,19 +259,17 @@ InstallAcpiTables ( BHYVE_BIOS_PHYSICAL_END, &Rsdp ); - if (EFI_ERROR (Status)) { - return Status; - } - - Status = InstallAcpiTablesFromRsdp ( - AcpiTable, - Rsdp - ); if (!EFI_ERROR (Status)) { - return EFI_SUCCESS; + Status = InstallAcpiTablesFromRsdp ( + AcpiTable, + Rsdp + ); + if (!EFI_ERROR (Status)) { + return EFI_SUCCESS; + } } - if (Status != EFI_NOT_FOUND) { + if (EFI_ERROR (Status)) { DEBUG ( ( DEBUG_WARN, @@ -280,7 +278,6 @@ InstallAcpiTables ( Status ) ); - return Status; } Status = InstallOvmfFvTables (AcpiTable); -- 2.42.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108367): https://edk2.groups.io/g/devel/message/108367 Mute This Topic: https://groups.io/mt/101210702/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: don't exit early if RSDP is not found in memory 2023-09-07 8:34 ` [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: don't exit early if RSDP is not found in memory Corvin Köhne @ 2023-09-07 9:54 ` Ard Biesheuvel 2023-09-08 13:58 ` Rebecca Cran 1 sibling, 0 replies; 5+ messages in thread From: Ard Biesheuvel @ 2023-09-07 9:54 UTC (permalink / raw) To: devel, corvink Cc: Ard Biesheuvel, Jiewen Yao, Jordan Justen, Gerd Hoffmann, Rebecca Cran, Peter Grehan On Thu, 7 Sept 2023 at 10:34, Corvin Köhne <corvink@freebsd.org> wrote: > > If OVMF fails to find the RSDP in memory, it should fall back installing > the statically provided ACPI tables. > > Signed-off-by: Corvin Köhne <corvink@FreeBSD.org> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > Cc: Jiewen Yao <jiewen.yao@intel.com> > Cc: Jordan Justen <jordan.l.justen@intel.com> > Cc: Gerd Hoffmann <kraxel@redhat.com> > Cc: Rebecca Cran <rebecca@bsdio.com> > Cc: Peter Grehan <grehan@freebsd.org> Nit: please cc the cover letter to the same group of people as the actual patches. Typically, I add the cc's to the cover letter only, and use --cc-cover with git send-email. That way, the cc's don't pollute the commit log either. The patch looks fine to me but i'd like someone with a clue about bhyve to review/ack it as well. Thanks, Ard. > --- > OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 19 ++++++++----------- > 1 file changed, 8 insertions(+), 11 deletions(-) > > diff --git a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c b/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c > index fb926a8bd803..57b1e7a99666 100644 > --- a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c > +++ b/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c > @@ -259,19 +259,17 @@ InstallAcpiTables ( > BHYVE_BIOS_PHYSICAL_END, > &Rsdp > ); > - if (EFI_ERROR (Status)) { > - return Status; > - } > - > - Status = InstallAcpiTablesFromRsdp ( > - AcpiTable, > - Rsdp > - ); > if (!EFI_ERROR (Status)) { > - return EFI_SUCCESS; > + Status = InstallAcpiTablesFromRsdp ( > + AcpiTable, > + Rsdp > + ); > + if (!EFI_ERROR (Status)) { > + return EFI_SUCCESS; > + } > } > > - if (Status != EFI_NOT_FOUND) { > + if (EFI_ERROR (Status)) { > DEBUG ( > ( > DEBUG_WARN, > @@ -280,7 +278,6 @@ InstallAcpiTables ( > Status > ) > ); > - return Status; > } > > Status = InstallOvmfFvTables (AcpiTable); > -- > 2.42.0 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108371): https://edk2.groups.io/g/devel/message/108371 Mute This Topic: https://groups.io/mt/101210702/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: don't exit early if RSDP is not found in memory 2023-09-07 8:34 ` [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: don't exit early if RSDP is not found in memory Corvin Köhne 2023-09-07 9:54 ` Ard Biesheuvel @ 2023-09-08 13:58 ` Rebecca Cran 2023-09-08 15:43 ` Ard Biesheuvel 1 sibling, 1 reply; 5+ messages in thread From: Rebecca Cran @ 2023-09-08 13:58 UTC (permalink / raw) To: devel, corvink Cc: Ard Biesheuvel, Jiewen Yao, Jordan Justen, Gerd Hoffmann, Peter Grehan Reviewed-by: Rebecca Cran <rebecca@bsdio.com> On 9/7/23 02:34, Corvin Köhne wrote: > If OVMF fails to find the RSDP in memory, it should fall back installing > the statically provided ACPI tables. > > Signed-off-by: Corvin Köhne <corvink@FreeBSD.org> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > Cc: Jiewen Yao <jiewen.yao@intel.com> > Cc: Jordan Justen <jordan.l.justen@intel.com> > Cc: Gerd Hoffmann <kraxel@redhat.com> > Cc: Rebecca Cran <rebecca@bsdio.com> > Cc: Peter Grehan <grehan@freebsd.org> > --- > OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 19 ++++++++----------- > 1 file changed, 8 insertions(+), 11 deletions(-) > > diff --git a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c b/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c > index fb926a8bd803..57b1e7a99666 100644 > --- a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c > +++ b/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c > @@ -259,19 +259,17 @@ InstallAcpiTables ( > BHYVE_BIOS_PHYSICAL_END, > &Rsdp > ); > - if (EFI_ERROR (Status)) { > - return Status; > - } > - > - Status = InstallAcpiTablesFromRsdp ( > - AcpiTable, > - Rsdp > - ); > if (!EFI_ERROR (Status)) { > - return EFI_SUCCESS; > + Status = InstallAcpiTablesFromRsdp ( > + AcpiTable, > + Rsdp > + ); > + if (!EFI_ERROR (Status)) { > + return EFI_SUCCESS; > + } > } > > - if (Status != EFI_NOT_FOUND) { > + if (EFI_ERROR (Status)) { > DEBUG ( > ( > DEBUG_WARN, > @@ -280,7 +278,6 @@ InstallAcpiTables ( > Status > ) > ); > - return Status; > } > > Status = InstallOvmfFvTables (AcpiTable); -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108448): https://edk2.groups.io/g/devel/message/108448 Mute This Topic: https://groups.io/mt/101210702/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: don't exit early if RSDP is not found in memory 2023-09-08 13:58 ` Rebecca Cran @ 2023-09-08 15:43 ` Ard Biesheuvel 0 siblings, 0 replies; 5+ messages in thread From: Ard Biesheuvel @ 2023-09-08 15:43 UTC (permalink / raw) To: Rebecca Cran Cc: devel, corvink, Ard Biesheuvel, Jiewen Yao, Jordan Justen, Gerd Hoffmann, Peter Grehan On Fri, 8 Sept 2023 at 15:58, Rebecca Cran <rebecca@bsdio.com> wrote: > > Reviewed-by: Rebecca Cran <rebecca@bsdio.com> > > On 9/7/23 02:34, Corvin Köhne wrote: > > If OVMF fails to find the RSDP in memory, it should fall back installing > > the statically provided ACPI tables. > > > > Signed-off-by: Corvin Köhne <corvink@FreeBSD.org> > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > > Cc: Jiewen Yao <jiewen.yao@intel.com> > > Cc: Jordan Justen <jordan.l.justen@intel.com> > > Cc: Gerd Hoffmann <kraxel@redhat.com> > > Cc: Rebecca Cran <rebecca@bsdio.com> > > Cc: Peter Grehan <grehan@freebsd.org> Merged as #4810 > > --- > > OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 19 ++++++++----------- > > 1 file changed, 8 insertions(+), 11 deletions(-) > > > > diff --git a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c b/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c > > index fb926a8bd803..57b1e7a99666 100644 > > --- a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c > > +++ b/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c > > @@ -259,19 +259,17 @@ InstallAcpiTables ( > > BHYVE_BIOS_PHYSICAL_END, > > &Rsdp > > ); > > - if (EFI_ERROR (Status)) { > > - return Status; > > - } > > - > > - Status = InstallAcpiTablesFromRsdp ( > > - AcpiTable, > > - Rsdp > > - ); > > if (!EFI_ERROR (Status)) { > > - return EFI_SUCCESS; > > + Status = InstallAcpiTablesFromRsdp ( > > + AcpiTable, > > + Rsdp > > + ); > > + if (!EFI_ERROR (Status)) { > > + return EFI_SUCCESS; > > + } > > } > > > > - if (Status != EFI_NOT_FOUND) { > > + if (EFI_ERROR (Status)) { > > DEBUG ( > > ( > > DEBUG_WARN, > > @@ -280,7 +278,6 @@ InstallAcpiTables ( > > Status > > ) > > ); > > - return Status; > > } > > > > Status = InstallOvmfFvTables (AcpiTable); -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108450): https://edk2.groups.io/g/devel/message/108450 Mute This Topic: https://groups.io/mt/101210702/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-09-08 15:43 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-09-07 8:33 [edk2-devel] [PATCH v1 0/1] OvmfPkg/Bhyve: properly fall back to static ACPI tables Corvin Köhne 2023-09-07 8:34 ` [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: don't exit early if RSDP is not found in memory Corvin Köhne 2023-09-07 9:54 ` Ard Biesheuvel 2023-09-08 13:58 ` Rebecca Cran 2023-09-08 15:43 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox