Re: [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Fix dwc2 reset on raspberry pi boards

["Ard Biesheuvel" <ardb@kernel.org>]

On Thu, 11 Mar 2021 at 13:40, René Treffer <treffer+groups.io@measite.de> wrote:
>
> DwHcReset expects attributes as the second argument. A reset is
> performed if the passed attribute is valid. However 0 is not a valid
> attribute and will thus never cause a controller reset.
>
> Passing EFI_USB_HC_RESET_HOST_CONTROLLER will reset the dwc2 controller
> as expected.
>
> This enables the USB 2.0 port of the raspberry compute module 4.

Thanks for the patch (and for the review, Samer)

Please resend this patch (with Samer's Reviewed-by included) with a
signed-off-by line, otherwise I cannot merge this.

Thanks,
Ard.


> ---
>  Platform/RaspberryPi/Drivers/DwUsbHostDxe/DriverBinding.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/RaspberryPi/Drivers/DwUsbHostDxe/DriverBinding.c
> b/Platform/RaspberryPi/Drivers/DwUsbHostDxe/DriverBinding.c
> index bada13a6cd..bb228e62d9 100644
> --- a/Platform/RaspberryPi/Drivers/DwUsbHostDxe/DriverBinding.c
> +++ b/Platform/RaspberryPi/Drivers/DwUsbHostDxe/DriverBinding.c
> @@ -140,7 +140,7 @@ DriverStart (
>     * UsbBusDxe as of b4e96b82b4e2e47e95014b51787ba5b43abac784 expects
>     * the HCD to do this. There is no agent invoking DwHcReset anymore.
>     */
> -  DwHcReset (&DwHc->DwUsbOtgHc, 0);
> +  DwHcReset (&DwHc->DwUsbOtgHc, EFI_USB_HC_RESET_HOST_CONTROLLER);
>    DwHcSetState (&DwHc->DwUsbOtgHc, EfiUsbHcStateOperational);
>
>    Status = gBS->InstallMultipleProtocolInterfaces (
> --
> 2.27.0
>