From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by mx.groups.io with SMTP id smtpd.web10.285.1615564845386177698
 for <devel@edk2.groups.io>;
 Fri, 12 Mar 2021 08:00:45 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IC5cDucu;
 spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 94FC965006
	for <devel@edk2.groups.io>; Fri, 12 Mar 2021 16:00:44 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1615564844;
	bh=P7mM+od5OkF9/2mnTaHfpT6XusaIsdoF0w69EK2o1ZI=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=IC5cDucuwO3sISQJp3+OkXqqVXBtOUR+K6QxNWqValiVI0+8mfjQDOQp4M4335KKn
	 /ByIW/BtkyemvG2TDGAyOp/7d2Lyu0tYQT2iTldf/aI8Mr2Z5H9gJG+OeQgPdS8V5E
	 Rke/lB6Q6WC9D77q+Ku1Qlj3yIeI2yE4l6yguO3W+iqDeoJywVH1SI5gkYOL+rU49D
	 VHrrn82ezqM6ByGZ5a+9LrE1HYIAWdGB46d4U251pVw8+N3m5DqybcUW8bUdVo8bBV
	 FPSQh4zqjeMS6W0ZQs1db5Cvp6Tcr5xZSXslsPqcKyb7TD694uHvBOWVRDdGii+Bqf
	 xEpFK0zRbfaIw==
Received: by mail-oi1-f179.google.com with SMTP id u62so11509323oib.6
        for <devel@edk2.groups.io>; Fri, 12 Mar 2021 08:00:44 -0800 (PST)
X-Gm-Message-State: AOAM533SLDDAVKa2UHw4ZdD/mB7kZ+mFpCXkArK9ys3yy9qeGgsJvL5M
	oN+Zsxcc21hGlpI3zcXL6T6wqPUABXpb1G+VlBE=
X-Google-Smtp-Source: ABdhPJx3oXvAvoKoJc6H+Z8vZFP9VdQkX1Vtw31n8Tq4u6AZBhcoEavh+Z8pRsYJ1VpMpJSyeRtQT24dQdJfS8hlIeY=
X-Received: by 2002:aca:538c:: with SMTP id h134mr10333881oib.174.1615564843902;
 Fri, 12 Mar 2021 08:00:43 -0800 (PST)
MIME-Version: 1.0
References: <7669a539-91a0-7b48-a6b7-897dbfeda3ae@measite.de>
In-Reply-To: <7669a539-91a0-7b48-a6b7-897dbfeda3ae@measite.de>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Fri, 12 Mar 2021 17:00:32 +0100
X-Gmail-Original-Message-ID: <CAMj1kXF-jQHTXpf2V-JiY90OtOgXe7Ljt3KJeFOg2x+-Pd+jOw@mail.gmail.com>
Message-ID: <CAMj1kXF-jQHTXpf2V-JiY90OtOgXe7Ljt3KJeFOg2x+-Pd+jOw@mail.gmail.com>
Subject: Re: [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Fix dwc2 reset on raspberry pi boards
To: =?UTF-8?Q?Ren=C3=A9_Treffer?= <treffer+groups.io@measite.de>
Cc: devel@edk2.groups.io, Pete Batard <pete@akeo.ie>, Leif Lindholm <leif@nuviainc.com>, 
	Ard Biesheuvel <ardb+tianocore@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 11 Mar 2021 at 13:40, Ren=C3=A9 Treffer <treffer+groups.io@measite.=
de> wrote:
>
> DwHcReset expects attributes as the second argument. A reset is
> performed if the passed attribute is valid. However 0 is not a valid
> attribute and will thus never cause a controller reset.
>
> Passing EFI_USB_HC_RESET_HOST_CONTROLLER will reset the dwc2 controller
> as expected.
>
> This enables the USB 2.0 port of the raspberry compute module 4.

Thanks for the patch (and for the review, Samer)

Please resend this patch (with Samer's Reviewed-by included) with a
signed-off-by line, otherwise I cannot merge this.

Thanks,
Ard.


> ---
>  Platform/RaspberryPi/Drivers/DwUsbHostDxe/DriverBinding.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/RaspberryPi/Drivers/DwUsbHostDxe/DriverBinding.c
> b/Platform/RaspberryPi/Drivers/DwUsbHostDxe/DriverBinding.c
> index bada13a6cd..bb228e62d9 100644
> --- a/Platform/RaspberryPi/Drivers/DwUsbHostDxe/DriverBinding.c
> +++ b/Platform/RaspberryPi/Drivers/DwUsbHostDxe/DriverBinding.c
> @@ -140,7 +140,7 @@ DriverStart (
>     * UsbBusDxe as of b4e96b82b4e2e47e95014b51787ba5b43abac784 expects
>     * the HCD to do this. There is no agent invoking DwHcReset anymore.
>     */
> -  DwHcReset (&DwHc->DwUsbOtgHc, 0);
> +  DwHcReset (&DwHc->DwUsbOtgHc, EFI_USB_HC_RESET_HOST_CONTROLLER);
>    DwHcSetState (&DwHc->DwUsbOtgHc, EfiUsbHcStateOperational);
>
>    Status =3D gBS->InstallMultipleProtocolInterfaces (
> --
> 2.27.0
>