From: "Ard Biesheuvel" <ardb@kernel.org>
To: Rebecca Cran <rebecca@nuviainc.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
Jiewen Yao <jiewen.yao@intel.com>,
Jian J Wang <jian.j.wang@intel.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Zhiguang Liu <zhiguang.liu@intel.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Sami Mujawar <sami.mujawar@arm.com>
Subject: Re: [PATCH v2 0/2] MdePkg,SecurityPkg: Add support to RngDxe and BaseRngLib for AARCH64 RNDR
Date: Fri, 7 May 2021 19:28:21 +0200 [thread overview]
Message-ID: <CAMj1kXF0oddRcBTOmB4heW=Uy2Xz=J7BA0Hq90=Wrtaw0aR6Tw@mail.gmail.com> (raw)
In-Reply-To: <20210507142315.679-1-rebecca@nuviainc.com>
On Fri, 7 May 2021 at 16:23, Rebecca Cran <rebecca@nuviainc.com> wrote:
>
> Update MdePkg BaseRngLib and SecurityPkg RngDxe to add support for
> the AARCH64 RNDR instruction.
>
> Changes from v1 to v2:
>
> o Added a PCD, gEfiSecurityPkgTokenSpaceGuid.PcdCpuRngSupportedAlgorithm to
> specify which algorighm the platform supports.
> o Moved ArmRndr() and ArmRndrrs() into BaseRngLib.
> o Added Doxygen headers.
> o Merged X64 and AARCH64 *GetBytes functions into a single RngGetBytes
> function.
> o Updated constructors to return EFI_STATUS instead of RETURN_STATUS.
> o Added ArchIsRngSupported function that gets called before each call to
> ArchGetRandomNumber*.
>
> Rebecca Cran (2):
> MdePkg/BaseRngLib: Add support for ARMv8.5 RNG instructions
> SecurityPkg: Add support for RngDxe on AARCH64
>
I don't maintain any of the packages involved, but the changes look fine to me.
Acked-by: Ard Biesheuvel <ardb@kernel.org>
> MdePkg/MdePkg.dec | 9 +-
> SecurityPkg/SecurityPkg.dec | 2 +
> MdePkg/MdePkg.dsc | 4 +-
> SecurityPkg/SecurityPkg.dsc | 11 +-
> MdePkg/Library/BaseRngLib/BaseRngLib.inf | 23 ++-
> SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf | 24 ++-
> MdePkg/Library/BaseRngLib/AArch64/ArmRng.h | 59 +++++++
> MdePkg/Library/BaseRngLib/BaseRngLibInternals.h | 79 +++++++++
> SecurityPkg/RandomNumberGenerator/RngDxe/{ => Rand}/AesCore.h | 0
> SecurityPkg/RandomNumberGenerator/RngDxe/{ => Rand}/RdRand.h | 17 --
> SecurityPkg/RandomNumberGenerator/RngDxe/RngDxeInternals.h | 117 ++++++++++++++
> MdePkg/Library/BaseRngLib/AArch64/Rndr.c | 139 ++++++++++++++++
> MdePkg/Library/BaseRngLib/BaseRng.c | 87 +++++-----
> MdePkg/Library/BaseRngLib/Rand/RdRand.c | 131 +++++++++++++++
> SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c | 127 +++++++++++++++
> SecurityPkg/RandomNumberGenerator/RngDxe/{ => Rand}/AesCore.c | 0
> SecurityPkg/RandomNumberGenerator/RngDxe/{ => Rand}/RdRand.c | 45 +-----
> SecurityPkg/RandomNumberGenerator/RngDxe/Rand/RngDxe.c | 146 +++++++++++++++++
> SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.c | 170 ++++++++------------
> MdePkg/Library/BaseRngLib/AArch64/ArmReadIdIsar0.S | 31 ++++
> MdePkg/Library/BaseRngLib/AArch64/ArmReadIdIsar0.asm | 30 ++++
> MdePkg/Library/BaseRngLib/AArch64/ArmRng.S | 61 +++++++
> MdePkg/Library/BaseRngLib/AArch64/ArmRng.asm | 64 ++++++++
> MdePkg/Library/BaseRngLib/BaseRngLib.uni | 6 +-
> 24 files changed, 1152 insertions(+), 230 deletions(-)
> create mode 100644 MdePkg/Library/BaseRngLib/AArch64/ArmRng.h
> create mode 100644 MdePkg/Library/BaseRngLib/BaseRngLibInternals.h
> rename SecurityPkg/RandomNumberGenerator/RngDxe/{ => Rand}/AesCore.h (100%)
> rename SecurityPkg/RandomNumberGenerator/RngDxe/{ => Rand}/RdRand.h (72%)
> create mode 100644 SecurityPkg/RandomNumberGenerator/RngDxe/RngDxeInternals.h
> create mode 100644 MdePkg/Library/BaseRngLib/AArch64/Rndr.c
> create mode 100644 MdePkg/Library/BaseRngLib/Rand/RdRand.c
> create mode 100644 SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c
> rename SecurityPkg/RandomNumberGenerator/RngDxe/{ => Rand}/AesCore.c (100%)
> rename SecurityPkg/RandomNumberGenerator/RngDxe/{ => Rand}/RdRand.c (71%)
> create mode 100644 SecurityPkg/RandomNumberGenerator/RngDxe/Rand/RngDxe.c
> create mode 100644 MdePkg/Library/BaseRngLib/AArch64/ArmReadIdIsar0.S
> create mode 100644 MdePkg/Library/BaseRngLib/AArch64/ArmReadIdIsar0.asm
> create mode 100644 MdePkg/Library/BaseRngLib/AArch64/ArmRng.S
> create mode 100644 MdePkg/Library/BaseRngLib/AArch64/ArmRng.asm
>
> --
> 2.26.2
>
prev parent reply other threads:[~2021-05-07 17:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 14:23 [PATCH v2 0/2] MdePkg,SecurityPkg: Add support to RngDxe and BaseRngLib for AARCH64 RNDR Rebecca Cran
2021-05-07 14:23 ` [PATCH v2 1/2] MdePkg/BaseRngLib: Add support for ARMv8.5 RNG instructions Rebecca Cran
2021-05-08 1:35 ` 回复: " gaoliming
2021-05-07 14:23 ` [PATCH v2 2/2] SecurityPkg: Add support for RngDxe on AARCH64 Rebecca Cran
2021-05-08 1:32 ` 回复: " gaoliming
2021-05-07 17:28 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXF0oddRcBTOmB4heW=Uy2Xz=J7BA0Hq90=Wrtaw0aR6Tw@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox