Re: [edk2-devel] [PATCH v1 13/24] StandaloneMmPkg: CI: Add PrEval entry

["Ard Biesheuvel" <ardb@kernel.org>]

On Mon, 9 Oct 2023 at 18:49, Joey Vagedes <joey.vagedes@gmail.com> wrote:
>
> Hello All,
>
> Due to a Subject Line mistake, this particular patch was labeled as a CryptoPkg change. I'm resending this out to the package maintainers with the correct package (StandaloneMmPkg).
>
> Please review this change to your package's ci.yaml file ~ This change will ensure your package is properly tested if another package changes an INF that your package depends on to build, making sure it is not broken from another's change. If you wish for this to be merged into your package, please review.
>
> If not, I will be re-sending this patch series out with only the package's I have reviews on, to get it merged so that we can update edk2-pytools further. You will always be able to add this yourself at a later date if you wish.
>
> Thanks,
> Joey
>
>
> On Mon, Jun 26, 2023 at 2:35 PM Joey Vagedes <joey.vagedes@gmail.com> wrote:
>>
>> Adds a PrEval entry to the package's ci.yaml file which is used to
>> verify if the package uses a particular library instance when that
>> library instance file (INF) is updated.
>>
>> When a library instance file (INF) is updated, PrEval will review each
>> package's DSC as described in the ci.yaml file to determine if the
>> package uses said library instance. If the package does use the library
>> instance, it will be built and tested to ensure the package is not
>> broken from the change.
>>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>> Cc: Ray Ni <ray.ni@intel.com>
>> Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
>> ---
>>  StandaloneMmPkg/StandaloneMmPkg.ci.yaml | 3 +++
>>  1 file changed, 3 insertions(+)
>>

Fine with me

Acked-by: Ard Biesheuvel <ardb@kernel.org>

>> diff --git a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml b/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
>> index 4777532a7ede..f23f5f2c4db2 100644
>> --- a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
>> +++ b/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
>> @@ -5,6 +5,9 @@
>>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>>  ##
>>  {
>> +    "PrEval": {
>> +        "DscPath": "StandaloneMmPkg.dsc",
>> +    },
>>      "EccCheck": {
>>          ## Exception sample looks like below:
>>          ## "ExceptionList": [
>> --
>> 2.41.0.windows.1
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109476): https://edk2.groups.io/g/devel/message/109476
Mute This Topic: https://groups.io/mt/101856788/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-