public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ardb@kernel.org>
To: Joey Vagedes <joey.vagedes@gmail.com>
Cc: devel@edk2.groups.io, Sami Mujawar <sami.mujawar@arm.com>,
	Ray Ni <ray.ni@intel.com>
Subject: Re: [edk2-devel] [PATCH v1 13/24] StandaloneMmPkg: CI: Add PrEval entry
Date: Tue, 10 Oct 2023 09:44:26 +0200	[thread overview]
Message-ID: <CAMj1kXF2+uzY_kFnv9FcqyhM3HA44ya3AtOB3dtFNXbVK484PA@mail.gmail.com> (raw)
In-Reply-To: <CAKURc-_heGSLPymx389HqH4+o50fmrVUkRPQLYwhOTP35fuJCA@mail.gmail.com>

On Mon, 9 Oct 2023 at 18:49, Joey Vagedes <joey.vagedes@gmail.com> wrote:
>
> Hello All,
>
> Due to a Subject Line mistake, this particular patch was labeled as a CryptoPkg change. I'm resending this out to the package maintainers with the correct package (StandaloneMmPkg).
>
> Please review this change to your package's ci.yaml file ~ This change will ensure your package is properly tested if another package changes an INF that your package depends on to build, making sure it is not broken from another's change. If you wish for this to be merged into your package, please review.
>
> If not, I will be re-sending this patch series out with only the package's I have reviews on, to get it merged so that we can update edk2-pytools further. You will always be able to add this yourself at a later date if you wish.
>
> Thanks,
> Joey
>
>
> On Mon, Jun 26, 2023 at 2:35 PM Joey Vagedes <joey.vagedes@gmail.com> wrote:
>>
>> Adds a PrEval entry to the package's ci.yaml file which is used to
>> verify if the package uses a particular library instance when that
>> library instance file (INF) is updated.
>>
>> When a library instance file (INF) is updated, PrEval will review each
>> package's DSC as described in the ci.yaml file to determine if the
>> package uses said library instance. If the package does use the library
>> instance, it will be built and tested to ensure the package is not
>> broken from the change.
>>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>> Cc: Ray Ni <ray.ni@intel.com>
>> Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
>> ---
>>  StandaloneMmPkg/StandaloneMmPkg.ci.yaml | 3 +++
>>  1 file changed, 3 insertions(+)
>>

Fine with me

Acked-by: Ard Biesheuvel <ardb@kernel.org>

>> diff --git a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml b/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
>> index 4777532a7ede..f23f5f2c4db2 100644
>> --- a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
>> +++ b/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
>> @@ -5,6 +5,9 @@
>>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>>  ##
>>  {
>> +    "PrEval": {
>> +        "DscPath": "StandaloneMmPkg.dsc",
>> +    },
>>      "EccCheck": {
>>          ## Exception sample looks like below:
>>          ## "ExceptionList": [
>> --
>> 2.41.0.windows.1
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109476): https://edk2.groups.io/g/devel/message/109476
Mute This Topic: https://groups.io/mt/101856788/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2023-10-10  7:44 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-26 21:34 [PATCH v1 00/24] Update Edk2-pytools to latest versions Joey Vagedes
2023-06-26 21:34 ` [PATCH v1 01/24] Edk2: edk2-pytools: Update " Joey Vagedes
2023-07-05 17:33   ` Michael Kubacki
2023-06-26 21:34 ` [PATCH v1 02/24] UnitTestFrameworkPkg: CI: Add PrEval entry Joey Vagedes
2023-07-05 17:34   ` [edk2-devel] " Michael Kubacki
2023-06-26 21:34 ` [PATCH v1 03/24] UefiPayloadPkg: " Joey Vagedes
2023-06-26 21:34 ` [PATCH v1 04/24] ArmPkg: " Joey Vagedes
2023-06-26 21:34 ` [PATCH v1 05/24] UefiCpuPkg: " Joey Vagedes
2023-06-26 21:34 ` [PATCH v1 06/24] ArmPlatformPkg: " Joey Vagedes
2023-06-26 21:34 ` [PATCH v1 07/24] CryptoPkg: " Joey Vagedes
2023-08-02  4:41   ` [edk2-devel] " Li, Yi
     [not found]   ` <1777774354535489.2497@groups.io>
2023-10-07  3:07     ` Li, Yi
2023-10-09 16:26       ` Joey Vagedes via groups.io
2023-06-26 21:34 ` [PATCH v1 08/24] DynamicTablesPkg: " Joey Vagedes
2023-07-06 15:36   ` Sami Mujawar
2023-06-26 21:34 ` [PATCH v1 09/24] EmbeddedPkg: " Joey Vagedes
2023-06-28  6:20   ` Chang, Abner
2023-06-26 21:34 ` [PATCH v1 10/24] FatPkg: " Joey Vagedes
2023-06-26 21:34 ` [PATCH v1 11/24] FmpDevicePkg: " Joey Vagedes
2023-06-26 21:34 ` [PATCH v1 12/24] IntelFsp2Pkg: " Joey Vagedes
2023-08-07 22:57   ` [edk2-devel] " Nate DeSimone
2023-06-26 21:34 ` [PATCH v1 13/24] CryptoPkg: " Joey Vagedes
2023-10-09 16:49   ` [edk2-devel] [PATCH v1 13/24] StandaloneMmPkg: " Joey Vagedes via groups.io
2023-10-10  7:44     ` Ard Biesheuvel [this message]
2023-06-26 21:34 ` [PATCH v1 14/24] SourceLevelDebugPkg: " Joey Vagedes
2023-06-26 21:34 ` [PATCH v1 15/24] SignedCapsulePkg: " Joey Vagedes
2023-06-26 21:34 ` [PATCH v1 16/24] ShellPkg: " Joey Vagedes
2023-06-26 21:34 ` [PATCH v1 17/24] SecurityPkg: " Joey Vagedes
2023-06-26 21:34 ` [PATCH v1 18/24] RedfishPkg: " Joey Vagedes
2023-06-28  6:20   ` Chang, Abner
2023-06-26 21:34 ` [PATCH v1 19/24] PrmPkg: " Joey Vagedes
2023-07-05 17:34   ` [edk2-devel] " Michael Kubacki
2023-08-07 22:57   ` Nate DeSimone
2023-06-26 21:34 ` [PATCH v1 20/24] PcAtChipsetPkg: " Joey Vagedes
2023-06-26 21:34 ` [PATCH v1 21/24] NetworkPkg: " Joey Vagedes
2023-06-26 21:34 ` [PATCH v1 22/24] MdePkg: " Joey Vagedes
2023-06-26 21:34 ` [PATCH v1 23/24] MdeModulePkg: " Joey Vagedes
2023-06-26 21:34 ` [PATCH v1 24/24] IntelFsp2WrapperPkg: " Joey Vagedes
2023-08-07 22:57   ` [edk2-devel] " Nate DeSimone
2023-06-27  0:59 ` 回复: [PATCH v1 00/24] Update Edk2-pytools to latest versions gaoliming
2023-06-27 16:58   ` Joey Vagedes
2023-06-29 18:01   ` [edk2-devel] 回复: " Sean
2023-06-30  1:50     ` 回复: " gaoliming
2023-07-06 15:22 ` Joey Vagedes
2023-08-01 16:16   ` [edk2-devel] " Joey Vagedes via groups.io
2023-08-02  3:14     ` [edk2-devel] 回复: " gaoliming via groups.io
2023-08-23 17:14     ` [edk2-devel] " Joey Vagedes via groups.io
2023-10-02 22:20       ` Joey Vagedes via groups.io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMj1kXF2+uzY_kFnv9FcqyhM3HA44ya3AtOB3dtFNXbVK484PA@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox