From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 262267803CE for ; Tue, 12 Sep 2023 14:57:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=gmjJQJqAu2m7EGFTU8yPjCyx6M/kjhTBREPLbwD4ZZw=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694530623; v=1; b=H0y6TuUr69zsJ7SHKrogFiVDPIn45LUAjQkASKOepClOUdi5EvIUDeqqyywtQAreneE/uvVr alUESrIoUZAo77gO3BDzPqTFINaRZO/8IhnA5wulRFkLD1OQB1WmgqWq+IGYXxY0gEeGbReTj0T zucAzXEKhN6rbxvsBEIPsyEE= X-Received: by 127.0.0.2 with SMTP id MBbnYY7687511xPUtdcXXdZW; Tue, 12 Sep 2023 07:57:03 -0700 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web11.27418.1694530622451668850 for ; Tue, 12 Sep 2023 07:57:03 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id B367BCE1CFE for ; Tue, 12 Sep 2023 14:56:59 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02B94C433CA for ; Tue, 12 Sep 2023 14:56:58 +0000 (UTC) X-Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2be5e2a3c86so81542211fa.0 for ; Tue, 12 Sep 2023 07:56:57 -0700 (PDT) X-Gm-Message-State: JUTEYbBH1aZOVYCZdE2yNHnZx7686176AA= X-Google-Smtp-Source: AGHT+IHzEu2Up5Sdlu9Q5C2DVD8CaC3ToatyGuIE4hKR3wtb4KaSVpwk/G8oiMJ+XsMQwmHr9HANQhKvUvECrR3uKbs= X-Received: by 2002:a2e:aa22:0:b0:2bc:d993:5a58 with SMTP id bf34-20020a2eaa22000000b002bcd9935a58mr1107429ljb.17.1694530616219; Tue, 12 Sep 2023 07:56:56 -0700 (PDT) MIME-Version: 1.0 References: <20230912141714.74953-1-lersek@redhat.com> In-Reply-To: <20230912141714.74953-1-lersek@redhat.com> From: "Ard Biesheuvel" Date: Tue, 12 Sep 2023 16:56:44 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 1/2] OvmfPkg/PlatformBootManagerLib: refer to virtio console subsys symbolically To: devel@edk2.groups.io, lersek@redhat.com Cc: Anthony Perard , Ard Biesheuvel , Gerd Hoffmann , Jiewen Yao , Jordan Justen , Julien Grall , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Stefan Berger Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=H0y6TuUr; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, 12 Sept 2023 at 16:18, Laszlo Ersek wrote: > > "OvmfPkg/Include/IndustryStandard/Virtio095.h" defines the macro > VIRTIO_SUBSYSTEM_CONSOLE with value 3; other locations in the tree alread= y > use it (such as ArmVirtPkg/PlatformBootManagerLib, > OvmfPkg/VirtioSerialDxe). We should use it in > OvmfPkg/PlatformBootManagerLib too, rather than the naked constant 3. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Gerd Hoffmann > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Julien Grall > Cc: Marc-Andr=C3=A9 Lureau > Cc: Stefan Berger > Beautifies: 163083fd80d5 > Signed-off-by: Laszlo Ersek Acked-by: Ard Biesheuvel > --- > OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/OvmfP= kg/Library/PlatformBootManagerLib/BdsPlatform.c > index 88c39df4aea9..d9f61757cf1b 100644 > --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > @@ -1250,7 +1250,7 @@ DetectAndPreparePlatformVirtioDevicePath ( > DEBUG ((DEBUG_INFO, "%a:%d: id %d\n", __func__, __LINE__, VirtIo->SubS= ystemDeviceId)); > > switch (VirtIo->SubSystemDeviceId) { > - case 3: > + case VIRTIO_SUBSYSTEM_CONSOLE: > PrepareVirtioSerialDevicePath (Handle); > break; > default: > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108538): https://edk2.groups.io/g/devel/message/108538 Mute This Topic: https://groups.io/mt/101315751/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-