Re: [edk2-devel] [PATCH V4 2/2] ArmPkg: Remove manual exclusion of debug vars when MDEPKG_NDEBUG is not defined

["Ard Biesheuvel" <ardb@kernel.org>]

On Thu, 14 Dec 2023 at 08:40, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Thu, 14 Dec 2023 at 08:28, Mike Beaton <mjsbeaton@gmail.com> wrote:
> >
> > From: Mike Beaton <mjsbeaton@gmail.com>
> >
> > This is no longer required since the revised DEBUG macro automatically
> > compiles away unused var accesses when MDEPKG_NDEBUG is defined;
> > keeping these lines is incompatible with the updated DEBUG macro, as
> > there has to be a variable, access to which to discard.
> >
> > Signed-off-by: Mike Beaton <mjsbeaton@gmail.com>
>
> I take it this will trigger a build warning if it is not merged at the
> same time as the other change? How about GCC?
>

Looking at this more closely, we should probably just drop
DeCygwinPathIfNeeded() - I don't think it is still needed.

For the exception handler case, we can just drop the #Ifdefs around
the definition of BaseName () entirely given that it will now always
be referenced. But that does depend a lot on how other toolchains deal
with this (VS201x primarily)


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112509): https://edk2.groups.io/g/devel/message/112509
Mute This Topic: https://groups.io/mt/103166254/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-