From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 76742740039 for ; Thu, 14 Dec 2023 09:00:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=TIh8wU01NZALI2DAJ+1ff32/3uN63flABODuqTT/QHQ=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1702544399; v=1; b=t28bebeyOPD3NTkxnPEhH8OVWl4vGW3SaSl1rsDjAVOQexmphGLpQW1V9cPwG6G0TxPkZJC6 vayGaNf/NUX6QDPmy4TLyyRqHgbo9W1fezEw1pC77vY8QrL0h7pvo+ozGd+DtWss3FnLpSZnWDX qByrguSExy7M8J0A0qnBc2SE= X-Received: by 127.0.0.2 with SMTP id nF7vYY7687511xqBCcldruO0; Thu, 14 Dec 2023 00:59:59 -0800 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web11.17853.1702544398151370594 for ; Thu, 14 Dec 2023 00:59:58 -0800 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 38770CE234B for ; Thu, 14 Dec 2023 08:59:55 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72087C433C9 for ; Thu, 14 Dec 2023 08:59:54 +0000 (UTC) X-Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2c9f7fe6623so98905901fa.3 for ; Thu, 14 Dec 2023 00:59:54 -0800 (PST) X-Gm-Message-State: 4pnc5oF41K4s25i3JDIPCgQEx7686176AA= X-Google-Smtp-Source: AGHT+IEDFy4LocNTKQ7ob6T6xPRADpLv5Bk3G6RlsMQTFV+JCFNTJ8eNJsY5WTFVA1zUanDiGGir/SkZFZOSWwDcAvU= X-Received: by 2002:a2e:5341:0:b0:2cc:422f:7a11 with SMTP id t1-20020a2e5341000000b002cc422f7a11mr187613ljd.52.1702544392665; Thu, 14 Dec 2023 00:59:52 -0800 (PST) MIME-Version: 1.0 References: <20231214072743.6432-1-mjsbeaton@gmail.com> <20231214072743.6432-2-mjsbeaton@gmail.com> In-Reply-To: From: "Ard Biesheuvel" Date: Thu, 14 Dec 2023 09:59:41 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH V4 2/2] ArmPkg: Remove manual exclusion of debug vars when MDEPKG_NDEBUG is not defined To: devel@edk2.groups.io, mjsbeaton@gmail.com Cc: ardb@google.com, lersek@redhat.com, mcb30@ipxe.org, mikhailkrichanov@gmail.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=t28bebey; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, 14 Dec 2023 at 08:40, Ard Biesheuvel wrote: > > On Thu, 14 Dec 2023 at 08:28, Mike Beaton wrote: > > > > From: Mike Beaton > > > > This is no longer required since the revised DEBUG macro automatically > > compiles away unused var accesses when MDEPKG_NDEBUG is defined; > > keeping these lines is incompatible with the updated DEBUG macro, as > > there has to be a variable, access to which to discard. > > > > Signed-off-by: Mike Beaton > > I take it this will trigger a build warning if it is not merged at the > same time as the other change? How about GCC? > Looking at this more closely, we should probably just drop DeCygwinPathIfNeeded() - I don't think it is still needed. For the exception handler case, we can just drop the #Ifdefs around the definition of BaseName () entirely given that it will now always be referenced. But that does depend a lot on how other toolchains deal with this (VS201x primarily) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112509): https://edk2.groups.io/g/devel/message/112509 Mute This Topic: https://groups.io/mt/103166254/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-