* [edk2-platforms][PATCH v1 1/1] Silicon/Qemu: Provide _STA ACPI method
@ 2022-06-28 16:26 Dimitrije Pavlov
2022-06-28 17:25 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Dimitrije Pavlov @ 2022-06-28 16:26 UTC (permalink / raw)
To: devel
Cc: Ard Biesheuvel, Leif Lindholm, Graeme Gregory, Radoslaw Biernacki,
Jeff Booher-Kaeding, Samer El-Haj-Mahmoud, Sunny Wang,
Jeremy Linton
SBBR requires platforms to provide the _STA ACPI method for each
defined device. This patch implements a stub method that always
indicates devices are present and functional.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Graeme Gregory <graeme@nuviainc.com>
Cc: Radoslaw Biernacki <rad@semihalf.com>
Cc: Jeff Booher-Kaeding <Jeff.Booher-Kaeding@arm.com>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Cc: Sunny Wang <Sunny.Wang@arm.com>
Cc: Jeremy Linton <Jeremy.Linton@arm.com>
Signed-off-by: Dimitrije Pavlov <Dimitrije.Pavlov@arm.com>
---
Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 38 +++++++++++++++++++-
1 file changed, 37 insertions(+), 1 deletion(-)
diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
index 1bf9fbb99e75..3357916571fe 100644
--- a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
+++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
@@ -16,6 +16,9 @@
Name (_PRS, ResourceTemplate() { \
Interrupt (ResourceProducer, Level, ActiveHigh, Exclusive) { Irq } \
}) \
+ Method (_STA) { \
+ Return (0xF) \
+ } \
Method (_CRS, 0) { Return (_PRS) } \
Method (_SRS, 1) { } \
Method (_DIS) { } \
@@ -40,6 +43,9 @@ DefinitionBlock ("DsdtTable.aml", "DSDT",
0x00001000)
Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 33 }
})
+ Method (_STA) {
+ Return (0xF)
+ }
}
// AHCI Host Controller
@@ -57,13 +63,18 @@ DefinitionBlock ("DsdtTable.aml", "DSDT",
FixedPcdGet32 (PcdPlatformAhciSize))
Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 42 }
})
+ Method (_STA) {
+ Return (0xF)
+ }
}
// USB EHCI Host Controller
Device (USB0) {
Name (_HID, "LNRO0D20")
Name (_CID, "PNP0D20")
-
+ Method (_STA) {
+ Return (0xF)
+ }
Method (_CRS, 0x0, Serialized) {
Name (RBUF, ResourceTemplate() {
Memory32Fixed (ReadWrite,
@@ -77,6 +88,9 @@ DefinitionBlock ("DsdtTable.aml", "DSDT",
// Root Hub
Device (RHUB) {
Name (_ADR, 0x00000000) // Address of Root Hub should be 0 as per ACPI 5.0 spec
+ Method (_STA) {
+ Return (0xF)
+ }
// Ports connected to Root Hub
Device (HUB1) {
@@ -87,6 +101,9 @@ DefinitionBlock ("DsdtTable.aml", "DSDT",
0x00000000, // Reserved 0 must be zero
0x00000000 // Reserved 1 must be zero
})
+ Method (_STA) {
+ Return (0xF)
+ }
Device (PRT1) {
Name (_ADR, 0x00000001)
@@ -102,6 +119,9 @@ DefinitionBlock ("DsdtTable.aml", "DSDT",
0x31, 0x1C, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
}
})
+ Method (_STA) {
+ Return (0xF)
+ }
} // USB0_RHUB_HUB1_PRT1
Device (PRT2) {
Name (_ADR, 0x00000002)
@@ -117,6 +137,9 @@ DefinitionBlock ("DsdtTable.aml", "DSDT",
0x31, 0x1C, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
}
})
+ Method (_STA) {
+ Return (0xF)
+ }
} // USB0_RHUB_HUB1_PRT2
Device (PRT3) {
@@ -133,6 +156,9 @@ DefinitionBlock ("DsdtTable.aml", "DSDT",
0x31, 0x1C, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
}
})
+ Method (_STA) {
+ Return (0xF)
+ }
} // USB0_RHUB_HUB1_PRT3
Device (PRT4) {
@@ -149,6 +175,9 @@ DefinitionBlock ("DsdtTable.aml", "DSDT",
0x31, 0x1C, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
}
})
+ Method (_STA) {
+ Return (0xF)
+ }
} // USB0_RHUB_HUB1_PRT4
} // USB0_RHUB_HUB1
} // USB0_RHUB
@@ -164,6 +193,10 @@ DefinitionBlock ("DsdtTable.aml", "DSDT",
Name (_UID, "PCI0")
Name (_CCA, One) // Initially mark the PCI coherent (for JunoR1)
+ Method (_STA) {
+ Return (0xF)
+ }
+
Method (_CBA, 0, NotSerialized) {
return (FixedPcdGet32 (PcdPciExpressBaseAddress))
}
@@ -402,6 +435,9 @@ DefinitionBlock ("DsdtTable.aml", "DSDT",
FixedPcdGet64 (PcdPciExpressBarSize), // Length
,, , AddressRangeMemory, TypeStatic)
})
+ Method (_STA) {
+ Return (0xF)
+ }
}
// OS Control Handoff
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [edk2-platforms][PATCH v1 1/1] Silicon/Qemu: Provide _STA ACPI method
2022-06-28 16:26 [edk2-platforms][PATCH v1 1/1] Silicon/Qemu: Provide _STA ACPI method Dimitrije Pavlov
@ 2022-06-28 17:25 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2022-06-28 17:25 UTC (permalink / raw)
To: Dimitrije Pavlov
Cc: edk2-devel-groups-io, Ard Biesheuvel, Leif Lindholm,
Graeme Gregory, Radoslaw Biernacki, Jeff Booher-Kaeding,
Samer El-Haj-Mahmoud, Sunny Wang, Jeremy Linton
On Tue, 28 Jun 2022 at 18:26, Dimitrije Pavlov <Dimitrije.Pavlov@arm.com> wrote:
>
> SBBR requires platforms to provide the _STA ACPI method for each
> defined device. This patch implements a stub method that always
> indicates devices are present and functional.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Graeme Gregory <graeme@nuviainc.com>
> Cc: Radoslaw Biernacki <rad@semihalf.com>
> Cc: Jeff Booher-Kaeding <Jeff.Booher-Kaeding@arm.com>
> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> Cc: Sunny Wang <Sunny.Wang@arm.com>
> Cc: Jeremy Linton <Jeremy.Linton@arm.com>
>
> Signed-off-by: Dimitrije Pavlov <Dimitrije.Pavlov@arm.com>
For the record, I will mention again that I think it is a stupid idea
to *require* that every object has a _STA method that behaves exactly
the same as having no _STA at all. Oh well ...
Pushed as f653a22385f5..8e067b431294
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-28 17:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-28 16:26 [edk2-platforms][PATCH v1 1/1] Silicon/Qemu: Provide _STA ACPI method Dimitrije Pavlov
2022-06-28 17:25 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox