From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by mx.groups.io with SMTP id smtpd.web10.6316.1632313244716464106
 for <devel@edk2.groups.io>;
 Wed, 22 Sep 2021 05:20:44 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gkcy+Lss;
 spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org)
Received: by mail.kernel.org (Postfix) with ESMTPSA id B0335611CA
	for <devel@edk2.groups.io>; Wed, 22 Sep 2021 12:20:43 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1632313243;
	bh=0cr56NdHYNBt6ruT3hTFzvsz5wcyzIWxLr1iKQT0jsQ=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=gkcy+LsszIMQ419Ryf2nrH12DDh0CQXU3HZ42MZ7G3+vATHZtP3tEjXR8GEsjICzU
	 23OSLe3BsYqKBCZaK730/fObttPXrJnfLLSFx4LglEmQdoa/4ukhkZasCIrzvdZDC9
	 xFMxqDzghNER3qWaoQEvVCCu+/839Y43mWJivXaN62skrYnbnQqGnQck0azlVDHmox
	 0mw4vzaUaXpEAAqPwops/tDtssGmE6N9HyBanveA29+kfAL/nxkvaBJ14AGyWrxE7Z
	 imv60fOJ74IBu+8zW3IEKifE7rGgh3JG5i/uQYUGvAoZWlfoQsU8E9rd2Bo6zOZ07+
	 DGV6Ac8LO69WQ==
Received: by mail-oo1-f52.google.com with SMTP id z11-20020a4ad1ab000000b0029f085f5f64so829851oor.5
        for <devel@edk2.groups.io>; Wed, 22 Sep 2021 05:20:43 -0700 (PDT)
X-Gm-Message-State: AOAM531FM3nMY72+2aRwATNNW3cgrQnDYQF+3i9SFpmWASLd2zm6QkXW
	FgWe2cZkPpj7VWhJy0IVmbN5dvLchOMqbVuj8ZA=
X-Google-Smtp-Source: ABdhPJwod8wnbl2aKzHkNNtoyXqtRzSskImHWCE6+ZuvHNFby5iqxxlb2tDhmfOU/ievo28dkThv2AD4+3CEBBfeXiI=
X-Received: by 2002:a4a:11c6:: with SMTP id 189mr28704512ooc.32.1632313243081;
 Wed, 22 Sep 2021 05:20:43 -0700 (PDT)
MIME-Version: 1.0
References: <20210921110056.659697-1-mw@semihalf.com> <CAMj1kXGhbtGC0T_MuOqcqTUw2YJ2LBfZq=h=FuZCc+sDTHCNCw@mail.gmail.com>
 <20210922121451.f7iyi76uca77wimp@leviathan>
In-Reply-To: <20210922121451.f7iyi76uca77wimp@leviathan>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Wed, 22 Sep 2021 14:20:31 +0200
X-Gmail-Original-Message-ID: <CAMj1kXF6VO31SzzX5ov1ncuTA7ciU7jNcFN8ggW6Ccc1ZS5YjQ@mail.gmail.com>
Message-ID: <CAMj1kXF6VO31SzzX5ov1ncuTA7ciU7jNcFN8ggW6Ccc1ZS5YjQ@mail.gmail.com>
Subject: Re: [edk2-platforms PATCH 0/4] Marvell readmes
To: Leif Lindholm <leif@nuviainc.com>
Cc: Marcin Wojtas <mw@semihalf.com>, edk2-devel-groups-io <devel@edk2.groups.io>, 
	Ard Biesheuvel <ardb+tianocore@kernel.org>, Grzegorz Jaszczyk <jaz@semihalf.com>, 
	Grzegorz Bernacki <gjb@semihalf.com>, Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>, 
	alon.rotman@solid-run.com
Content-Type: text/plain; charset="UTF-8"

On Wed, 22 Sept 2021 at 14:14, Leif Lindholm <leif@nuviainc.com> wrote:
>
> On Wed, Sep 22, 2021 at 13:24:07 +0200, Ard Biesheuvel wrote:
> > On Tue, 21 Sept 2021 at 13:02, Marcin Wojtas <mw@semihalf.com> wrote:
> > >
> > > Hi,
> > >
> > > This short patchset adds README files for the platforms
> > > based on Marvell SoC's, which have already been
> > > SystemReady ES certified. It also bumps the firmware
> > > revision after the PCI / IcuLib rework and addition of
> > > the CN913x CEx7 Evaluation Board support.
> > >
> > > The patches are available on a public branch:
> > > https://github.com/semihalf-wojtas-marcin/edk2-platforms/commits/marvell-howtos-upstream-r20210921
> > >
> >
> > Thanks
> >
> > Pushed as 64394fd2b48f..d1d4dd2c39e7
>
> Ugh, wish I'd taken the time to respond yesterday.
>
> This is more proliferation of "include all very specific build
> steps for a very specific target and build environment" documentation.
>
> I don't see this as an improvement.
>
> Platform docs should document what one needs to know specific to the
> platform. If a vendor wishes to provide full recipes, they should host
> that on a wiki somewhere.
>

Fair point.

Marcin, when you find the time, could you please do a pass over these
files with Leif's critique in mind?