Re: [edk2-devel] [PATCH 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

["Ard Biesheuvel" <ardb@kernel.org>]

On Fri, 16 Jul 2021 at 01:20, Jeff Brasen <jbrasen@nvidia.com> wrote:
>
> The GUID is used by the linux kernel but not sure if part of any formal spec
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/include/linux/efi.h?h=v5.14-rc1&id=ec93fc371f014a6fb483e3556061ecad4b40735c
>
> If we feel MdeModulePkg is a better place I am fine with that as well and can release a v2 version.
>

For this patch, whichever package it lands in:

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>


>
> ________________________________
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Thursday, July 15, 2021 4:56 PM
> To: devel@edk2.groups.io <devel@edk2.groups.io>; Jeff Brasen <jbrasen@nvidia.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>; Justen, Jordan L <jordan.l.justen@intel.com>; gaoliming@byosoft.com.cn <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>
> Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID
>
> External email: Use caution opening links or attachments
>
>
> Is this GUID defined in an industry standard or public spec?
>
> If not, then MdeModulePkg may be a better choice if this is a GUID defines for EDK II extensions.
>
> Mike
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jeff Brasen via groups.io
> > Sent: Thursday, July 15, 2021 11:08 AM
> > To: devel@edk2.groups.io
> > Cc: ardb+tianocore@kernel.org; Kinney, Michael D <michael.d.kinney@intel.com>; Justen, Jordan L
> > <jordan.l.justen@intel.com>; gaoliming@byosoft.com.cn; Liu, Zhiguang <zhiguang.liu@intel.com>; Jeff Brasen
> > <jbrasen@nvidia.com>
> > Subject: [edk2-devel] [PATCH 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID
> >
> > Add LINUX_EFI_INITRD_MEDIA_GUID to our collection of GUID definitions,
> > it can be used in a media device path to specify a Linux style initrd
> > that can be loaded by the OS using the LoadFile2 protocol.
> >
> > Move these defines to MdePkg from OvmfPkg as these are relevant to
> > non-OVMF targets as well.
> >
> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2564
> > Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> > ---
> >  MdePkg/MdePkg.dec                                      | 5 +++++
> >  OvmfPkg/OvmfPkg.dec                                    | 1 -
> >  {OvmfPkg => MdePkg}/Include/Guid/LinuxEfiInitrdMedia.h | 0
> >  3 files changed, 5 insertions(+), 1 deletion(-)
> >  rename {OvmfPkg => MdePkg}/Include/Guid/LinuxEfiInitrdMedia.h (100%)
> >
> > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
> > index c5319fdd71ca..a28a2daaffa8 100644
> > --- a/MdePkg/MdePkg.dec
> > +++ b/MdePkg/MdePkg.dec
> > @@ -818,6 +818,11 @@ [Guids]
> >    #
> >    gTianoCustomDecompressGuid     = { 0xA31280AD, 0x481E, 0x41B6, { 0x95, 0xE8, 0x12, 0x7F, 0x4C, 0x98, 0x47, 0x79 }}
> >
> > +  #
> > +  # GUID used to provide initrd to linux via LoadFile2 protocol
> > +  #
> > +  gLinuxEfiInitrdMediaGuid       = {0x5568e427, 0x68fc, 0x4f3d, {0xac, 0x74, 0xca, 0x55, 0x52, 0x31, 0xcc, 0x68}}
> > +
> >  [Guids.IA32, Guids.X64]
> >    ## Include/Guid/Cper.h
> >    gEfiIa32X64ErrorTypeCacheCheckGuid = { 0xA55701F5, 0xE3EF, 0x43de, { 0xAC, 0x72, 0x24, 0x9B, 0x57, 0x3F, 0xAD, 0x2C }}
> > diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec
> > index 6ae733f6e39f..3153f5ae4540 100644
> > --- a/OvmfPkg/OvmfPkg.dec
> > +++ b/OvmfPkg/OvmfPkg.dec
> > @@ -118,7 +118,6 @@ [Guids]
> >    gMicrosoftVendorGuid                  = {0x77fa9abd, 0x0359, 0x4d32, {0xbd, 0x60, 0x28, 0xf4, 0xe7, 0x8f, 0x78, 0x4b}}
> >    gEfiLegacyBiosGuid                    = {0x2E3044AC, 0x879F, 0x490F, {0x97, 0x60, 0xBB, 0xDF, 0xAF, 0x69, 0x5F, 0x50}}
> >    gEfiLegacyDevOrderVariableGuid        = {0xa56074db, 0x65fe, 0x45f7, {0xbd, 0x21, 0x2d, 0x2b, 0xdd, 0x8e, 0x96, 0x52}}
> > -  gLinuxEfiInitrdMediaGuid              = {0x5568e427, 0x68fc, 0x4f3d, {0xac, 0x74, 0xca, 0x55, 0x52, 0x31, 0xcc, 0x68}}
> >    gQemuKernelLoaderFsMediaGuid          = {0x1428f772, 0xb64a, 0x441e, {0xb8, 0xc3, 0x9e, 0xbd, 0xd7, 0xf8, 0x93, 0xc7}}
> >    gGrubFileGuid                         = {0xb5ae312c, 0xbc8a, 0x43b1, {0x9c, 0x62, 0xeb, 0xb8, 0x26, 0xdd, 0x5d, 0x07}}
> >    gConfidentialComputingSecretGuid      = {0xadf956ad, 0xe98c, 0x484c, {0xae, 0x11, 0xb5, 0x1c, 0x7d, 0x33, 0x64, 0x47}}
> > diff --git a/OvmfPkg/Include/Guid/LinuxEfiInitrdMedia.h b/MdePkg/Include/Guid/LinuxEfiInitrdMedia.h
> > similarity index 100%
> > rename from OvmfPkg/Include/Guid/LinuxEfiInitrdMedia.h
> > rename to MdePkg/Include/Guid/LinuxEfiInitrdMedia.h
> > --
> > 2.25.1
> >
> >
> >
> > 
> >
>