public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg: Correct all INF_VERSION value
@ 2023-01-30  2:09 Tommy Huang
  2023-01-31 11:38 ` [edk2-devel] " Ard Biesheuvel
  0 siblings, 1 reply; 6+ messages in thread
From: Tommy Huang @ 2023-01-30  2:09 UTC (permalink / raw)
  To: devel
  Cc: nathaniel.l.desimone, isaac.w.oram, quic_llindhol,
	michael.d.kinney, ryan_chen, BMC-SW

1. Correct all INF_VERSION value.

Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Ryan Chen <ryan_chen@aspeedtech.com>
Cc: BMC-SW <BMC-SW@aspeedtech.com>

Signed-off-by: Tommy Huang <tommy_huang@aspeedtech.com>
---
 Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf | 4 ++--
 Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
index d6a674c..6bda488 100644
--- a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
+++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
@@ -10,11 +10,11 @@
 ##
 
 [Defines]
-  INF_VERSION                    = 0x00011302
+  INF_VERSION                    = 1.29
   BASE_NAME                      = ASpeedAst2500GopDxe
   FILE_GUID                      = 7F81D838-F91D-4C44-8552-8FB912122FDD
   MODULE_TYPE                    = UEFI_DRIVER
-  VERSION_STRING                 = 1.29
+  VERSION_STRING                 = 1.13.02
 
 [Binaries.AArch64]
   PE32|AArch64/ASpeedAst2500Gop.efi|*
diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
index a652ced..3375407 100644
--- a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
+++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
@@ -9,11 +9,11 @@
 ##
 
 [Defines]
-  INF_VERSION                    = 0x00011302
+  INF_VERSION                    = 1.29
   BASE_NAME                      = ASpeedAst2600GopDxe
   FILE_GUID                      = 36f08597-2a8d-4824-9416-59c810b0d9f3
   MODULE_TYPE                    = UEFI_DRIVER
-  VERSION_STRING                 = 1.29
+  VERSION_STRING                 = 1.13.02
 
 [Binaries.AArch64]
   PE32|AArch64/ASpeedAst2600Gop.efi|*
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [edk2-devel] [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg: Correct all INF_VERSION value
  2023-01-30  2:09 [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg: Correct all INF_VERSION value Tommy Huang
@ 2023-01-31 11:38 ` Ard Biesheuvel
  2023-01-31 11:52   ` Tommy Huang
  0 siblings, 1 reply; 6+ messages in thread
From: Ard Biesheuvel @ 2023-01-31 11:38 UTC (permalink / raw)
  To: devel, tommy_huang
  Cc: nathaniel.l.desimone, isaac.w.oram, quic_llindhol,
	michael.d.kinney, ryan_chen, BMC-SW

On Mon, 30 Jan 2023 at 03:09, Tommy Huang <tommy_huang@aspeedtech.com> wrote:
>
> 1. Correct all INF_VERSION value.
>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Ryan Chen <ryan_chen@aspeedtech.com>
> Cc: BMC-SW <BMC-SW@aspeedtech.com>
>
> Signed-off-by: Tommy Huang <tommy_huang@aspeedtech.com>

This patch does not apply

Please generate your patch against https://github.com/tianocore/edk2-non-osi.git


> ---
>  Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf | 4 ++--
>  Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> index d6a674c..6bda488 100644
> --- a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> +++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> @@ -10,11 +10,11 @@
>  ##
>
>
>
>  [Defines]
>
> -  INF_VERSION                    = 0x00011302
> +  INF_VERSION                    = 1.29
>    BASE_NAME                      = ASpeedAst2500GopDxe
>
>    FILE_GUID                      = 7F81D838-F91D-4C44-8552-8FB912122FDD
>
>    MODULE_TYPE                    = UEFI_DRIVER
>
> -  VERSION_STRING                 = 1.29
> +  VERSION_STRING                 = 1.13.02
>
>
>  [Binaries.AArch64]
>
>    PE32|AArch64/ASpeedAst2500Gop.efi|*
>
> diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
> index a652ced..3375407 100644
> --- a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
> +++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
> @@ -9,11 +9,11 @@
>  ##
>
>  [Defines]
> -  INF_VERSION                    = 0x00011302
> +  INF_VERSION                    = 1.29
>    BASE_NAME                      = ASpeedAst2600GopDxe
>    FILE_GUID                      = 36f08597-2a8d-4824-9416-59c810b0d9f3
>    MODULE_TYPE                    = UEFI_DRIVER
> -  VERSION_STRING                 = 1.29
> +  VERSION_STRING                 = 1.13.02
>
>  [Binaries.AArch64]
>    PE32|AArch64/ASpeedAst2600Gop.efi|*
> --
> 2.25.1
>
>
>
> 
>
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [edk2-devel] [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg: Correct all INF_VERSION value
  2023-01-31 11:38 ` [edk2-devel] " Ard Biesheuvel
@ 2023-01-31 11:52   ` Tommy Huang
  2023-01-31 12:45     ` Ard Biesheuvel
  0 siblings, 1 reply; 6+ messages in thread
From: Tommy Huang @ 2023-01-31 11:52 UTC (permalink / raw)
  To: Ard Biesheuvel, devel@edk2.groups.io
  Cc: nathaniel.l.desimone@intel.com, isaac.w.oram@intel.com,
	quic_llindhol@quicinc.com, michael.d.kinney@intel.com, Ryan Chen,
	BMC-SW

Hi Ard,

	Thanks for your review.

	Because I have saw the last patch has been accepted into https://github.com/tianocore/edk2-non-osi.git
	So, I use another patch to fix the typo.
	Do you mean that I need to send my last patch again with corrected the .inf files?

	BR,

	by Tommy

> -----Original Message-----
> From: Ard Biesheuvel <ardb@kernel.org>
> Sent: Tuesday, January 31, 2023 7:38 PM
> To: devel@edk2.groups.io; Tommy Huang <tommy_huang@aspeedtech.com>
> Cc: nathaniel.l.desimone@intel.com; isaac.w.oram@intel.com;
> quic_llindhol@quicinc.com; michael.d.kinney@intel.com; Ryan Chen
> <ryan_chen@aspeedtech.com>; BMC-SW <BMC-SW@aspeedtech.com>
> Subject: Re: [edk2-devel] [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg:
> Correct all INF_VERSION value
> 
> On Mon, 30 Jan 2023 at 03:09, Tommy Huang
> <tommy_huang@aspeedtech.com> wrote:
> >
> > 1. Correct all INF_VERSION value.
> >
> > Cc: Isaac Oram <isaac.w.oram@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Ryan Chen <ryan_chen@aspeedtech.com>
> > Cc: BMC-SW <BMC-SW@aspeedtech.com>
> >
> > Signed-off-by: Tommy Huang <tommy_huang@aspeedtech.com>
> 
> This patch does not apply
> 
> Please generate your patch against
> https://github.com/tianocore/edk2-non-osi.git
> 
> 
> > ---
> >  Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf | 4 ++--
> > Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf | 4 ++--
> >  2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> > b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> > index d6a674c..6bda488 100644
> > --- a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> > +++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> > @@ -10,11 +10,11 @@
> >  ##
> >
> >
> >
> >  [Defines]
> >
> > -  INF_VERSION                    = 0x00011302
> > +  INF_VERSION                    = 1.29
> >    BASE_NAME                      = ASpeedAst2500GopDxe
> >
> >    FILE_GUID                      =
> 7F81D838-F91D-4C44-8552-8FB912122FDD
> >
> >    MODULE_TYPE                    = UEFI_DRIVER
> >
> > -  VERSION_STRING                 = 1.29
> > +  VERSION_STRING                 = 1.13.02
> >
> >
> >  [Binaries.AArch64]
> >
> >    PE32|AArch64/ASpeedAst2500Gop.efi|*
> >
> > diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
> > b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
> > index a652ced..3375407 100644
> > --- a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
> > +++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
> > @@ -9,11 +9,11 @@
> >  ##
> >
> >  [Defines]
> > -  INF_VERSION                    = 0x00011302
> > +  INF_VERSION                    = 1.29
> >    BASE_NAME                      = ASpeedAst2600GopDxe
> >    FILE_GUID                      =
> 36f08597-2a8d-4824-9416-59c810b0d9f3
> >    MODULE_TYPE                    = UEFI_DRIVER
> > -  VERSION_STRING                 = 1.29
> > +  VERSION_STRING                 = 1.13.02
> >
> >  [Binaries.AArch64]
> >    PE32|AArch64/ASpeedAst2600Gop.efi|*
> > --
> > 2.25.1
> >
> >
> >
> > 
> >
> >

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [edk2-devel] [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg: Correct all INF_VERSION value
  2023-01-31 11:52   ` Tommy Huang
@ 2023-01-31 12:45     ` Ard Biesheuvel
  0 siblings, 0 replies; 6+ messages in thread
From: Ard Biesheuvel @ 2023-01-31 12:45 UTC (permalink / raw)
  To: Tommy Huang
  Cc: devel@edk2.groups.io, nathaniel.l.desimone@intel.com,
	isaac.w.oram@intel.com, quic_llindhol@quicinc.com,
	michael.d.kinney@intel.com, Ryan Chen, BMC-SW

On Tue, 31 Jan 2023 at 12:52, Tommy Huang <tommy_huang@aspeedtech.com> wrote:
>
> Hi Ard,
>
>         Thanks for your review.
>
>         Because I have saw the last patch has been accepted into https://github.com/tianocore/edk2-non-osi.git
>         So, I use another patch to fix the typo.
>         Do you mean that I need to send my last patch again with corrected the .inf files?
>
>         BR,
>
>         by Tommy
>

Please resend the patch with me on cc. It seems the list management
software has corrupted the patch.


> > -----Original Message-----
> > From: Ard Biesheuvel <ardb@kernel.org>
> > Sent: Tuesday, January 31, 2023 7:38 PM
> > To: devel@edk2.groups.io; Tommy Huang <tommy_huang@aspeedtech.com>
> > Cc: nathaniel.l.desimone@intel.com; isaac.w.oram@intel.com;
> > quic_llindhol@quicinc.com; michael.d.kinney@intel.com; Ryan Chen
> > <ryan_chen@aspeedtech.com>; BMC-SW <BMC-SW@aspeedtech.com>
> > Subject: Re: [edk2-devel] [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg:
> > Correct all INF_VERSION value
> >
> > On Mon, 30 Jan 2023 at 03:09, Tommy Huang
> > <tommy_huang@aspeedtech.com> wrote:
> > >
> > > 1. Correct all INF_VERSION value.
> > >
> > > Cc: Isaac Oram <isaac.w.oram@intel.com>
> > > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Ryan Chen <ryan_chen@aspeedtech.com>
> > > Cc: BMC-SW <BMC-SW@aspeedtech.com>
> > >
> > > Signed-off-by: Tommy Huang <tommy_huang@aspeedtech.com>
> >
> > This patch does not apply
> >
> > Please generate your patch against
> > https://github.com/tianocore/edk2-non-osi.git
> >
> >
> > > ---
> > >  Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf | 4 ++--
> > > Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf | 4 ++--
> > >  2 files changed, 4 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> > > b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> > > index d6a674c..6bda488 100644
> > > --- a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> > > +++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> > > @@ -10,11 +10,11 @@
> > >  ##
> > >
> > >
> > >
> > >  [Defines]
> > >
> > > -  INF_VERSION                    = 0x00011302
> > > +  INF_VERSION                    = 1.29
> > >    BASE_NAME                      = ASpeedAst2500GopDxe
> > >
> > >    FILE_GUID                      =
> > 7F81D838-F91D-4C44-8552-8FB912122FDD
> > >
> > >    MODULE_TYPE                    = UEFI_DRIVER
> > >
> > > -  VERSION_STRING                 = 1.29
> > > +  VERSION_STRING                 = 1.13.02
> > >
> > >
> > >  [Binaries.AArch64]
> > >
> > >    PE32|AArch64/ASpeedAst2500Gop.efi|*
> > >
> > > diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
> > > b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
> > > index a652ced..3375407 100644
> > > --- a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
> > > +++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
> > > @@ -9,11 +9,11 @@
> > >  ##
> > >
> > >  [Defines]
> > > -  INF_VERSION                    = 0x00011302
> > > +  INF_VERSION                    = 1.29
> > >    BASE_NAME                      = ASpeedAst2600GopDxe
> > >    FILE_GUID                      =
> > 36f08597-2a8d-4824-9416-59c810b0d9f3
> > >    MODULE_TYPE                    = UEFI_DRIVER
> > > -  VERSION_STRING                 = 1.29
> > > +  VERSION_STRING                 = 1.13.02
> > >
> > >  [Binaries.AArch64]
> > >    PE32|AArch64/ASpeedAst2600Gop.efi|*
> > > --
> > > 2.25.1
> > >
> > >
> > >
> > > 
> > >
> > >

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [edk2-devel] [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg: Correct all INF_VERSION value
  2023-02-01 11:13 Tommy Huang
@ 2023-02-09  1:58 ` Isaac Oram
       [not found] ` <1742056401050A3B.15261@groups.io>
  1 sibling, 0 replies; 6+ messages in thread
From: Isaac Oram @ 2023-02-09  1:58 UTC (permalink / raw)
  To: devel@edk2.groups.io, tommy_huang@aspeedtech.com
  Cc: ardb@kernel.org, Desimone, Nathaniel L, quic_llindhol@quicinc.com,
	Kinney, Michael D, Chen, Ryan, BMC-SW@aspeedtech.com

Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Tommy Huang
Sent: Wednesday, February 1, 2023 3:14 AM
To: devel@edk2.groups.io
Cc: ardb@kernel.org; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; quic_llindhol@quicinc.com; Kinney, Michael D <michael.d.kinney@intel.com>; Chen, Ryan <ryan_chen@aspeedtech.com>; BMC-SW@aspeedtech.com
Subject: [edk2-devel] [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg: Correct all INF_VERSION value

1. Correct all INF_VERSION value.

Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Ryan Chen <ryan_chen@aspeedtech.com>
Cc: BMC-SW <BMC-SW@aspeedtech.com>

Signed-off-by: Tommy Huang <tommy_huang@aspeedtech.com>
---
 Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf | 4 ++--  Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
index d6a674c..6bda488 100644
--- a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
+++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
@@ -10,11 +10,11 @@
 ##

 

 [Defines]

-  INF_VERSION                    = 0x00011302
+  INF_VERSION                    = 1.29
   BASE_NAME                      = ASpeedAst2500GopDxe

   FILE_GUID                      = 7F81D838-F91D-4C44-8552-8FB912122FDD

   MODULE_TYPE                    = UEFI_DRIVER

-  VERSION_STRING                 = 1.29
+  VERSION_STRING                 = 1.13.02
 

 [Binaries.AArch64]

   PE32|AArch64/ASpeedAst2500Gop.efi|*

diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
index a652ced..3375407 100644
--- a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
+++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
@@ -9,11 +9,11 @@
 ##
 
 [Defines]
-  INF_VERSION                    = 0x00011302
+  INF_VERSION                    = 1.29
   BASE_NAME                      = ASpeedAst2600GopDxe
   FILE_GUID                      = 36f08597-2a8d-4824-9416-59c810b0d9f3
   MODULE_TYPE                    = UEFI_DRIVER
-  VERSION_STRING                 = 1.29
+  VERSION_STRING                 = 1.13.02
 
 [Binaries.AArch64]
   PE32|AArch64/ASpeedAst2600Gop.efi|*
--
2.25.1







^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [edk2-devel] [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg: Correct all INF_VERSION value
       [not found] ` <1742056401050A3B.15261@groups.io>
@ 2023-02-09  3:12   ` Isaac Oram
  0 siblings, 0 replies; 6+ messages in thread
From: Isaac Oram @ 2023-02-09  3:12 UTC (permalink / raw)
  To: devel@edk2.groups.io, Oram, Isaac W, tommy_huang@aspeedtech.com
  Cc: ardb@kernel.org, Desimone, Nathaniel L, quic_llindhol@quicinc.com,
	Kinney, Michael D, Chen, Ryan, BMC-SW@aspeedtech.com

Pushed as bc0b6bf..bd07ad3

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Isaac Oram
Sent: Wednesday, February 8, 2023 5:59 PM
To: devel@edk2.groups.io; tommy_huang@aspeedtech.com
Cc: ardb@kernel.org; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; quic_llindhol@quicinc.com; Kinney, Michael D <michael.d.kinney@intel.com>; Chen, Ryan <ryan_chen@aspeedtech.com>; BMC-SW@aspeedtech.com
Subject: Re: [edk2-devel] [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg: Correct all INF_VERSION value

Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Tommy Huang
Sent: Wednesday, February 1, 2023 3:14 AM
To: devel@edk2.groups.io
Cc: ardb@kernel.org; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; quic_llindhol@quicinc.com; Kinney, Michael D <michael.d.kinney@intel.com>; Chen, Ryan <ryan_chen@aspeedtech.com>; BMC-SW@aspeedtech.com
Subject: [edk2-devel] [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg: Correct all INF_VERSION value

1. Correct all INF_VERSION value.

Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Ryan Chen <ryan_chen@aspeedtech.com>
Cc: BMC-SW <BMC-SW@aspeedtech.com>

Signed-off-by: Tommy Huang <tommy_huang@aspeedtech.com>
---
 Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf | 4 ++--  Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
index d6a674c..6bda488 100644
--- a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
+++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
@@ -10,11 +10,11 @@
 ##

 

 [Defines]

-  INF_VERSION                    = 0x00011302
+  INF_VERSION                    = 1.29
   BASE_NAME                      = ASpeedAst2500GopDxe

   FILE_GUID                      = 7F81D838-F91D-4C44-8552-8FB912122FDD

   MODULE_TYPE                    = UEFI_DRIVER

-  VERSION_STRING                 = 1.29
+  VERSION_STRING                 = 1.13.02
 

 [Binaries.AArch64]

   PE32|AArch64/ASpeedAst2500Gop.efi|*

diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
index a652ced..3375407 100644
--- a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
+++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
@@ -9,11 +9,11 @@
 ##
 
 [Defines]
-  INF_VERSION                    = 0x00011302
+  INF_VERSION                    = 1.29
   BASE_NAME                      = ASpeedAst2600GopDxe
   FILE_GUID                      = 36f08597-2a8d-4824-9416-59c810b0d9f3
   MODULE_TYPE                    = UEFI_DRIVER
-  VERSION_STRING                 = 1.29
+  VERSION_STRING                 = 1.13.02
 
 [Binaries.AArch64]
   PE32|AArch64/ASpeedAst2600Gop.efi|*
--
2.25.1












^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-02-09  3:13 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-30  2:09 [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg: Correct all INF_VERSION value Tommy Huang
2023-01-31 11:38 ` [edk2-devel] " Ard Biesheuvel
2023-01-31 11:52   ` Tommy Huang
2023-01-31 12:45     ` Ard Biesheuvel
  -- strict thread matches above, loose matches on Subject: below --
2023-02-01 11:13 Tommy Huang
2023-02-09  1:58 ` [edk2-devel] " Isaac Oram
     [not found] ` <1742056401050A3B.15261@groups.io>
2023-02-09  3:12   ` Isaac Oram

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox