From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by mx.groups.io with SMTP id smtpd.web11.10061.1675165122887386057
 for <devel@edk2.groups.io>;
 Tue, 31 Jan 2023 03:38:43 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=C0HIEjlt;
 spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by ams.source.kernel.org (Postfix) with ESMTPS id 37248B81BC6
	for <devel@edk2.groups.io>; Tue, 31 Jan 2023 11:38:40 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id E218DC4339E
	for <devel@edk2.groups.io>; Tue, 31 Jan 2023 11:38:38 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1675165118;
	bh=mVQFDvz3M/FzmUpshZxcnPEcsiBucjOtjFVh2dRm/HM=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=C0HIEjltMYTtTdku9oZILHxQW+S6zCzsbfg9MqwiqVFBJuCujVeMCHOJgQuBYbZiV
	 rDJ+54CdU9zmVd3ar0JCfbvY+JjJTXIsl3rhk3XXxgWshmsJOPfj69ARvU903bcDj/
	 ZBXakpKQtPZK+fKZfdGX2luPQe5LrWutNvvko5PBs9Wzgfa4ag83Dz+if/fggMWBNW
	 txOlGcSpL1rnv4vemBYSQtRuhFVE2tU+bpcz/iT8HEsjqW6GaGYauXWsPcmY09zEcl
	 cGRzZjZleb8vpiRGLBEOImreBRWjnXMW6GGkRFzEK6P+9R/hwrwptuw2jmE2GsUwTg
	 3cWkPWiMKFfmA==
Received: by mail-lf1-f46.google.com with SMTP id x40so23700550lfu.12
        for <devel@edk2.groups.io>; Tue, 31 Jan 2023 03:38:38 -0800 (PST)
X-Gm-Message-State: AFqh2kratwG3DMhced/TienB4wQuNI/lhcb6nNZcQdZDDuPERsn9AnYC
	ohFKVKWzxj0UYnEiSAD0Ld+7gchcgU0Dd5WCIHE=
X-Google-Smtp-Source: AMrXdXvXdg1YsI7LP3AaSbE8Ny02oaNS3jq649zEuZA6IloywgPewCD6H8HajNo1tgolwUsY7dS4XQdMwDr9t66hYr4=
X-Received: by 2002:a05:6512:2525:b0:4b6:fae9:c9b9 with SMTP id
 be37-20020a056512252500b004b6fae9c9b9mr5151935lfb.207.1675165116948; Tue, 31
 Jan 2023 03:38:36 -0800 (PST)
MIME-Version: 1.0
References: <20230130020925.3395964-1-tommy_huang@aspeedtech.com>
In-Reply-To: <20230130020925.3395964-1-tommy_huang@aspeedtech.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Tue, 31 Jan 2023 12:38:25 +0100
X-Gmail-Original-Message-ID: <CAMj1kXF7+oMUbxeuxCZNE7wB_pyxoEHxrS9FGe387PpMPvp0AA@mail.gmail.com>
Message-ID: <CAMj1kXF7+oMUbxeuxCZNE7wB_pyxoEHxrS9FGe387PpMPvp0AA@mail.gmail.com>
Subject: Re: [edk2-devel] [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg: Correct all INF_VERSION value
To: devel@edk2.groups.io, tommy_huang@aspeedtech.com
Cc: nathaniel.l.desimone@intel.com, isaac.w.oram@intel.com, 
	quic_llindhol@quicinc.com, michael.d.kinney@intel.com, 
	ryan_chen@aspeedtech.com, BMC-SW@aspeedtech.com
Content-Type: text/plain; charset="UTF-8"

On Mon, 30 Jan 2023 at 03:09, Tommy Huang <tommy_huang@aspeedtech.com> wrote:
>
> 1. Correct all INF_VERSION value.
>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Ryan Chen <ryan_chen@aspeedtech.com>
> Cc: BMC-SW <BMC-SW@aspeedtech.com>
>
> Signed-off-by: Tommy Huang <tommy_huang@aspeedtech.com>

This patch does not apply

Please generate your patch against https://github.com/tianocore/edk2-non-osi.git


> ---
>  Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf | 4 ++--
>  Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> index d6a674c..6bda488 100644
> --- a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> +++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> @@ -10,11 +10,11 @@
>  ##
>
>
>
>  [Defines]
>
> -  INF_VERSION                    = 0x00011302
> +  INF_VERSION                    = 1.29
>    BASE_NAME                      = ASpeedAst2500GopDxe
>
>    FILE_GUID                      = 7F81D838-F91D-4C44-8552-8FB912122FDD
>
>    MODULE_TYPE                    = UEFI_DRIVER
>
> -  VERSION_STRING                 = 1.29
> +  VERSION_STRING                 = 1.13.02
>
>
>  [Binaries.AArch64]
>
>    PE32|AArch64/ASpeedAst2500Gop.efi|*
>
> diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
> index a652ced..3375407 100644
> --- a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
> +++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
> @@ -9,11 +9,11 @@
>  ##
>
>  [Defines]
> -  INF_VERSION                    = 0x00011302
> +  INF_VERSION                    = 1.29
>    BASE_NAME                      = ASpeedAst2600GopDxe
>    FILE_GUID                      = 36f08597-2a8d-4824-9416-59c810b0d9f3
>    MODULE_TYPE                    = UEFI_DRIVER
> -  VERSION_STRING                 = 1.29
> +  VERSION_STRING                 = 1.13.02
>
>  [Binaries.AArch64]
>    PE32|AArch64/ASpeedAst2600Gop.efi|*
> --
> 2.25.1
>
>
>
> 
>
>