public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ardb@kernel.org>
To: Taylor Beebe <t@taylorbeebe.com>
Cc: devel@edk2.groups.io, Leif Lindholm <quic_llindhol@quicinc.com>,
	 Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: Re: [PATCH 0/4] Update CpuDxe MMU Logic to Improve Consistency
Date: Mon, 3 Jul 2023 16:17:28 +0200	[thread overview]
Message-ID: <CAMj1kXF78zpKpvHdpAqLzNAX=wxa_cfrAsm9CafQpCJmv_b62w@mail.gmail.com> (raw)
In-Reply-To: <cover.1687989723.git.t@taylorbeebe.com>

On Thu, 29 Jun 2023 at 18:20, Taylor Beebe <t@taylorbeebe.com> wrote:
>
> This patch series:
>
> 1. Updates applies uncrustify to noncompliant files
> 2. Updates GetMemoryRegion() to handle the case where
>    BaseAddress is an unmapped page, and update some other
>    return values to be more consistent.
> 3. Adds some branching paths to what were previously only
>    ASSERT statements to avoid dereferencing NULL and producing
>    non-deterministic behavior when ASSERTs are disabled.
> 4. Adds function headers to the MMU logic documenting the
>    behavior, parameters, and potetial return values.
>
> Taylor Beebe (4):
>   ArmPkg: Apply Uncrustify to Non-Compliant Files
>   ArmPkg: Update GetMemoryRegion() to Handle No mapping
>   ArmPkg: Fix Unsafe ASSERTs in MMU Logic
>   ArmPkg: Add Function Headers to MMU Logic
>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>

Thanks a lot for cleaning this up.

For the series,

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

I've submitted these to be merged,

      parent reply	other threads:[~2023-07-03 14:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-29 16:17 [PATCH 0/4] Update CpuDxe MMU Logic to Improve Consistency Taylor Beebe
2023-06-29 16:17 ` [PATCH 1/4] ArmPkg: Apply Uncrustify to Non-Compliant Files Taylor Beebe
2023-06-29 16:17 ` [PATCH 2/4] ArmPkg: Update GetMemoryRegion() to Handle No mapping Taylor Beebe
2023-06-29 16:17 ` [PATCH 3/4] ArmPkg: Fix Unsafe ASSERTs in MMU Logic Taylor Beebe
2023-06-29 16:17 ` [PATCH 4/4] ArmPkg: Add Function Headers to " Taylor Beebe
2023-07-03 14:17 ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMj1kXF78zpKpvHdpAqLzNAX=wxa_cfrAsm9CafQpCJmv_b62w@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox