From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.33710.1688393863383328420 for ; Mon, 03 Jul 2023 07:17:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=szRjAGpq; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CF98960F54 for ; Mon, 3 Jul 2023 14:17:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46383C433C9 for ; Mon, 3 Jul 2023 14:17:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688393862; bh=+tvuk/yQQszmSLsehzPcYI+e+MHT3WK2H+XeD18o9fI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=szRjAGpqmp71+dmytHg6G8S5On2KfWSTfkfgOXIGaEcEHQ6KabemBzaWt/Rjfmmnq DO4ndTrknLWwmg1OVur+GAmqBAMaKxq/JSNkPXR0mb0AyXRbV2ya6mzchYphI/UIGR w9SNzex9zbGbjM6DRYmcjfKbNKWJYHpAyyd4VjmT9LZsdqOut4eI8TTC0KAQlfg6t9 Udaduqabm/vl/j75UIEV/CuPTekW/yt9TlDInoDpgP8i6FENnzkbjz09aBnukDQzeM xUdS8UsggWCnXBd3ZzR8I94t7SqgHzEZrs4I7gBrt88C8Be8zIyVHvTF/jSNTbHXNm sGASyWRZo4twQ== Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-4fba03becc6so4974546e87.0 for ; Mon, 03 Jul 2023 07:17:42 -0700 (PDT) X-Gm-Message-State: AC+VfDySl+GiRgtW97IH/uiLgEEtoHMve6uKdrAXcMVIYhKq2RY5WBJ0 FfzVTbk9+8mZKbId5tB4EnioSQd08cMCtpz1zTI= X-Google-Smtp-Source: APBJJlH0mcgkbl906D6kFM0vju6WoouZAJAR8GSWmVYNoCsRRZzWu+oAEoff0wuOPe1YSYINtIXmsnxc+jZb7oCTVIE= X-Received: by 2002:a05:6512:23a0:b0:4fb:95b0:1423 with SMTP id c32-20020a05651223a000b004fb95b01423mr5613426lfv.4.1688393860272; Mon, 03 Jul 2023 07:17:40 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Ard Biesheuvel" Date: Mon, 3 Jul 2023 16:17:28 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/4] Update CpuDxe MMU Logic to Improve Consistency To: Taylor Beebe Cc: devel@edk2.groups.io, Leif Lindholm , Ard Biesheuvel Content-Type: text/plain; charset="UTF-8" On Thu, 29 Jun 2023 at 18:20, Taylor Beebe wrote: > > This patch series: > > 1. Updates applies uncrustify to noncompliant files > 2. Updates GetMemoryRegion() to handle the case where > BaseAddress is an unmapped page, and update some other > return values to be more consistent. > 3. Adds some branching paths to what were previously only > ASSERT statements to avoid dereferencing NULL and producing > non-deterministic behavior when ASSERTs are disabled. > 4. Adds function headers to the MMU logic documenting the > behavior, parameters, and potetial return values. > > Taylor Beebe (4): > ArmPkg: Apply Uncrustify to Non-Compliant Files > ArmPkg: Update GetMemoryRegion() to Handle No mapping > ArmPkg: Fix Unsafe ASSERTs in MMU Logic > ArmPkg: Add Function Headers to MMU Logic > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Thanks a lot for cleaning this up. For the series, Reviewed-by: Ard Biesheuvel I've submitted these to be merged,