From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Marvin Häuser" <mhaeuser@posteo.de>
Cc: devel@edk2.groups.io, Michael Kinney <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Jiewen Yao <jiewen.yao@intel.com>,
Michael Kubacki <Michael.Kubacki@microsoft.com>,
Sean Brogan <sean.brogan@microsoft.com>,
Rebecca Cran <quic_rcran@quicinc.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Sami Mujawar <sami.mujawar@arm.com>,
Taylor Beebe <t@taylorbeebe.com>,
Bob Feng <bob.c.feng@intel.com>,
Oliver Smith-Denny <osde@linux.microsoft.com>
Subject: Re: [PATCH v3 0/4] Enable BTI support in memory attributes table
Date: Tue, 4 Apr 2023 18:53:43 +0200 [thread overview]
Message-ID: <CAMj1kXF9=mN1cLUL8Pc0mewLXk5hk4VvudygmzWO7grwd-2W3A@mail.gmail.com> (raw)
In-Reply-To: <9C4C1527-1DA6-4DA7-AE98-F2BCA59E2089@posteo.de>
On Tue, 4 Apr 2023 at 18:42, Marvin Häuser <mhaeuser@posteo.de> wrote:
>
>
> > On 4. Apr 2023, at 18:29, Ard Biesheuvel <ardb@kernel.org> wrote:
> > On Tue, 4 Apr 2023 at 18:19, Marvin Häuser <mhaeuser@posteo.de> wrote:
> >>
> >> FWIW, Reviewed-by: Marvin Häuser <mhaeuser@posteo.de>
> >>
> >> An off-topic remark, but I find it ominous that when adding a hack like the DllCharacteristicsEx debug entry, the opportunity is not used to turn it into something that can be expanded in the future without introducing yet another hack like this (I know 31 more Bits look plenty now, but if an address, offset, or size will be needed… ouch).
> >
> > It *can* be expanded in the future. The debug directory entry includes
> > a size field, and once flags get defined that are not present, they
> > just default to unset.
>
> Ugh, I should have known this… sorry for my terrible remark! :)
>
> Though doesn’t that mean the size field should ideally be checked in 3/4 (not regarding the extensibility point, but well-formedness of the data)?
>
Ideally, yes, we shouldn't read more bytes than the debug entry
describes, and zero out the rest.
next prev parent reply other threads:[~2023-04-04 16:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 15:40 [PATCH v3 0/4] Enable BTI support in memory attributes table Ard Biesheuvel
2023-04-04 15:40 ` [PATCH v3 1/4] BaseTools/GenFw: Parse IBT/BTI support status from ELF note Ard Biesheuvel
2023-04-05 1:57 ` [edk2-devel] " Michael Kubacki
2023-04-04 15:40 ` [PATCH v3 2/4] BaseTools/GenFw: Add DllCharacteristicsEx field to debug data Ard Biesheuvel
2023-04-05 1:58 ` [edk2-devel] " Michael Kubacki
2023-04-04 15:40 ` [PATCH v3 3/4] MdePkg/PeCoffLib: Capture DLL characteristics fields in image context Ard Biesheuvel
2023-04-05 1:58 ` [edk2-devel] " Michael Kubacki
2023-04-04 15:40 ` [PATCH v3 4/4] MdeModulePkg: Enable forward edge CFI in mem attributes table Ard Biesheuvel
2023-04-05 1:59 ` [edk2-devel] " Michael Kubacki
2023-04-04 16:19 ` [PATCH v3 0/4] Enable BTI support in memory " Marvin Häuser
2023-04-04 16:29 ` Ard Biesheuvel
2023-04-04 16:42 ` Marvin Häuser
2023-04-04 16:53 ` Ard Biesheuvel [this message]
2023-04-06 1:33 ` 回复: [edk2-devel] " gaoliming
2023-04-07 12:40 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXF9=mN1cLUL8Pc0mewLXk5hk4VvudygmzWO7grwd-2W3A@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox