From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web08.5646.1650446179993496866 for ; Wed, 20 Apr 2022 02:16:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Gnp+n5G7; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2744D6164D for ; Wed, 20 Apr 2022 09:16:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2E27C385B0 for ; Wed, 20 Apr 2022 09:16:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650446178; bh=A8Li0qFf5pkPmggsy5YJvagE0+M4BkQQ+BoF58KB9LM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Gnp+n5G7q5f8hJztP95StinFle2P5dM0CrcIeXLLmLLx9WVF5Dll00nZnoTBT5Cr1 AagRvm+FZIpOP8JRGY0hQ9IbX7jstVEh1ogN43GhnCzB6OcBzuzVzqQGWxkVvnTW3I Hw2s5CUZNkZ+rwarUYaMKtEL9VO4K6jEyhOT4NfEGRC0OrVW4JFCTOJt0MA1Rk88iJ acIKdU3+IQXEKxbCUFkDsqI0/19/PoZmtQpbrEMyXcQBZ4SiO1cWGfDPTl2RN6p0IH 67WMv+099+2ijMC4s8haT4eQLGtUwzoX5HHbrcphBSLGrnuNiVil0ecRyF4m9gp8sB SBesvVQs0g9IQ== Received: by mail-oi1-f175.google.com with SMTP id s16so1411774oie.0 for ; Wed, 20 Apr 2022 02:16:17 -0700 (PDT) X-Gm-Message-State: AOAM531MbthIhiOcM+mBYQj8At5bQiKxGwyLC9xTrLglXb3xDOV8ykdd WmpE2Z1jgvfFsBWpGHedBVSZ556avP5v8Nx/Yng= X-Google-Smtp-Source: ABdhPJzDk0NxeESlI9HolSObHLIoKR6Z0ukFgTK5ykppN4UFy+25qhvnpo48joz+3YZ/DG3CUo9xAm0imTGxNeqR1cs= X-Received: by 2002:a05:6808:e8d:b0:322:bac0:2943 with SMTP id k13-20020a0568080e8d00b00322bac02943mr1237454oil.126.1650446177088; Wed, 20 Apr 2022 02:16:17 -0700 (PDT) MIME-Version: 1.0 References: <20220419073448.165566-1-osteffen@redhat.com> <20220420073040.d3dpwzt4hwhm3hg5@sirius.home.kraxel.org> In-Reply-To: <20220420073040.d3dpwzt4hwhm3hg5@sirius.home.kraxel.org> From: "Ard Biesheuvel" Date: Wed, 20 Apr 2022 11:16:05 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/4] CI: Use Fedora 35 container for Linux jobs To: Gerd Hoffmann Cc: Oliver Steffen , Andrew Fish , Ard Biesheuvel , "Feng, Bob C" , Bret Barkelew , edk2-devel-groups-io , "Liming Gao (Byosoft address)" , Jiewen Yao , Jordan Justen , Michael Kinney , Leif Lindholm , Ray Ni , Sami Mujawar , Sean Brogan , Yuwei Chen Content-Type: text/plain; charset="UTF-8" On Wed, 20 Apr 2022 at 09:30, Gerd Hoffmann wrote: > > On Tue, Apr 19, 2022 at 11:54:38PM +0200, Ard Biesheuvel wrote: > > On Tue, 19 Apr 2022 at 09:35, Oliver Steffen wrote: > > > > > > PR: https://github.com/tianocore/edk2/pull/2711 > > > > > > Update CI, run all Linux (aka Ubuntu-GCC5) based jobs in a custom > > > Fedora 35 container. > > > > Why? > > > > > The image provides gcc 11 from Fedora for all > > > architectures. The external dependencies for gcc have been removed > > > so stuart does not download them. iasl and nasm are also > > > included in the image, but remain as ext-dep for now (CI jobs on > > > Windows need those). > > ^^^ this for example. > > The idea is to (a) switch linux CI builds from vm images to container > images, and (b) use our own, custom container images. > > This allows to roll the dependencies needed for CI into the container > images, so there is no need to download them in CI jobs. Fixes > temporary CI failures due to network problems and download errors. > > This also allows to remove any distribution-specific commands (apt-get > for example) from CI jobs. This will be handled in the Dockerfiles used > to build our custom container images instead. > > Oliver is also working on ubuntu containers, look here: > > > > The Dockerfiles are here: > > > https://github.com/osteffenrh/edk2-build-images, > > Fedora is a bit faster on updating stuff. For example: ubuntu 22.04 > uses gcc 11 whereas Fedora 36 uses gcc 12 (both distros are in beta > right now). Whenever we want: > > (a) stick to ubuntu, or > (b) switch to fedora, or > (c) use both > > is up for debate. > > > > but they should, of > > > course, then move to a repo in the Tianocore group, or something like > > > that. The images are built automatically via GitHub Actions and then > > > pushed to ghcr.io. > > That is the next question: where should we host the Dockerfiles and > container images? > > For the Dockerfiles that should probably a git repo in the tianocore > group. > > For the container images the obvious choices are github and azure. > Given that microsoft owns github I'd expect both github actions and > azure pipelines are running on the same cloud infrastructure and it > doesn't make much of a difference whenever github or azure container > registry is used to host container images. > Thanks for the explanation. Please put information like this in the commit logs, rather than assuming it will obvious to everyone without providing any background. For these changes, Acked-by: Ard Biesheuvel