public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH v2] ArmVirtPkg: can't find gUefiOvmfPkgTokenSpaceGuid
@ 2023-03-28  9:11 Jianyong Wu
  2023-03-28 10:11 ` Sami Mujawar
  0 siblings, 1 reply; 3+ messages in thread
From: Jianyong Wu @ 2023-03-28  9:11 UTC (permalink / raw)
  To: devel, Sami.Mujawar; +Cc: ardb, sunilvl, jianyong.wu

commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is
missing in CloudHvHasAcpiDtDxe.inf which leads to
gUefiOvmfPkgTokenSpaceGuid found nowhere when build.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
---
 ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
index 7cad40e11f..6ff80b24d0 100644
--- a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
+++ b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
@@ -23,6 +23,7 @@
   EmbeddedPkg/EmbeddedPkg.dec
   MdeModulePkg/MdeModulePkg.dec
   MdePkg/MdePkg.dec
+  OvmfPkg/OvmfPkg.dec
 
 [LibraryClasses]
   BaseLib
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] ArmVirtPkg: can't find gUefiOvmfPkgTokenSpaceGuid
  2023-03-28  9:11 [PATCH v2] ArmVirtPkg: can't find gUefiOvmfPkgTokenSpaceGuid Jianyong Wu
@ 2023-03-28 10:11 ` Sami Mujawar
  2023-03-28 13:04   ` [edk2-devel] " Ard Biesheuvel
  0 siblings, 1 reply; 3+ messages in thread
From: Sami Mujawar @ 2023-03-28 10:11 UTC (permalink / raw)
  To: Jianyong Wu, devel@edk2.groups.io, ardb@kernel.org
  Cc: sunilvl@ventanamicro.com

Hi Ard,

This patch fixes a build break for the CloudHv firmware.
Can you let me know if I can merge this patch, please?

Regards,

Sami Mujawar

On 28/03/2023, 10:11, "Jianyong Wu" <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>> wrote:


commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is
missing in CloudHvHasAcpiDtDxe.inf which leads to
gUefiOvmfPkgTokenSpaceGuid found nowhere when build.


Reviewed-by: Sami Mujawar <sami.mujawar@arm.com <mailto:sami.mujawar@arm.com>>
Signed-off-by: Jianyong Wu <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>>
---
ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf | 1 +
1 file changed, 1 insertion(+)


diff --git a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
index 7cad40e11f..6ff80b24d0 100644
--- a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
+++ b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
@@ -23,6 +23,7 @@
EmbeddedPkg/EmbeddedPkg.dec
MdeModulePkg/MdeModulePkg.dec
MdePkg/MdePkg.dec
+ OvmfPkg/OvmfPkg.dec


[LibraryClasses]
BaseLib
--
2.17.1





IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [edk2-devel] [PATCH v2] ArmVirtPkg: can't find gUefiOvmfPkgTokenSpaceGuid
  2023-03-28 10:11 ` Sami Mujawar
@ 2023-03-28 13:04   ` Ard Biesheuvel
  0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2023-03-28 13:04 UTC (permalink / raw)
  To: devel, sami.mujawar; +Cc: Jianyong Wu, sunilvl@ventanamicro.com

On Tue, 28 Mar 2023 at 12:11, Sami Mujawar <sami.mujawar@arm.com> wrote:
>
> Hi Ard,
>
> This patch fixes a build break for the CloudHv firmware.
> Can you let me know if I can merge this patch, please?
>

Yes, please go ahead

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

>
> On 28/03/2023, 10:11, "Jianyong Wu" <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>> wrote:
>
>
> commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is
> missing in CloudHvHasAcpiDtDxe.inf which leads to
> gUefiOvmfPkgTokenSpaceGuid found nowhere when build.
>
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com <mailto:sami.mujawar@arm.com>>
> Signed-off-by: Jianyong Wu <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>>
> ---
> ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf | 1 +
> 1 file changed, 1 insertion(+)
>
>
> diff --git a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> index 7cad40e11f..6ff80b24d0 100644
> --- a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> +++ b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> @@ -23,6 +23,7 @@
> EmbeddedPkg/EmbeddedPkg.dec
> MdeModulePkg/MdeModulePkg.dec
> MdePkg/MdePkg.dec
> + OvmfPkg/OvmfPkg.dec
>
>
> [LibraryClasses]
> BaseLib
> --
> 2.17.1
>
>
>
>
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
>
>
> 
>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-03-28 13:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-28  9:11 [PATCH v2] ArmVirtPkg: can't find gUefiOvmfPkgTokenSpaceGuid Jianyong Wu
2023-03-28 10:11 ` Sami Mujawar
2023-03-28 13:04   ` [edk2-devel] " Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox