From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 88E36740034 for ; Tue, 3 Oct 2023 18:57:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ZBVk+ayX/gvKbYd2wszjvADAGl7/fCI8r9Xec+O2Pbo=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1696359473; v=1; b=lwc90Yr+FNxqmkTdFGpsZp35EOMd17gTOdD6jRy+S/3sfjXzjF7yuaaySHrssdeQJd2H4MPF 3n6DwXr8bia8vJCh+BhqvimkrJD9F1Cxi7LWBmHF1D2zI2DjxZvryRl7px7pvu3iiP0vFqYgGb8 VKrpt0xJAra1Vkqj8YpcPGcw= X-Received: by 127.0.0.2 with SMTP id fVDPYY7687511xpentaX2acF; Tue, 03 Oct 2023 11:57:53 -0700 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web11.116584.1696359471888083148 for ; Tue, 03 Oct 2023 11:57:52 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id CA310CE19A8 for ; Tue, 3 Oct 2023 18:57:48 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 191CCC433C8 for ; Tue, 3 Oct 2023 18:57:48 +0000 (UTC) X-Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2c15463ddd4so14504381fa.3 for ; Tue, 03 Oct 2023 11:57:47 -0700 (PDT) X-Gm-Message-State: eBtazYcjSgl1PIPcNtQCJJgLx7686176AA= X-Google-Smtp-Source: AGHT+IEXXLy9t/b4aIvA8l9a+2Y2qmvP9J3JRoDS/q6QHz6bNHBxwLQYDrpgPNX/EhDJHV5sdawn1nU06j7wgfBFhnI= X-Received: by 2002:a2e:8e89:0:b0:2bc:ffe5:54a1 with SMTP id z9-20020a2e8e89000000b002bcffe554a1mr123175ljk.32.1696359466218; Tue, 03 Oct 2023 11:57:46 -0700 (PDT) MIME-Version: 1.0 References: <177845D072580598.19347@groups.io> <177BEFB7EF58B50B.8497@groups.io> <17887E55BF3885BC.16687@groups.io> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 3 Oct 2023 18:57:34 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v4 00/14] Add ImagePropertiesRecordLib and Fix MAT Bugs To: Taylor Beebe Cc: devel@edk2.groups.io, Andrew Fish , Ard Biesheuvel , Dandan Bi , Eric Dong , Gerd Hoffmann , Guo Dong , Gua Guo , James Lu , Jian J Wang , Jiewen Yao , Jordan Justen , Leif Lindholm , Liming Gao , Rahul Kumar , Ray Ni , Sami Mujawar , Sean Rhodes Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=lwc90Yr+; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, 3 Oct 2023 at 17:56, Taylor Beebe wrote: > > Have we given up on this patch series and Bug 4492? > I haven't, I promise. I will get to this on Thursday or Friday. > On 9/26/2023 9:02 AM, Taylor Beebe via groups.io wrote: > > Reviews on this patch series would be much appreciated :) > > > > On 8/28/23 9:38 AM, Ard Biesheuvel wrote: > >> I was hoping to get around to this before the end of the week (but I > >> am not a MdeModulePkg maintainer) > >> > >> > >> On Mon, 28 Aug 2023 at 18:27, Taylor Beebe > >> wrote: > >>> Can I please get reviews/feedback on this patch series? > >>> > >>> On 8/16/23 11:14 AM, Taylor Beebe via groups.io wrote: > >>>> Can I please get reviews/feedback on this patch series? > >>>> > >>>> On 8/4/2023 12:46 PM, Taylor Beebe via groups.io wrote: > >>>>> From: Taylor Beebe > >>>>> > >>>>> v4: > >>>>> - Expose additional functions in the Library API > >>>>> - Add NULL checks to library functions and return a > >>>>> status where applicable. > >>>>> > >>>>> v3: > >>>>> - Refactor patch series so the transition of logic from the DXE > >>>>> MAT logic to the new library is more clear. > >>>>> - Update function headers to improve clarity and follow EDK2 > >>>>> standards. > >>>>> - Add Create and Delete functions for Image Properties Records > >>>>> and redirect some of the SMM and DXE MAT code to use these > >>>>> functions. > >>>>> - Update/Add DumpImageRecords() to print the image name and code > >>>>> sections of each runtime image which will be put in the MAT. > >>>>> The DXE and SMM MAT logic will now invoke the DumpImageRecords() > >>>>> on DEBUG builds at the EndOfDxe event to install the MAT. > >>>>> > >>>>> v2: > >>>>> - A one-line change in patch 3 was moved to patch 9 for correctness. > >>>>> > >>>>> Reference: https://github.com/tianocore/edk2/pull/4590 > >>>>> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4492 > >>>>> > >>>>> The UEFI and SMM MAT logic contains duplicate logic for manipulating > >>>>> image > >>>>> properties records which is used to track runtime images. > >>>>> This patch series adds a new library, ImagePropertiesRecordLib, > >>>>> which consolidates this logic and fixes the bugs which currently > >>>>> exist in > >>>>> the MAT logic. > >>>>> > >>>>> The first patch adds the ImagePropertiesRecordLib implementation > >>>>> which > >>>>> is a copy of the UEFI MAT logic with minor modifications to remove > >>>>> the > >>>>> reliance on globabl variables and make the code unit testable. > >>>>> > >>>>> The second patch adds a unit test for the > >>>>> ImagePropertiesRecordLib. The > >>>>> logic tests various potential layouts of the EFI memory map and > >>>>> runtime > >>>>> images. 3/4 of these tests will fail which demonstrates the MAT logic > >>>>> bugs. > >>>>> > >>>>> The third patch fixes the logic in the ImagePropertiesRecordLib so > >>>>> that all of the unit tests pass and the MAT logic can be fixed by > >>>>> using the library. > >>>>> > >>>>> The remaining patches add library instances to DSC files and remove > >>>>> the image properties record logic from the SMM and UEFI MAT logic. > >>>>> > >>>>> Cc: Andrew Fish > >>>>> Cc: Ard Biesheuvel > >>>>> Cc: Dandan Bi > >>>>> Cc: Eric Dong > >>>>> Cc: Gerd Hoffmann > >>>>> Cc: Guo Dong > >>>>> Cc: Gua Guo > >>>>> Cc: James Lu > >>>>> Cc: Jian J Wang > >>>>> Cc: Jiewen Yao > >>>>> Cc: Jordan Justen > >>>>> Cc: Leif Lindholm > >>>>> Cc: Liming Gao > >>>>> Cc: Rahul Kumar > >>>>> Cc: Ray Ni > >>>>> Cc: Sami Mujawar > >>>>> Cc: Sean Rhodes > >>>>> > >>>>> Taylor Beebe (14): > >>>>> MdeModulePkg: Add ImagePropertiesRecordLib > >>>>> ArmVirtPkg: Add ImagePropertiesRecordLib Instance > >>>>> EmulatorPkg: Add ImagePropertiesRecordLib Instance > >>>>> OvmfPkg: Add ImagePropertiesRecordLib Instance > >>>>> UefiPayloadPkg: Add ImagePropertiesRecordLib Instance > >>>>> MdeModulePkg: Update MemoryAttributesTable.c to Reduce Global > >>>>> Variable > >>>>> Use > >>>>> MdeModulePkg: Move Some DXE MAT Logic to ImagePropertiesRecordLib > >>>>> MdeModulePkg: Add ImagePropertiesRecordLib Host-Based Unit Test > >>>>> MdeModulePkg: Fix Bugs in MAT Logic > >>>>> MdeModulePkg: Add NULL checks and Return Status to > >>>>> ImagePropertiesRecordLib > >>>>> UefiCpuPkg: Use Attribute From SMM MemoryAttributesTable if > >>>>> Nonzero > >>>>> MdeModulePkg: Transition SMM MAT Logic to Use > >>>>> ImagePropertiesRecordLib > >>>>> MdeModulePkg: Add Logic to Create/Delete Image Properties Records > >>>>> MdeModulePkg: Update DumpImageRecord() in > >>>>> ImagePropertiesRecordLib > >>>>> > >>>>> MdeModulePkg/Core/Dxe/Misc/MemoryAttributesTable.c | 967 > >>>>> +---------------- > >>>>> MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 24 +- > >>>>> MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c | 958 > >>>>> +--------------- > >>>>> MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.c > >>>>> > >>>>> | 1144 ++++++++++++++++++++ > >>>>> MdeModulePkg/Library/ImagePropertiesRecordLib/UnitTest/ImagePropertiesRecordLibUnitTestHost.c > >>>>> > >>>>> | 938 ++++++++++++++++ > >>>>> UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 19 +- > >>>>> ArmVirtPkg/ArmVirt.dsc.inc | 1 + > >>>>> EmulatorPkg/EmulatorPkg.dsc | 1 + > >>>>> MdeModulePkg/Core/Dxe/DxeMain.h | 20 - > >>>>> MdeModulePkg/Core/Dxe/DxeMain.inf | 1 + > >>>>> MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf | 1 + > >>>>> MdeModulePkg/Include/Library/ImagePropertiesRecordLib.h | 234 ++++ > >>>>> MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf > >>>>> > >>>>> | 31 + > >>>>> MdeModulePkg/Library/ImagePropertiesRecordLib/UnitTest/ImagePropertiesRecordLibUnitTestHost.inf > >>>>> > >>>>> | 35 + > >>>>> MdeModulePkg/MdeModulePkg.dec | 5 + > >>>>> MdeModulePkg/MdeModulePkg.dsc | 2 + > >>>>> MdeModulePkg/Test/MdeModulePkgHostTest.dsc | 6 + > >>>>> OvmfPkg/AmdSev/AmdSevX64.dsc | 1 + > >>>>> OvmfPkg/Bhyve/BhyveX64.dsc | 1 + > >>>>> OvmfPkg/CloudHv/CloudHvX64.dsc | 1 + > >>>>> OvmfPkg/IntelTdx/IntelTdxX64.dsc | 1 + > >>>>> OvmfPkg/Microvm/MicrovmX64.dsc | 1 + > >>>>> OvmfPkg/OvmfPkgIa32.dsc | 1 + > >>>>> OvmfPkg/OvmfPkgIa32X64.dsc | 1 + > >>>>> OvmfPkg/OvmfPkgX64.dsc | 1 + > >>>>> OvmfPkg/OvmfXen.dsc | 1 + > >>>>> OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc | 1 + > >>>>> UefiPayloadPkg/UefiPayloadPkg.dsc | 1 + > >>>>> 28 files changed, 2524 insertions(+), 1874 deletions(-) > >>>>> create mode 100644 > >>>>> MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.c > >>>>> > >>>>> create mode 100644 > >>>>> MdeModulePkg/Library/ImagePropertiesRecordLib/UnitTest/ImagePropertiesRecordLibUnitTestHost.c > >>>>> > >>>>> create mode 100644 > >>>>> MdeModulePkg/Include/Library/ImagePropertiesRecordLib.h > >>>>> create mode 100644 > >>>>> MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf > >>>>> > >>>>> create mode 100644 > >>>>> MdeModulePkg/Library/ImagePropertiesRecordLib/UnitTest/ImagePropertiesRecordLibUnitTestHost.inf > >>>>> > >>>>> > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109301): https://edk2.groups.io/g/devel/message/109301 Mute This Topic: https://groups.io/mt/100553430/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-