public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel via groups.io" <ardb=kernel.org@groups.io>
To: Rebecca Cran <rebecca@bsdio.com>
Cc: devel@edk2.groups.io, ardb+tianocore@kernel.org,
	quic_llindhol@quicinc.com,
	 Michael D Kinney <michael.d.kinney@intel.com>,
	 "Warkentin, Andrei" <andrei.warkentin@intel.com>
Subject: Re: [edk2-devel] [PATCH edk2-non-osi v2 1/1] Emulator/X86EmulatorDxe: Replace with MultiArchUefiPkg build
Date: Fri, 13 Sep 2024 16:47:36 +0200	[thread overview]
Message-ID: <CAMj1kXFC8Ek=3+c=v-muxBp9ruYqR36oR0ch4dgr_Kg_FUNsqQ@mail.gmail.com> (raw)
In-Reply-To: <502c457a-221f-48b4-ac86-2febc1773fe9@bsdio.com>

On Mon, 9 Sept 2024 at 18:56, Rebecca Cran <rebecca@bsdio.com> wrote:
>
> On 9/9/24 10:13 AM, Ard Biesheuvel via groups.io wrote:
> > On Mon, 9 Sept 2024 at 18:11, Rebecca Cran <rebecca@bsdio.com> wrote:
> >> Replace the old X86EmulatorDxe with one built from
> >> https://github.com/intel/MultiArchUefiPkg. This is a much more modern,
> >> recent implementation that's more reliable and is actively maintained.
> > What was the conclusion in the end regarding NULL pointer deref handling?
>
> Andrei (cc'd) said:
>
>
> "- All memory but the zero page is visible to the emulator. See
> CpuNullReadCb/CpuNullWriteCb. See also TestNullDeref in
> Application/EmulatorTest. I don't remember if I added the behavior
> because this is what the original did, or because I actively tripped on
> the NULL accesses from some x86 code I was testing..."
>
>
> I don't know if that resolved the concern or not.
>

I think it does.

Acked-by: Ard Biesheuvel <ardb@kernel.org>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120565): https://edk2.groups.io/g/devel/message/120565
Mute This Topic: https://groups.io/mt/108357668/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      reply	other threads:[~2024-09-13 14:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-09 16:10 [edk2-devel] [PATCH edk2-non-osi v2 0/1] Emulator/X86EmulatorDxe: Replace with MultiArchUefiPkg build Rebecca Cran
2024-09-09 16:10 ` [edk2-devel] [PATCH edk2-non-osi v2 1/1] " Rebecca Cran
2024-09-09 16:13   ` Ard Biesheuvel via groups.io
2024-09-09 16:56     ` Rebecca Cran
2024-09-13 14:47       ` Ard Biesheuvel via groups.io [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMj1kXFC8Ek=3+c=v-muxBp9ruYqR36oR0ch4dgr_Kg_FUNsqQ@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox