From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4E1099419B4 for ; Fri, 13 Sep 2024 14:47:52 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=lVszCsKVgAvk6YbrntfBg6jq0P+tJVYLGagla3AwauY=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240830; t=1726238872; v=1; x=1726498070; b=ci2QSjaqEEpCjfoX24BeEDkOSEaLfxZa286xiXRlHUjdTCWu3g7Bn/TzirrVzEAheL6NakVb OJ1k2567cBqJNqaKfLrXbZJjJUKw0Vnej2/RHh29Nkq8hdozVPHjifmL36bw7jUAfoE9I0vI7m+ wOgpiLjaFdc149ipFS4t8GyR3Amc28ncv7R4ZHl5DsC6n+LugwocWKsXjzIHVBGXSQsfIMPzyGb xfRutdvU0fkNaC94zE2cVMrTAazOqnIrzp4rpr3x8LFtno5uYMJXWtEZ3iWVHQQnA5Mg4+JeyST PcAFH7AECJo3wrvS3KitsnfAcn626I24dyFSAo/0uk7NQ== X-Received: by 127.0.0.2 with SMTP id rVj9YY7687511xNH2sZjdyID; Fri, 13 Sep 2024 07:47:50 -0700 X-Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by mx.groups.io with SMTP id smtpd.web10.75205.1726238870186976938 for ; Fri, 13 Sep 2024 07:47:50 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id B124CA44CAE for ; Fri, 13 Sep 2024 14:47:41 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EE95C4AF09 for ; Fri, 13 Sep 2024 14:47:49 +0000 (UTC) X-Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2f74e468aa8so25413201fa.1 for ; Fri, 13 Sep 2024 07:47:48 -0700 (PDT) X-Gm-Message-State: xS2C0VZ8tRv3kHKXgRX6iVEyx7686176AA= X-Google-Smtp-Source: AGHT+IHCs+5+reYjhh9S1M2r1bLFFHZIa2WacQ2W3xsBq79XH7ioUCqgwAX5vb3ePmabhfmDSq/n8ijceYVmDMBZzFs= X-Received: by 2002:a05:651c:623:b0:2f6:5fa7:2640 with SMTP id 38308e7fff4ca-2f787f2fb14mr29681071fa.34.1726238867341; Fri, 13 Sep 2024 07:47:47 -0700 (PDT) MIME-Version: 1.0 References: <20240909161004.128226-1-rebecca@bsdio.com> <20240909161004.128226-2-rebecca@bsdio.com> <502c457a-221f-48b4-ac86-2febc1773fe9@bsdio.com> In-Reply-To: <502c457a-221f-48b4-ac86-2febc1773fe9@bsdio.com> From: "Ard Biesheuvel via groups.io" Date: Fri, 13 Sep 2024 16:47:36 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-non-osi v2 1/1] Emulator/X86EmulatorDxe: Replace with MultiArchUefiPkg build To: Rebecca Cran Cc: devel@edk2.groups.io, ardb+tianocore@kernel.org, quic_llindhol@quicinc.com, Michael D Kinney , "Warkentin, Andrei" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 13 Sep 2024 07:47:50 -0700 Resent-From: ardb@kernel.org Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=ci2QSjaq; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, 9 Sept 2024 at 18:56, Rebecca Cran wrote: > > On 9/9/24 10:13 AM, Ard Biesheuvel via groups.io wrote: > > On Mon, 9 Sept 2024 at 18:11, Rebecca Cran wrote: > >> Replace the old X86EmulatorDxe with one built from > >> https://github.com/intel/MultiArchUefiPkg. This is a much more modern, > >> recent implementation that's more reliable and is actively maintained. > > What was the conclusion in the end regarding NULL pointer deref handling? > > Andrei (cc'd) said: > > > "- All memory but the zero page is visible to the emulator. See > CpuNullReadCb/CpuNullWriteCb. See also TestNullDeref in > Application/EmulatorTest. I don't remember if I added the behavior > because this is what the original did, or because I actively tripped on > the NULL accesses from some x86 code I was testing..." > > > I don't know if that resolved the concern or not. > I think it does. Acked-by: Ard Biesheuvel -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120565): https://edk2.groups.io/g/devel/message/120565 Mute This Topic: https://groups.io/mt/108357668/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-