From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web08.24999.1626679687561507300 for ; Mon, 19 Jul 2021 00:28:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=r17Uy3Up; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 949E061019 for ; Mon, 19 Jul 2021 07:28:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626679686; bh=p2kXjAbjGdFnWVe40HlXdbxPwBDfeJ4tdbOhOnc5Iek=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=r17Uy3Upjy/x+pdYKPn/feVdw6iy+sFFVYlOQ21d51kWTOSBnVsgAS4PlxUti0PIk JUvUNM+VPP63zY0dMX1ouALWdbzMZpwg/fk1ymqkKAQrjMLliFRVzLXP6qG6pQmi/G wn3RPXJ6KtPSZj7oGCyVLOi0GXignQsy9jQf/S7vh2epeLW4AuH/DVhWVEoTP1Q+87 ROcvPet7lya3aJ/shlS8uCoqU8HGDrcO9lkSghROq4HDR63eQ6j8CeHWfUK5qfnFF6 6HEPJEdnZLYnW8Fq24hsFiD+dXvVTxNsWfzLHovAhe8fPprAK1jER1suM6Xj09X8wS g4cO/fhvPL3vA== Received: by mail-oo1-f51.google.com with SMTP id a17-20020a4ad5d10000b0290263c143bcb2so2794064oot.7 for ; Mon, 19 Jul 2021 00:28:06 -0700 (PDT) X-Gm-Message-State: AOAM532Onzyq/Sa5Jskl+h+XJdTCclfHKxhq3OQA+uO+C8YMwb9zMD3Q 4NJuqHUbpvFHqUGFyLO2cLOjoePwBUC813ELIgU= X-Google-Smtp-Source: ABdhPJz6/JTOrAWVl8n0b++/nK76bGbo4d+F8Nxp/8AgJB4kGE5zs1/7QXpH+AZ4CowEly+VhWsoLxK/TNh6c36Yylk= X-Received: by 2002:a4a:e923:: with SMTP id a3mr16387247ooe.45.1626679685906; Mon, 19 Jul 2021 00:28:05 -0700 (PDT) MIME-Version: 1.0 References: <20210613181631.2247221-1-mw@semihalf.com> <20210614215540.u2y4oc2s4cvs6kxw@leviathan> In-Reply-To: From: "Ard Biesheuvel" Date: Mon, 19 Jul 2021 09:27:54 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-platforms PATCH 0/4] ACPI MDIO support for Marvell SoCs To: Jon Nettleton Cc: Marcin Wojtas , Leif Lindholm , Ard Biesheuvel , edk2-devel-groups-io , Grzegorz Jaszczyk , Grzegorz Bernacki , upstream@semihalf.com, Samer El-Haj-Mahmoud Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 16 Jul 2021 at 19:32, Ard Biesheuvel wrote: > > On Mon, 12 Jul 2021 at 13:17, Jon Nettleton wrote: > > > > On Mon, Jul 12, 2021 at 12:52 PM Marcin Wojtas wrote: > > > > > > Hi, > > > > > > wt., 29 cze 2021 o 16:17 Marcin Wojtas napisa=C5=82= (a): > > > > > > > > Hi Leif, > > > > > > > > pon., 14 cze 2021 o 23:55 Leif Lindholm napisa= =C5=82(a): > > > > > > > > > > Hi Marcin, > > > > > > > > > > On Sun, Jun 13, 2021 at 20:16:27 +0200, Marcin Wojtas wrote: > > > > > > Hi, > > > > > > > > > > > > The MDIO ACPI binding has been established and merged to the > > > > > > Linux tree, > > > > > > > > > > Congratulations! :) > > > > > > > > > > Is FreeBSD expected to follow suit? > > > > > > > > There's no driver yet, but once it's finally created I will make su= re > > > > it supports ACPI properly. > > > > > > > > > > > > > > > hence it is now possible to update the ACPI > > > > > > description of the platforms that base on the Marvell SoCs. > > > > > > > > > > > > For convenience, the code is exposed in the public github branc= h: > > > > > > https://github.com/semihalf-wojtas-marcin/edk2-platforms/commit= s/acpi-mdio-r20210613 > > > > > > There is also MacchiatoBin firmware binary avaialable for testi= ng: > > > > > > https://drive.google.com/file/d/1eigP_aeM4wYQpEaLAlQzs3IN_w1-kQ= r0 > > > > > > > > > > > > I'm looking forward to the comments or remarks. > > > > > > > > > > The patches themselves look straightforward enough. > > > > > I *would* prefer some tested-by, for these sources rather than th= e > > > > > binary, before merging though. > > > > > > > > > > > > > I have some our patches queued, that are blocked by this patchset. = In > > > > case no time is found for external testers - if this may help to ge= t > > > > it pushed through, please see below logs from the next-20210628 tag > > > > and unchanged firmware. All network ports of MacchiatoBin and > > > > CN913x-DB work properly, with full 1G/10G PHY support via X/MDIO > > > > interfaces: > > > > > > > > MacchiatoBin > > > > # uname -a > > > > Linux buildroot 5.13.0-rc7-next-20210628 #6 SMP PREEMPT Tue Jun 29 > > > > 09:14:07 CEST 2021 aarch64 GNU/Linux > > > > # dmesg | grep MRVL0101 > > > > [ 1.829659] mv88x3340 MRVL0101:00-mii:00: Firmware version 0.3.3= .0 > > > > [ 1.839622] mv88x3340 MRVL0101:00-mii:08: Firmware version 0.3.3= .0 > > > > [ 2.748351] mvpp2 MRVL0110:00 eth1: PHY [MRVL0101:00-mii:00] dri= ver > > > > [mv88x3340] (irq=3DPOLL) > > > > [ 2.767479] mvpp2 MRVL0110:01 eth2: PHY [MRVL0101:00-mii:08] dri= ver > > > > [mv88x3340] (irq=3DPOLL) > > > > # dmesg | grep MRVL0100 > > > > [ 2.919424] mvpp2 MRVL0110:01 eth3: PHY [MRVL0100:00-mii:00] dri= ver > > > > [Marvell 88E1510] (irq=3DPOLL) > > > > # dmesg | grep mvpp2 > > > > [...] > > > > [ 2.748351] mvpp2 MRVL0110:00 eth1: PHY [MRVL0101:00-mii:00] dri= ver > > > > [mv88x3340] (irq=3DPOLL) > > > > [ 2.756701] mvpp2 MRVL0110:00 eth1: configuring for phy/10gbase-= r link mode > > > > [ 2.767479] mvpp2 MRVL0110:01 eth2: PHY [MRVL0101:00-mii:08] dri= ver > > > > [mv88x3340] (irq=3DPOLL) > > > > [ 2.775834] mvpp2 MRVL0110:01 eth2: configuring for phy/10gbase-= r link mode > > > > [ 2.919424] mvpp2 MRVL0110:01 eth3: PHY [MRVL0100:00-mii:00] dri= ver > > > > [Marvell 88E1510] (irq=3DPOLL) > > > > [ 2.928285] mvpp2 MRVL0110:01 eth3: configuring for phy/sgmii li= nk mode > > > > [ 2.936351] mvpp2 MRVL0110:01 eth4: configuring for > > > > inband/2500base-x link mode > > > > [ 5.987259] mvpp2 MRVL0110:01 eth3: Link is Up - 1Gbps/Full - fl= ow > > > > control off > > > > # > > > > > > > > CN913x-DB > > > > # uname -a > > > > Linux buildroot 5.13.0-rc7-next-20210628 #6 SMP PREEMPT Tue Jun 29 > > > > 09:14:07 CEST 2021 aarch64 GNU/Linux > > > > # dmesg | grep MRVL0100 > > > > [ 2.621201] mvpp2 MRVL0110:00 eth2: PHY [MRVL0100:00-mii:00] dri= ver > > > > [Marvell 88E1510] (irq=3DPOLL) > > > > [ 2.741199] mvpp2 MRVL0110:00 eth3: PHY [MRVL0100:00-mii:01] dri= ver > > > > [Marvell 88E1510] (irq=3DPOLL) > > > > # dmesg | grep mvpp2 > > > > [...] > > > > [ 2.544917] mvpp2 MRVL0110:00 eth1: configuring for > > > > inband/10gbase-r link mode > > > > [ 2.552480] mvpp2 MRVL0110:00 eth1: Link is Up - 10Gbps/Full - f= low > > > > control rx > > > > [ 2.621201] mvpp2 MRVL0110:00 eth2: PHY [MRVL0100:00-mii:00] dri= ver > > > > [Marvell 88E1510] (irq=3DPOLL) > > > > [ 2.630060] mvpp2 MRVL0110:00 eth2: configuring for phy/rgmii-id= link mode > > > > [ 2.741199] mvpp2 MRVL0110:00 eth3: PHY [MRVL0100:00-mii:01] dri= ver > > > > [Marvell 88E1510] (irq=3DPOLL) > > > > [ 2.750056] mvpp2 MRVL0110:00 eth3: configuring for phy/rgmii-id= link mode > > > > [ 2.810169] mvpp2 MRVL0110:01 eth4: configuring for > > > > inband/10gbase-r link mode > > > > [ 2.817471] mvpp2 MRVL0110:01 eth4: Link is Up - 10Gbps/Full - f= low > > > > control rx > > > > [ 5.693231] mvpp2 MRVL0110:00 eth2: Link is Up - 1Gbps/Full - fl= ow > > > > control off > > > > [ 10.840942] mvpp2 MRVL0110:00 eth1: Link is Down > > > > [ 10.864124] mvpp2 MRVL0110:01 eth4: Link is Down > > > > # > > > > > > > > > > Both platforms were have been additionally tested by Greg, do you hav= e > > > any comments/objections to merging this patchset? > > > > > > Thanks, > > > Marcin > > > > You can add my Tested-by as well. Finally got time over the weekend > > to verify on all my Marvell platforms this effects. > > > > Thanks all. I will get to this shortly - apologies for the delay. Pushed as bfabeef4c9a6..955187a12a8b Thanks all.