From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.102308.1674827788395645714 for ; Fri, 27 Jan 2023 05:56:28 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DI3t5P4J; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D52B661C65 for ; Fri, 27 Jan 2023 13:56:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42B41C433EF for ; Fri, 27 Jan 2023 13:56:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674827787; bh=dxDLjvTngE2GSrVyo3Whb5n7i7A8T2+bkulzPgypGjs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=DI3t5P4JKscY4LzHcrbTvVP3tLj7EuhTe/fuKwgBKUUM1PfsePUhK+almoW/ZjI3I EQNRUnyAuxVBZmR3gzULfZ87bkPUzukwPQmiGcdb6AxVt4X05h/y6aD/upOnV0WEjq 7hjBd/j5v+StGMYq0hV3NWhB5msuST5JUiU/DhH5hyq1+he+UhmM6BS8RPCB4TAFws xUZQfIJEVBuybesZBkwFo3GCfmqhN+GLU67aJvCfHf8jppx8oTtpDR2IjVszNwftCA lOLTDXVa+Nw3DHyw3ehUt/e8rUk4WUeoV51vAv136pANUFt9ORPNguLDNimstTaDV5 E2/CKWEVTOlCQ== Received: by mail-lj1-f177.google.com with SMTP id c3so5628448ljh.1 for ; Fri, 27 Jan 2023 05:56:27 -0800 (PST) X-Gm-Message-State: AFqh2kpS5GD+D/CpIsG86aBt76FNf8jTuSWQEZEryhDW2GHTY8hhooRc SAOa88XPC7j0P9rQ9IC+Kfkca7lQGmaVz3Qh9rE= X-Google-Smtp-Source: AMrXdXvlnsWkrP3WAR73KKy8Rc+2EsgpojmJpFsnVH2BTWru8MDY5NaNLjnPdV4wcOxdzpAfVpaa3MtiGDYxt962T7E= X-Received: by 2002:a2e:a163:0:b0:28b:95fe:65ea with SMTP id u3-20020a2ea163000000b0028b95fe65eamr2654288ljl.244.1674827785316; Fri, 27 Jan 2023 05:56:25 -0800 (PST) MIME-Version: 1.0 References: <20230126152158.48948-1-rebecca@bsdio.com> In-Reply-To: <20230126152158.48948-1-rebecca@bsdio.com> From: "Ard Biesheuvel" Date: Fri, 27 Jan 2023 14:56:13 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/1] BaseTools: Delete Bin/{CYGWIN_NT-5.1-i686,Darwin-i386} directories To: Rebecca Cran Cc: devel@edk2.groups.io, Leif Lindholm , Bob Feng , Liming Gao , Yuwei Chen , =?UTF-8?Q?Marvin_H=C3=A4user?= Content-Type: text/plain; charset="UTF-8" On Thu, 26 Jan 2023 at 16:22, Rebecca Cran wrote: > > The Bin/CYGWIN_NT-5.1-i686 and Bin/Darwin-i386 directories contained > files needed for RVCT support. > > Since EDK2 no longer supports RVCT, delete those directories. > > Signed-off-by: Rebecca Cran > --- > BaseTools/Bin/CYGWIN_NT-5.1-i686/BootSectImage | 29 ------- > BaseTools/Bin/CYGWIN_NT-5.1-i686/BuildEnv | 5 -- > BaseTools/Bin/CYGWIN_NT-5.1-i686/Ecc | 14 ---- > BaseTools/Bin/CYGWIN_NT-5.1-i686/EfiLdrImage | 29 ------- > BaseTools/Bin/CYGWIN_NT-5.1-i686/EfiRom | 29 ------- > BaseTools/Bin/CYGWIN_NT-5.1-i686/GenCrc32 | 29 ------- > BaseTools/Bin/CYGWIN_NT-5.1-i686/GenDepex | 14 ---- > BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFds | 14 ---- > BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFfs | 29 ------- > BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFv | 29 ------- > BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFw | 29 ------- > BaseTools/Bin/CYGWIN_NT-5.1-i686/GenPage | 29 ------- > BaseTools/Bin/CYGWIN_NT-5.1-i686/GenSec | 29 ------- > BaseTools/Bin/CYGWIN_NT-5.1-i686/GenVtf | 29 ------- > BaseTools/Bin/CYGWIN_NT-5.1-i686/GnuGenBootSector | 29 ------- > BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaCompress | 29 ------- > BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaF86Compress | 17 ---- > BaseTools/Bin/CYGWIN_NT-5.1-i686/RunBinToolFromBuildDir | 29 ------- > BaseTools/Bin/CYGWIN_NT-5.1-i686/RunToolFromSource | 5 -- > BaseTools/Bin/CYGWIN_NT-5.1-i686/Split | 29 ------- > BaseTools/Bin/CYGWIN_NT-5.1-i686/TargetTool | 14 ---- > BaseTools/Bin/CYGWIN_NT-5.1-i686/TianoCompress | 29 ------- > BaseTools/Bin/CYGWIN_NT-5.1-i686/Trim | 14 ---- > BaseTools/Bin/CYGWIN_NT-5.1-i686/VfrCompile | 29 ------- > BaseTools/Bin/CYGWIN_NT-5.1-i686/VolInfo | 29 ------- > BaseTools/Bin/CYGWIN_NT-5.1-i686/armcc_wrapper.py | 87 -------------------- > BaseTools/Bin/CYGWIN_NT-5.1-i686/build | 14 ---- > BaseTools/Bin/Darwin-i386/Arm/DEBUG_XCODE31/CompilerIntrinsicsLib.lib | Bin 36072 -> 0 bytes > BaseTools/Bin/Darwin-i386/Arm/DEBUG_XCODE32/CompilerIntrinsicsLib.lib | Bin 36072 -> 0 bytes > BaseTools/Bin/Darwin-i386/Arm/RELEASE_XCODE31/CompilerIntrinsicsLib.lib | Bin 11504 -> 0 bytes > BaseTools/Bin/Darwin-i386/Arm/RELEASE_XCODE32/CompilerIntrinsicsLib.lib | Bin 11504 -> 0 bytes > 31 files changed, 691 deletions(-) > Acked-by: Ard Biesheuvel Could you please get rid of the reference below as well? Thanks BaseTools/Scripts/PatchCheck.py:369: self.filename.startswith('BaseTools/Bin/CYGWIN_NT-5.1-i686/') or \