Re: [edk2-devel] [PATCH 3/9] BaseTools: Update CLANGDWARF toolchain and remove CLANG35 and CLANG38

["Ard Biesheuvel" <ardb@kernel.org>]

On Wed, 22 Mar 2023 at 14:03, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> On Wed, Mar 22, 2023 at 01:32:01PM +0100, Ard Biesheuvel wrote:
> > On Wed, 22 Mar 2023 at 13:28, Rebecca Cran <rebecca@bsdio.com> wrote:
> > >
> > > On 3/22/23 5:49 AM, Ard Biesheuvel wrote:
> > >
> > > > The reason I added CLANG3x support for ARM in the past is to ensure
> > > > compatibility with the ARM proprietary, Clang based toolchain. At the
> > > > time, we went with GNU ld, but I would actually prefer if we could
> > > > make this work with LLD as well.
> > > >
> > > > I can work around this issue locally by doing
> > > >
> > > > --- a/OvmfPkg/OvmfPkgX64.dsc
> > > > +++ b/OvmfPkg/OvmfPkgX64.dsc
> > > > @@ -297,7 +297,7 @@
> > > >     PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
> > > >     PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf
> > > >     MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
> > > > -!if $(TOOL_CHAIN_TAG) == "XCODE5"
> > > > +!if $(TOOL_CHAIN_TAG) == "XCODE5" || $(TOOL_CHAIN_TAG) == "CLANGDWARF"
> > > >     CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandlerLib.inf
> > > >   !else
> > > >
> > > > Can you please check whether this works for you as well?
> > >
> > > Thanks, that works here too!
> > >
> > > Do we still need to keep CLANG35 and CLANG38 toolchains for
> > > compatibility with the ARM toolchain? Or have things moved on so they
> > > _can_ be removed?
> > >
> >
> > No, please go ahead and merge all of those - the 35/38 naming is so
> > out of date it is likely to confuse people, so we should rename those
> > in any case.
>
> Same goes for all the GCC4x toolchains I guess ...
>

Indeed - we should just drop those, and rename GCC5 to GCC