From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.41912.1679490333168737929 for ; Wed, 22 Mar 2023 06:05:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kie11JQo; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9B3C5620D4 for ; Wed, 22 Mar 2023 13:05:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03F32C433EF for ; Wed, 22 Mar 2023 13:05:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679490332; bh=qWF15ZYbO1JGvsMSttPfY9aMspIDcQ/3E/eYBP3Vi+g=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=kie11JQodtiDuLHKeY5Og5+KvNleaGhumW6TJylb+zZ6y2rKFWyA/ezD1+pNDpiR8 8WDn9OfgdG31mA03IaD9C8uMy9Es9GMMV570/s/O5XRpcKjiVAY1JNBJ3q6Lufpw96 /7YkyRsghATq33sFya1WeCmpxayShq7ng9bTmwbp3MYOb2FM46M/3dffAXDzRFVmzI u91XuUc4LY+oW0EBzp+sxDpPfKq6XVGORYMeGzEh2wpPH8696PD/NwPzvk4zMWlouX eTi/dPZtVxJVweL8ZMw6IO8uOfdW1hRQ8euRS0WEtgJVmYp2HeURT1ZpNBvWK8Yyx2 f9gPRz+h4jhkw== Received: by mail-lj1-f173.google.com with SMTP id 20so11722091lju.0 for ; Wed, 22 Mar 2023 06:05:31 -0700 (PDT) X-Gm-Message-State: AO0yUKW271iJ9AbyfIQ6HicQFpL6Kw+BRbZMoqqQVgCmeUbySu666iCd eAmxPyCzx5fF8m7kXQOHXZ/wwVNf+dcJ9vxYQno= X-Google-Smtp-Source: AK7set8gTw6ovcNQQxRhSiCDCQXcGLIn0C35/hw4xBAw4bZ0DVmLwALKJxLNDFCYmzpI+gGyBrJz30UexhyTBqEDYNI= X-Received: by 2002:a2e:9d43:0:b0:29e:ba2a:3e09 with SMTP id y3-20020a2e9d43000000b0029eba2a3e09mr1982568ljj.2.1679490329995; Wed, 22 Mar 2023 06:05:29 -0700 (PDT) MIME-Version: 1.0 References: <20230322013040.3322865-1-rebecca@bsdio.com> <20230322013040.3322865-4-rebecca@bsdio.com> <20230322130319.nh2eobdudgjbm7uf@sirius.home.kraxel.org> In-Reply-To: <20230322130319.nh2eobdudgjbm7uf@sirius.home.kraxel.org> From: "Ard Biesheuvel" Date: Wed, 22 Mar 2023 14:05:18 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 3/9] BaseTools: Update CLANGDWARF toolchain and remove CLANG35 and CLANG38 To: Gerd Hoffmann Cc: Rebecca Cran , devel@edk2.groups.io, Michael D Kinney , Liming Gao , Zhiguang Liu , Bob Feng , Yuwei Chen , Andrew Fish , Leif Lindholm , Ard Biesheuvel , Jordan Justen Content-Type: text/plain; charset="UTF-8" On Wed, 22 Mar 2023 at 14:03, Gerd Hoffmann wrote: > > On Wed, Mar 22, 2023 at 01:32:01PM +0100, Ard Biesheuvel wrote: > > On Wed, 22 Mar 2023 at 13:28, Rebecca Cran wrote: > > > > > > On 3/22/23 5:49 AM, Ard Biesheuvel wrote: > > > > > > > The reason I added CLANG3x support for ARM in the past is to ensure > > > > compatibility with the ARM proprietary, Clang based toolchain. At the > > > > time, we went with GNU ld, but I would actually prefer if we could > > > > make this work with LLD as well. > > > > > > > > I can work around this issue locally by doing > > > > > > > > --- a/OvmfPkg/OvmfPkgX64.dsc > > > > +++ b/OvmfPkg/OvmfPkgX64.dsc > > > > @@ -297,7 +297,7 @@ > > > > PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf > > > > PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf > > > > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf > > > > -!if $(TOOL_CHAIN_TAG) == "XCODE5" > > > > +!if $(TOOL_CHAIN_TAG) == "XCODE5" || $(TOOL_CHAIN_TAG) == "CLANGDWARF" > > > > CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandlerLib.inf > > > > !else > > > > > > > > Can you please check whether this works for you as well? > > > > > > Thanks, that works here too! > > > > > > Do we still need to keep CLANG35 and CLANG38 toolchains for > > > compatibility with the ARM toolchain? Or have things moved on so they > > > _can_ be removed? > > > > > > > No, please go ahead and merge all of those - the 35/38 naming is so > > out of date it is likely to confuse people, so we should rename those > > in any case. > > Same goes for all the GCC4x toolchains I guess ... > Indeed - we should just drop those, and rename GCC5 to GCC