Re: [edk2-devel] [PATCH edk2-platforms 3/4] Platform/Ampere: Switch to generic ResetRuntime DXE driver

["Ard Biesheuvel" <ardb@kernel.org>]

On Tue, 23 Jul 2024 at 17:46, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Tue, 23 Jul 2024 at 17:32, Leif Lindholm <quic_llindhol@quicinc.com> wrote:
> >
> > On Sun, Jul 21, 2024 at 16:51:54 +0200, Ard Biesheuvel wrote:
> > > From: Ard Biesheuvel <ardb@kernel.org>
> > >
> > > The reset runtime DXE driver is deprecated and will be removed soon. It
> > > is superseded by a generic implementation in MdeModulePkg, which is
> > > shared between all architectures, and implements the notification
> > > protocols that the EFI spec describes. So move the Ampere Jade platform
> > > to this implementation the of ResetSystem EFI runtime service.
> > >
> > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > > ---
> > >  Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 3 +--
> > >  Platform/Ampere/JadePkg/Jade.fdf                     | 2 +-
> > >  2 files changed, 2 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
> > > index 1f705c68579a..fb170d436d00 100644
> > > --- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
> > > +++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
> > > @@ -259,7 +259,6 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER]
> > >  !endif
> > >    VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
> > >
> > > -  EfiResetSystemLib|ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.inf
> >
> > Would it make sense to move the existing ResetSystemLib mapping here?
> > Not for any particular reason other than it's not actually used
> > anywhere else.
>
> There isn't an obvious reason imo why we would ever use another
> ResetSystemLib instance for other phases - the existing one is
> universal, i.e., it doesn't produce HOBs or consume PPIs or protocols
> and so it is usable from any context. So moving it here is possible
> but unnecessary.
>
>
> > Regardless, for the series:
> > Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
> >
>
> Cheers.

Merged as  a9dd58388452..8b7e9363aab9


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120016): https://edk2.groups.io/g/devel/message/120016
Mute This Topic: https://groups.io/mt/107476835/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-