From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8D9117803D2 for ; Tue, 23 Jul 2024 15:49:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=sCcQFQmAoq2uHHCRhKcsmNCzOmQsmVVy1jEd692fyow=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1721749794; v=1; b=Ey3lg4tRdnImM3mvIxwjcIkICpQ3wTiccfxC1BNZsVL6SsNb0T8oMLiSFLc9lfrUNjhC19Tf QfXqq0Op/scukSpSZkCMaR9K+nW3cpoCfZWbSC7FbMsLPWuJ1gCDDJpAK66ARIDIm3w/ZGPfs+Q FFim8Z1NKZhRtcok1zER2gVYWwm3Tlnn0QZ0c/SmpwF6EKT+2PpIFsvy34+qJ5rtYvqOS31qMu7 YjGnCEwuw8RDnl9Tzm5zpJTZvTaZRuHebrTorxfAIfPXfXdWhbqJs/7cE/zYaU7vMvKM9hyF+90 crG9FfcOHrpKPUa7j6KEiIECY4PpZJKqkL7GmkYw0jKpg== X-Received: by 127.0.0.2 with SMTP id 23dHYY7687511xQ6TBOmLAKc; Tue, 23 Jul 2024 08:49:53 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.535.1721749792567125080 for ; Tue, 23 Jul 2024 08:49:52 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 166F261171 for ; Tue, 23 Jul 2024 15:49:52 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF0D3C4AF12 for ; Tue, 23 Jul 2024 15:49:51 +0000 (UTC) X-Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2eeb1ba0468so77005561fa.0 for ; Tue, 23 Jul 2024 08:49:51 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCU3aQqcrABJfkx5PAduj1ObWb7rHsSVHL6VrzVm4tsKq5RIAqCcZ6Hw7gAYPBBakfFmc6vKVAvLa/3CnbsNWJUqcTxXMw== X-Gm-Message-State: 6xZtpkPXoJtgo9TnsgiQ82QKx7686176AA= X-Google-Smtp-Source: AGHT+IFQSxelhkKSzCcxLjxDBuo6JwtL2TIT9yL1MsQuPJuE/muXeQ8n8IR74mqf2uWiei6g+oDC8R7OqlMwINtlWEc= X-Received: by 2002:a2e:9948:0:b0:2ef:2fc9:c8b2 with SMTP id 38308e7fff4ca-2f02b98b02cmr2225871fa.37.1721749790114; Tue, 23 Jul 2024 08:49:50 -0700 (PDT) MIME-Version: 1.0 References: <20240721145155.324900-1-ardb+git@google.com> <20240721145155.324900-4-ardb+git@google.com> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 23 Jul 2024 17:49:38 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms 3/4] Platform/Ampere: Switch to generic ResetRuntime DXE driver To: Leif Lindholm Cc: Ard Biesheuvel , devel@edk2.groups.io, Oliver Smith-Denny , Rebecca Cran , Nhi Pham , Chuong Tran , Peng Xie , Ling Jia , Yiqi Shu Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 23 Jul 2024 08:49:52 -0700 Resent-From: ardb@kernel.org Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=Ey3lg4tR; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, 23 Jul 2024 at 17:46, Ard Biesheuvel wrote: > > On Tue, 23 Jul 2024 at 17:32, Leif Lindholm wrote: > > > > On Sun, Jul 21, 2024 at 16:51:54 +0200, Ard Biesheuvel wrote: > > > From: Ard Biesheuvel > > > > > > The reset runtime DXE driver is deprecated and will be removed soon. It > > > is superseded by a generic implementation in MdeModulePkg, which is > > > shared between all architectures, and implements the notification > > > protocols that the EFI spec describes. So move the Ampere Jade platform > > > to this implementation the of ResetSystem EFI runtime service. > > > > > > Signed-off-by: Ard Biesheuvel > > > --- > > > Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 3 +-- > > > Platform/Ampere/JadePkg/Jade.fdf | 2 +- > > > 2 files changed, 2 insertions(+), 3 deletions(-) > > > > > > diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc > > > index 1f705c68579a..fb170d436d00 100644 > > > --- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc > > > +++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc > > > @@ -259,7 +259,6 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > > > !endif > > > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf > > > > > > - EfiResetSystemLib|ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.inf > > > > Would it make sense to move the existing ResetSystemLib mapping here? > > Not for any particular reason other than it's not actually used > > anywhere else. > > There isn't an obvious reason imo why we would ever use another > ResetSystemLib instance for other phases - the existing one is > universal, i.e., it doesn't produce HOBs or consume PPIs or protocols > and so it is usable from any context. So moving it here is possible > but unnecessary. > > > > Regardless, for the series: > > Reviewed-by: Leif Lindholm > > > > Cheers. Merged as a9dd58388452..8b7e9363aab9 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120016): https://edk2.groups.io/g/devel/message/120016 Mute This Topic: https://groups.io/mt/107476835/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-