From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.22463.1680090830001918728 for ; Wed, 29 Mar 2023 04:53:50 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sSFOgmmP; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 749E561CDC for ; Wed, 29 Mar 2023 11:53:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BFA22C433A4 for ; Wed, 29 Mar 2023 11:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680090828; bh=KCIEq2YNXXGU6bEGVN1CHwOju10Rx64oyDkTmiebItE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=sSFOgmmPwR5/xwQKwx6mFB6Xbi5RBZKNLvJByd+z0mHMRpKm+9mLscVcNQg9ybqw3 NcCw4HOiU+9EqrZUjSDbEtR0tCEyiocuHiRDYMDmJCHywTIkjtIKSZrpqVvblS0V2U Sc4Mv2xh+H7FYnnXN+7i57CzJaUTR5DABeQbaRR+ePYqbIqaTXBO1kHqrY7+Sf+Az7 KckcJAj1x2NqM8MBsk6uykIQ3NGM1IWO13nuptiuj9Lce2tXrZsWfyoS4pOtJFFnkw 98TFEOa97zhAcsmMNjMCQXx4dgjdbl4WB3nLQMchBIJo4UV0bQ2s/qMJn82IXOUB6U VlN7vJG2SQl0Q== Received: by mail-lj1-f181.google.com with SMTP id e21so15775691ljn.7 for ; Wed, 29 Mar 2023 04:53:48 -0700 (PDT) X-Gm-Message-State: AAQBX9fmwMEBznLObRkblYXV0p17aO3C54u4UjwJFp9AMR4FkENSFpK4 EGT2xzmomvAYG38V9ccybhAC/PV4d5SB2j0y7N8= X-Google-Smtp-Source: AKy350bHPvWwJH1OA7LKjJuVRxwoq9d0YxZljM60Iv0S0EUg7G0k2hrN69WYLxUSeZczDkSq7e9yoyTEe73qIjUQQ/4= X-Received: by 2002:a2e:8712:0:b0:2a5:ff82:1795 with SMTP id m18-20020a2e8712000000b002a5ff821795mr2127738lji.2.1680090826741; Wed, 29 Mar 2023 04:53:46 -0700 (PDT) MIME-Version: 1.0 References: <20230328173111.759017-1-rebecca@bsdio.com> <02fb01d961dc$88d6acd0$9a840670$@byosoft.com.cn> In-Reply-To: From: "Ard Biesheuvel" Date: Wed, 29 Mar 2023 13:53:35 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC To: devel@edk2.groups.io, quic_llindhol@quicinc.com Cc: gaoliming@byosoft.com.cn, rebecca@bsdio.com, Oliver Smith-Denny , Guomin Jiang , Xiaoyu Lu , Jian J Wang , Jiewen Yao , Ard Biesheuvel , Jordan Justen , Gerd Hoffmann , Bob Feng , Andrew Fish , Michael D Kinney Content-Type: text/plain; charset="UTF-8" On Wed, 29 Mar 2023 at 13:28, Leif Lindholm wrote: > > On Wed, Mar 29, 2023 at 09:39:56 +0200, Ard Biesheuvel wrote: > > > > - Remove GCC48 and GCC49. > > > > > > GCC49 is one GCC tool chain without LTO enable option. GCC5 is another GCC tool chain with LTO enable option. > > > > > > They have the different usage. I suggest to keep GCC49 and GCC5 both, and also keep their name as is. > > > > > > > Could we perhaps do > > > > GCC49 -> GCC > > GCC5 -> GCCLTO > > Might I suggest the inverse? > > GCC49 -> GCCNOLTO > GCC5 -> GCC > > I feel disabling LTO should be seen as the nonstandard approach. > That works for me as well. > Regardless, we (including me) *should* have changed those names as > soon as we realised we didn't need a GCC51, and the misleading naming > still frequently causes confusion. So I don't think keeping the > current names should be considered an option. > Agreed. > > ? > > > > As with CLANG35/38, the GCCx names have become rather obsolete, so I'd > > prefer to have a set of more generic names, and a sliding window of > > supported versions that can be documented in tools_def.template (and > > updated at times) > > Agreed. And *if* we find a need in the future to add a new archived > range, we can add that then. > Of course. But with the stable tags, I doubt whether this will be necessary.