From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by mx.groups.io with SMTP id smtpd.web10.49264.1680248461498556474
 for <devel@edk2.groups.io>;
 Fri, 31 Mar 2023 00:41:01 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lpAWNV33;
 spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dfw.source.kernel.org (Postfix) with ESMTPS id C4A726242B
	for <devel@edk2.groups.io>; Fri, 31 Mar 2023 07:41:00 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39FA0C4339E
	for <devel@edk2.groups.io>; Fri, 31 Mar 2023 07:41:00 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1680248460;
	bh=FifH6Ep+NZsZ1dSa4aDTD5V6d+N/RgWYFRxHEwSzLl8=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=lpAWNV33ztAmvGpCCwODUwB6g6pRcBDpC4aHofG/DjRetgcMeJG4dVKOP0yyShYKU
	 qQhqOMtZnOxoghL8EJIBNbNMPVdGA8RHhI4n3bqlW4yJ3sjAc8J+OUa/kqiSZR0QNc
	 tYmnzcFrxKGTNn8RjF2/S4LGEB/Mkl30F69FroPhQtQKSf8LXqJLI3RRkLEtVTD6jp
	 XrWKydRBPYUsLwrq5jn1L6qrA6i/HWevQ4c6vRdNEjCS5BiX84EvI7PO38Oclzswj2
	 6H1thfnEjzFtMCaWkXmg/pFMQOGH78qatfdTSCMb5H9umqQ+rL7yQVlm9pe1ZPAXwo
	 WmB7RmsoGg1Gw==
Received: by mail-lf1-f53.google.com with SMTP id g19so14661551lfr.9
        for <devel@edk2.groups.io>; Fri, 31 Mar 2023 00:41:00 -0700 (PDT)
X-Gm-Message-State: AAQBX9dmY1mkHPHKzEewV7r/9oRcpcgqed0fRJmYBXl+AU3wHYbGzkiD
	yEEJ3EyJgwSFQ0HOG8E8YSkBT/NfEUYJXxSCAQo=
X-Google-Smtp-Source: AKy350YWxdbMFFQwEh239MThnbsNHPJeJBFf0/5VpKV3KwbPFUDNNKKJhTsv7kekAmi61juGxTxrWmpU+nZEoP2DgGc=
X-Received: by 2002:ac2:568f:0:b0:4ea:ef08:8d30 with SMTP id
 15-20020ac2568f000000b004eaef088d30mr7689411lfr.9.1680248458252; Fri, 31 Mar
 2023 00:40:58 -0700 (PDT)
MIME-Version: 1.0
References: <20230330212101.1566931-1-ardb@kernel.org> <20230330212101.1566931-4-ardb@kernel.org>
 <MN6PR11MB82442D7CD6E43529B69F9BEC8C8F9@MN6PR11MB8244.namprd11.prod.outlook.com>
In-Reply-To: <MN6PR11MB82442D7CD6E43529B69F9BEC8C8F9@MN6PR11MB8244.namprd11.prod.outlook.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Fri, 31 Mar 2023 09:40:47 +0200
X-Gmail-Original-Message-ID: <CAMj1kXFH1bkNe9rbbgeo9NQoJrT_J3L0pBC0a7kVtAaiHy-3Hw@mail.gmail.com>
Message-ID: <CAMj1kXFH1bkNe9rbbgeo9NQoJrT_J3L0pBC0a7kVtAaiHy-3Hw@mail.gmail.com>
Subject: Re: [edk2-devel] [RFT PATCH v2 3/6] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version
To: devel@edk2.groups.io, ray.ni@intel.com
Cc: Andrew Fish <afish@apple.com>, "Kinney, Michael D" <michael.d.kinney@intel.com>, 
	"Liu, Zhiguang" <zhiguang.liu@intel.com>, Rebecca Cran <rebecca@bsdio.com>, 
	Tom Lendacky <thomas.lendacky@amd.com>
Content-Type: text/plain; charset="UTF-8"

On Fri, 31 Mar 2023 at 06:24, Ni, Ray <ray.ni@intel.com> wrote:
>
> Thanks for the change.
>
> But it doesn't highlight another impact due to this change: CET logic is removed from the SEC/PEI version.

No the ordinary SEC/PEI version does not have the CET logic - only the
XCODE version does.

> It's not an issue because CET is only enabled in SMM environment today.
> But better to highlight the impact in the commit message, and explicitly say that limitation in the SecPeiCpuExceptionHandlerLib.inf file.
>

I am going to have to revisit this anyway, but I will put some more
context about this in the commit log.