From: "Ard Biesheuvel" <ardb@kernel.org>
To: devel@edk2.groups.io, quic_rcran@quicinc.com
Cc: Leif Lindholm <quic_llindhol@quicinc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Sami Mujawar <sami.mujawar@arm.com>,
Jian J Wang <jian.j.wang@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH 0/2] Add support EFI_MP_SERVICES_PROTOCOL on AARCH64
Date: Tue, 6 Sep 2022 19:53:53 +0200 [thread overview]
Message-ID: <CAMj1kXFHMgm2XWeJ_kiNXCbAyT+KySFLqDBPUv_OZeJTLGF4cQ@mail.gmail.com> (raw)
In-Reply-To: <c9038af6-c501-0e5d-4cb6-dd0f3cda4814@quicinc.com>
On Tue, 6 Sept 2022 at 19:01, Rebecca Cran <quic_rcran@quicinc.com> wrote:
>
> On 9/5/22 09:55, Ard Biesheuvel wrote:
> > I think you've got things covered: I suggested RPi4 because it uses
> > A72, and I seem to remember the issues I observed were either on A57
> > or A72 (which are quite similar). But between Juno and HoneyComb, I
> > don't think the RPi4 data point is that useful.
>
> My only concern is about the call in MpServicesTest:
>
> WriteBackDataCacheRange ((VOID *)&ApFunction, 32);
>
> Obviously the '32' is a magic number and should be something based on the size of ApFunction.
> But I don't think there's a portable way to calculate what that value should be.
>
Why exactly do we need that call?
I understand that some of the code needs to be clean to the PoC (on
ARM) so that the AP can fetch instructions with the MMU and caches
disabled. But the actual routine passed into the API is called with
the MMU and caches on, right?
next prev parent reply other threads:[~2022-09-06 17:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 15:59 [PATCH 0/2] Add support EFI_MP_SERVICES_PROTOCOL on AARCH64 Rebecca Cran
2022-08-29 15:59 ` [PATCH 1/2] ArmPkg: implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls Rebecca Cran
2022-09-29 18:45 ` [edk2-devel] " Kun Qin
2022-11-28 22:59 ` Kun Qin
2022-11-29 0:04 ` Rebecca Cran
2022-11-30 0:15 ` Kun Qin
2022-11-28 23:59 ` Rebecca Cran
2022-08-29 15:59 ` [PATCH 2/2] MdeModulePkg: Add new Application/MpServicesTest application Rebecca Cran
2022-08-30 16:29 ` Rebecca Cran
2022-09-05 10:57 ` [edk2-devel] [PATCH 0/2] Add support EFI_MP_SERVICES_PROTOCOL on AARCH64 Ard Biesheuvel
2022-09-05 15:51 ` Rebecca Cran
2022-09-05 15:55 ` Ard Biesheuvel
2022-09-06 16:53 ` Ard Biesheuvel
2022-09-06 17:01 ` Rebecca Cran
2022-09-06 17:53 ` Ard Biesheuvel [this message]
2022-09-06 18:17 ` Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXFHMgm2XWeJ_kiNXCbAyT+KySFLqDBPUv_OZeJTLGF4cQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox