From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4D24E9416FB for ; Tue, 19 Dec 2023 09:30:05 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=4afL5/TCVvswDfJJs5hpb7XPdbGQ2Df1mjea20yQMHY=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1702978203; v=1; b=V84IIB32ps1jBeFEAtNaIXoUJsk9Zs1ZpH1hlzbGl4VHQkfh6+Wsa5t+PKq13NGxHj1Anzqq 13uy5dnjyKleqZ5beiAMJyI+4Iv8jn5kaQl9Pw5vQJvzwSYrsdiGpF1OsENLtJIZ7KYcW2ZHjL+ 9MdWy92Kziz+QT7Qp/6B61Z8= X-Received: by 127.0.0.2 with SMTP id IBItYY7687511xJo3pdyKRdj; Tue, 19 Dec 2023 01:30:03 -0800 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web10.8630.1702978202881765824 for ; Tue, 19 Dec 2023 01:30:03 -0800 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 914EECE174E for ; Tue, 19 Dec 2023 09:29:59 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCA16C433C8 for ; Tue, 19 Dec 2023 09:29:58 +0000 (UTC) X-Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2cc63b3ed71so39910941fa.3 for ; Tue, 19 Dec 2023 01:29:58 -0800 (PST) X-Gm-Message-State: E09yaEXZaQKjGkdkXeDkm3Myx7686176AA= X-Google-Smtp-Source: AGHT+IGFvfzxPjk+H+hBPW297dGOlQWtqWAl0KjsQI1k066rbYgryoP0ruVblNs+3QtJ6k9pZTpgS7YMRCqoNg52pRE= X-Received: by 2002:a2e:7c13:0:b0:2cc:7ac4:d369 with SMTP id x19-20020a2e7c13000000b002cc7ac4d369mr834246ljc.17.1702978197064; Tue, 19 Dec 2023 01:29:57 -0800 (PST) MIME-Version: 1.0 References: <1794F968339CC3DE.12603@groups.io> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 19 Dec 2023 10:29:45 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v4 0/4] StandaloneMmCore finds drivers in uncompressed inner fv. To: "Xu, Wei6" Cc: "Ni, Ray" , "devel@edk2.groups.io" , Laszlo Ersek , Ard Biesheuvel , Sami Mujawar Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=V84IIB32; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, 18 Dec 2023 at 10:08, Xu, Wei6 wrote: > > Thanks Ray, > > The PR is updated with "Reviewed-by" added. > https://github.com/tianocore/edk2/pull/5004 > Pushed, thanks. > -----Original Message----- > From: Ni, Ray > Sent: Monday, December 18, 2023 1:02 PM > To: Xu, Wei6 ; devel@edk2.groups.io > Cc: Laszlo Ersek ; Ard Biesheuvel ; Sami Mujawar > Subject: RE: [edk2-devel] [PATCH v4 0/4] StandaloneMmCore finds drivers in uncompressed inner fv. > > Reviewed-by: Ray Ni > > Can you kindly update the PR to add the Reviewed-by? I can help to set "push" label after that. > > Thanks, > Ray > > -----Original Message----- > > From: Xu, Wei6 > > Sent: Monday, December 18, 2023 9:37 AM > > To: devel@edk2.groups.io; Xu, Wei6 > > Cc: Laszlo Ersek ; Ard Biesheuvel > > ; Sami Mujawar ; Ni, > > Ray > > Subject: RE: [edk2-devel] [PATCH v4 0/4] StandaloneMmCore finds > > drivers in uncompressed inner fv. > > > > This patch series already got "reviewed-by" from Laszlo. Could anyone > > help to merge the changes? Thanks a lot. > > > > Thanks Laszlo for reviewing the patches. > > > > BR, > > Wei > > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Xu, > > Wei6 > > Sent: Monday, November 6, 2023 3:53 PM > > To: devel@edk2.groups.io > > Cc: Xu, Wei6 ; Laszlo Ersek ; > > Ard Biesheuvel ; Sami Mujawar > > ; Ni, Ray > > Subject: [edk2-devel] [PATCH v4 0/4] StandaloneMmCore finds drivers in > > uncompressed inner fv. > > > > V1: > > This patch is to fix the issue that StandaloneMmCore fails to detect > > uncompressed inner FV. > > PR: https://github.com/tianocore/edk2/pull/4943 > > > > V2: > > Based on V1, fix some other issues > > 1. Add Missing object size checks before casting pointers to header types > > a. InnerFvHeader = (EFI_FIRMWARE_VOLUME_HEADER *)SectionData; > > This is introduced in V1, add the size check on SectionDataSize > > against EFI_FIRMWARE_VOLUME_HEADER > > b. Section = (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1); > > Use FfsFindSection instead of FfsFindSectionData to avoid pointer > > casting. > > 2. Fix potential memory leak issue that ScratchBuffer is not freed > > when page allocation for DstBuffer fails. > > PR: https://github.com/tianocore/edk2/pull/4965 > > > > V3: > > 1. Separate patch per individual issue fix on patch V2. > > 2. Fix one more issue: Limit FwVol encapsulation section recursion in > > MmCoreFfsFindMmDriver(). > > PR: https://github.com/tianocore/edk2/pull/4975 > > > > V4: > > Patch (1/4): Move the declaration of MmCoreFfsFindMmDriver() from > > source file to the header file "StandaloneMmCore.h" > > Patch (2/4): Handle the case that ExtractGuidedSectionDecode()'s > > decoded buffer is identical to the data in InputSection Patch (3/4): > > Fix the issue 'Section > > + 1' migth be a wrong address for InnerFvHeader if Section is > > EFI_COMMON_SECTION_HEADER2. > > Patch (4/4): 'Continue' if an EFI_SECTION_FIRMWARE_VOLUME_IMAGE is > > found, do not look for an EFI_SECTION_GUID_DEFINED again. > > PR: https://github.com/tianocore/edk2/pull/5004 > > > > For the recursion logic improvement, Let's do it in other patch set in > > future after this patch is committed. > > > > Cc: Laszlo Ersek > > Cc: Ard Biesheuvel > > Cc: Sami Mujawar > > Cc: Ray Ni > > > > Wei6 Xu (4): > > StandaloneMmPkg/Core: Limit FwVol encapsulation section recursion > > StandaloneMmPkg/Core: Fix potential memory leak issue > > StandaloneMmPkg/Core: Fix issue that offset calculation might be wrong > > StandaloneMmPkg/Core: Fix the failure to find uncompressed inner FV > > > > StandaloneMmPkg/Core/Dispatcher.c | 5 -- > > StandaloneMmPkg/Core/FwVol.c | 88 > > +++++++++++++++++------ > > StandaloneMmPkg/Core/StandaloneMmCore.c | 7 +- > > StandaloneMmPkg/Core/StandaloneMmCore.h | 26 +++++++ > > StandaloneMmPkg/Core/StandaloneMmCore.inf | 3 + > > StandaloneMmPkg/StandaloneMmPkg.dec | 5 ++ > > 6 files changed, 103 insertions(+), 31 deletions(-) > > > > -- > > 2.29.2.windows.2 > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112715): https://edk2.groups.io/g/devel/message/112715 Mute This Topic: https://groups.io/mt/103235459/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-