From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web12.20666.1661187663949566156 for ; Mon, 22 Aug 2022 10:01:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bFO3Am/D; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 78A20B812A8 for ; Mon, 22 Aug 2022 17:01:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42ED2C433B5 for ; Mon, 22 Aug 2022 17:01:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661187661; bh=3L/pxbCGnemc+0Dc52OGaXnBmoYfc9y+gYbwQ6ogn64=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bFO3Am/DJT1urwaFbq5p6sEAHzFYu6zHwMjFiMiKm25jkIiVwFMKGpWwXjrPriS42 nhUAcgIcDW0ajavxkwZ04sGuYJq6/inYSAzEuZMqZ/ULRj+y6/NhFCvWqB9dpwU2aT xwQxfYjcELIqYdXFGlRrCY8xmzVBiS0AQT7FDV05mlQ0QRpizPO3qR/iooSsWKhd8F hbiNbWPbyCt7KcfvJKjkqp8wSVCcu8JjAf6JIE/CJhjtPVmycgVSZiLRaJC+BeBkWt TcoIG89Gcv5IE3DnTf5AsNk0t4WTNEQpckkdQsK2B9ldheSwOzr2cM1iG7BS+Y5S+p h+e/167g7uA6g== Received: by mail-wr1-f54.google.com with SMTP id b5so9726907wrr.5 for ; Mon, 22 Aug 2022 10:01:01 -0700 (PDT) X-Gm-Message-State: ACgBeo2fx5E3rpTxXidtUnofRAW77ApP2MDlqpUHLlyaTGohlrkD1GeT To7CCxfvg0e+jToHYjmfFy1F03jwTQKKt0MiXVs= X-Google-Smtp-Source: AA6agR5cWapKgCC8oA2s+5R6RQsLrODhj7CCnOo488pgvZkLvhTQBGZwVii8WfLXnS3P4TaQSI1dR3AXcBBWr6CdUgw= X-Received: by 2002:a5d:4302:0:b0:225:5303:39e5 with SMTP id h2-20020a5d4302000000b00225530339e5mr4385148wrq.380.1661187659522; Mon, 22 Aug 2022 10:00:59 -0700 (PDT) MIME-Version: 1.0 References: <20220817151157.1941409-1-ardb@kernel.org> <20220817151157.1941409-3-ardb@kernel.org> <606fa379-1740-5353-d156-13069a5ba040@redhat.com> In-Reply-To: <606fa379-1740-5353-d156-13069a5ba040@redhat.com> From: "Ard Biesheuvel" Date: Mon, 22 Aug 2022 19:00:48 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v2 2/2] OvmfPkg/OvmfPkgX64: Allow runtime control of IPv4 and IPv6 support To: devel@edk2.groups.io, lersek@redhat.com Cc: Yuan Yu , Gerd Hoffmann , Pawel Polawski , Oliver Steffen , Jiewen Yao , "Brian J . Johnson" Content-Type: text/plain; charset="UTF-8" On Thu, 18 Aug 2022 at 08:00, Laszlo Ersek wrote: > > On 08/17/22 17:11, Ard Biesheuvel wrote: > > Wire up the newly added UefiDriverEntrypoint in a way that ties dispatch > > of the Ip4Dxe and Ip6Dxe drivers to QEMU fw_cfg variables > > 'opt/org.tianocore/IPv4Support' and 'opt/org.tianocore/IPv6Support' > > respectively. > > > > Setting both variables to 'n' disables IP based networking entirely, > > without the need for additional code changes at the NIC driver or > > network boot protocol level. > > > > Signed-off-by: Ard Biesheuvel > > --- > > OvmfPkg/OvmfPkgX64.dsc | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > > index 6e68f60dc90f..2cbe35c95824 100644 > > --- a/OvmfPkg/OvmfPkgX64.dsc > > +++ b/OvmfPkg/OvmfPkgX64.dsc > > @@ -947,6 +947,20 @@ [Components] > > NULL|OvmfPkg/Library/PxeBcPcdProducerLib/PxeBcPcdProducerLib.inf > > } > > > > + NetworkPkg/Ip4Dxe/Ip4Dxe.inf { > > + > > + UefiDriverEntryPoint|OvmfPkg/Library/UefiDriverEntryPointFwCfgOverrideLib/UefiDriverEntryPointFwCfgOverrideLib.inf > > + > > + gUefiOvmfPkgTokenSpaceGuid.PcdEntryPointOverrideFwCfgVarName|"opt/org.tianocore/IPv4Support" > > + } > > + > > + NetworkPkg/Ip6Dxe/Ip6Dxe.inf { > > + > > + UefiDriverEntryPoint|OvmfPkg/Library/UefiDriverEntryPointFwCfgOverrideLib/UefiDriverEntryPointFwCfgOverrideLib.inf > > + > > + gUefiOvmfPkgTokenSpaceGuid.PcdEntryPointOverrideFwCfgVarName|"opt/org.tianocore/IPv6Support" > > + } > > + > > !if $(NETWORK_TLS_ENABLE) == TRUE > > NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf { > > > > > > Looks good to me, but should be reflected to the other DSC files, and > perhaps (see Gerd's comments) factored out to some common include snippet. > Fair enough, although I'm not sure where to look for Gerd's comments? Did they make it to the list?