public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-platforms][PATCH v1 1/1] Platform/Qemu: Fix build break in SbsaQemu
@ 2022-08-02 14:22 Dimitrije Pavlov
  2022-08-02 17:17 ` [edk2-devel] " Ard Biesheuvel
  0 siblings, 1 reply; 2+ messages in thread
From: Dimitrije Pavlov @ 2022-08-02 14:22 UTC (permalink / raw)
  To: devel; +Cc: Ard Biesheuvel, Jeff Booher-Kaeding, Samer El-Haj-Mahmoud

Commit 6eb407947592e084110a124be089bef167af1383 added a new dependency
of PlatformPKProtectionLib to SecureBootVariableLib. This causes the
build of SbsaQemu to fail.

Add the PlatformPKProtectionLib library instance to SbsaQemu.dsc
to fix the build.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jeff Booher-Kaeding <Jeff.Booher-Kaeding@arm.com>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>

Signed-off-by: Dimitrije Pavlov <Dimitrije.Pavlov@arm.com>
---
 Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
index 97014e2fb630..c912424173a6 100644
--- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
+++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
@@ -158,6 +158,7 @@ [LibraryClasses.common]
   AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 
   # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree
   PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] Platform/Qemu: Fix build break in SbsaQemu
  2022-08-02 14:22 [edk2-platforms][PATCH v1 1/1] Platform/Qemu: Fix build break in SbsaQemu Dimitrije Pavlov
@ 2022-08-02 17:17 ` Ard Biesheuvel
  0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2022-08-02 17:17 UTC (permalink / raw)
  To: edk2-devel-groups-io, Dimitrije Pavlov
  Cc: Ard Biesheuvel, Jeff Booher-Kaeding, Samer El-Haj-Mahmoud

On Tue, 2 Aug 2022 at 16:22, Dimitrije Pavlov <Dimitrije.Pavlov@arm.com> wrote:
>
> Commit 6eb407947592e084110a124be089bef167af1383 added a new dependency
> of PlatformPKProtectionLib to SecureBootVariableLib. This causes the
> build of SbsaQemu to fail.
>
> Add the PlatformPKProtectionLib library instance to SbsaQemu.dsc
> to fix the build.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jeff Booher-Kaeding <Jeff.Booher-Kaeding@arm.com>
> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
>
> Signed-off-by: Dimitrije Pavlov <Dimitrije.Pavlov@arm.com>

Pushed as abf86619660c..c45155be7b88.

Thanks,
> ---
>  Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> index 97014e2fb630..c912424173a6 100644
> --- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> @@ -158,6 +158,7 @@ [LibraryClasses.common]
>    AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
>    SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
>    SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
> +  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
>
>    # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree
>    PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
> --
> 2.34.1
>
>
>
> ------------
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#92045): https://edk2.groups.io/g/devel/message/92045
> Mute This Topic: https://groups.io/mt/92771121/5717338
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb+tianocore@kernel.org]
> ------------
>
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-08-02 17:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-02 14:22 [edk2-platforms][PATCH v1 1/1] Platform/Qemu: Fix build break in SbsaQemu Dimitrije Pavlov
2022-08-02 17:17 ` [edk2-devel] " Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox