Re: [edk2-platforms PATCH 0/8] Update Arm platforms following addition of EFI_MP_SERVICES_PROTOCOL support in edk2

["Ard Biesheuvel" <ardb@kernel.org>]

On Wed, 15 Dec 2021 at 01:03, Rebecca Cran <rebecca@nuviainc.com> wrote:
>
> This patch series depends on the "Add EFI_MP_SERVICES_PROTOCOL support
> for AARCH64" series which is in the process of being reviewed (I'm
> sending a v2 soon).
>
> With the addition of EFI_MP_SERVICES_PROTOCOL support for Arm, consumers
> of ArmPkg/Drivers/CpuDxe now need an instance of MpInitLib. This series
> adds ArmPkg/Library/MpInitLib/DxeMpInitLib.inf.
>
> Also, the ARM_CORE_INFO struct has changed so there's now an MPIDR field
> where there were previously separate cluster and core fields. This
> series updates the initializers for the various instances.
>
>
> Rebecca Cran (8):
>   Platform/ARM: Add MpInitLib instance
>   Platform/Socionext: Add instance of MpInitLib
>   Silicon/Marvell: Add instance of MpInitLib
>   Platform/Qemu: Add instance of MpInitLib
>   Platform/ARM: Update ARM_CORE_INFO initializer for MPIDR field change
>   Silicon/Marvell: Update ARM_CORE_INFO initializer for MPIDR field
>     change
>   Silicon/Socionext: Update ARM_CORE_INFO initializer for MPIDR field
>     change
>   Silicon/Qemu: Update ARM_CORE_INFO initializer for MPIDR field change
>

You appear to have missed a few instances:

Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
Platform/Hisilicon/D03/D03.dsc
Platform/Hisilicon/D05/D05.dsc
Platform/Hisilicon/D06/D06.dsc
Platform/Hisilicon/HiKey/HiKey.dsc
Platform/Hisilicon/HiKey960/HiKey960.dsc
Platform/LeMaker/CelloBoard/CelloBoard.dsc
Platform/Phytium/DurianPkg/DurianPkg.dsc
Platform/RaspberryPi/RPi3/RPi3.dsc
Platform/RaspberryPi/RPi4/RPi4.dsc
Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc

I know this is tedious busywork, but you can't break existing
platforms like that, so please provide a solution for these as well.



>  Platform/ARM/JunoPkg/ArmJuno.dsc                                   |  1 +
>  Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c                  | 12 ++---
>  Platform/ARM/Morello/MorelloPlatform.dsc.inc                       |  1 +
>  Platform/ARM/N1Sdp/N1SdpPlatform.dsc                               |  1 +
>  Platform/ARM/SgiPkg/SgiPlatform.dsc.inc                            |  1 +
>  Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc                       |  1 +
>  Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7.c | 16 +++----
>  Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSM.c         | 16 +++----
>  Platform/Qemu/SbsaQemu/SbsaQemu.dsc                                |  1 +
>  Platform/Socionext/DeveloperBox/DeveloperBox.dsc                   |  1 +
>  Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc       |  1 +
>  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc                      |  1 +
>  Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.c   |  8 ++--
>  Silicon/Qemu/SbsaQemu/Library/SbsaQemuLib/SbsaQemuLib.c            |  8 ++--
>  Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c       | 48 ++++++++++----------
>  15 files changed, 63 insertions(+), 54 deletions(-)
>
> --
> 2.31.1
>