From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.8591.1639647145530972887 for ; Thu, 16 Dec 2021 01:32:25 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LfQITXh9; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DF48661CF7 for ; Thu, 16 Dec 2021 09:32:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FCBBC36AE8 for ; Thu, 16 Dec 2021 09:32:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639647144; bh=N5HbT1dVeo0g3j44mH+TCrmNdoj0ptFWpp+745Ujnlk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=LfQITXh9wkNxsAkoxSYTL/BfVxXlqjxn3cgdqQSx1vBfiXkAGBSlbsvrnbSQVOlBo L40chGvbVJHQyIoJK560loMp+iPKFr3fPX872runIUNF/KFWPNNRREnabF/eegaN9O 6luvcBXQTbFh8DK7p+Y9yA8zZ509WCRnz5k/d/vJ/EPNl5LwwesbWqf8E5MayeUhX+ MrIWfewvTxJPKWw0fLVqxVlzn16jQigJuCqdHR35STOpoMhkkQHED5SckAbOwc8v3D R9AR2hRSRnq17Fkjo80vV5fROhe4ZyUoHocpHKySFzpr1R/0GjBNgZbEjQdBJw4iTI 4M++X1hPXEjVQ== Received: by mail-wr1-f46.google.com with SMTP id e5so9573812wrc.5 for ; Thu, 16 Dec 2021 01:32:24 -0800 (PST) X-Gm-Message-State: AOAM530Hleo+pq50uXFCrUqEP9F/LOT3cfh7vB9Z434+kVq0L9E5FdE0 qoa+E6V+wBDRbqFlxdaWMKfsyXs4A6eGIx65s8Y= X-Google-Smtp-Source: ABdhPJxKtk01W232nX/z6y+Xx+kY3NQfrZD8AY41RcEHL9h2O/y4GgEYlqaLDGNreR6sOo90a1OZbU8dunPf29bYSM8= X-Received: by 2002:adf:c450:: with SMTP id a16mr2035098wrg.454.1639647142104; Thu, 16 Dec 2021 01:32:22 -0800 (PST) MIME-Version: 1.0 References: <20211215000324.11591-1-rebecca@nuviainc.com> In-Reply-To: <20211215000324.11591-1-rebecca@nuviainc.com> From: "Ard Biesheuvel" Date: Thu, 16 Dec 2021 10:32:10 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-platforms PATCH 0/8] Update Arm platforms following addition of EFI_MP_SERVICES_PROTOCOL support in edk2 To: Rebecca Cran Cc: edk2-devel-groups-io , Ard Biesheuvel , Samer El-Haj-Mahmoud , Leif Lindholm , Sami Mujawar , Masami Hiramatsu , Graeme Gregory , Radoslaw Biernacki , Marcin Wojtas Content-Type: text/plain; charset="UTF-8" On Wed, 15 Dec 2021 at 01:03, Rebecca Cran wrote: > > This patch series depends on the "Add EFI_MP_SERVICES_PROTOCOL support > for AARCH64" series which is in the process of being reviewed (I'm > sending a v2 soon). > > With the addition of EFI_MP_SERVICES_PROTOCOL support for Arm, consumers > of ArmPkg/Drivers/CpuDxe now need an instance of MpInitLib. This series > adds ArmPkg/Library/MpInitLib/DxeMpInitLib.inf. > > Also, the ARM_CORE_INFO struct has changed so there's now an MPIDR field > where there were previously separate cluster and core fields. This > series updates the initializers for the various instances. > > > Rebecca Cran (8): > Platform/ARM: Add MpInitLib instance > Platform/Socionext: Add instance of MpInitLib > Silicon/Marvell: Add instance of MpInitLib > Platform/Qemu: Add instance of MpInitLib > Platform/ARM: Update ARM_CORE_INFO initializer for MPIDR field change > Silicon/Marvell: Update ARM_CORE_INFO initializer for MPIDR field > change > Silicon/Socionext: Update ARM_CORE_INFO initializer for MPIDR field > change > Silicon/Qemu: Update ARM_CORE_INFO initializer for MPIDR field change > You appear to have missed a few instances: Platform/AMD/OverdriveBoard/OverdriveBoard.dsc Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc Platform/Hisilicon/D03/D03.dsc Platform/Hisilicon/D05/D05.dsc Platform/Hisilicon/D06/D06.dsc Platform/Hisilicon/HiKey/HiKey.dsc Platform/Hisilicon/HiKey960/HiKey960.dsc Platform/LeMaker/CelloBoard/CelloBoard.dsc Platform/Phytium/DurianPkg/DurianPkg.dsc Platform/RaspberryPi/RPi3/RPi3.dsc Platform/RaspberryPi/RPi4/RPi4.dsc Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc I know this is tedious busywork, but you can't break existing platforms like that, so please provide a solution for these as well. > Platform/ARM/JunoPkg/ArmJuno.dsc | 1 + > Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c | 12 ++--- > Platform/ARM/Morello/MorelloPlatform.dsc.inc | 1 + > Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 1 + > Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 1 + > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 + > Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7.c | 16 +++---- > Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSM.c | 16 +++---- > Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 + > Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 + > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 + > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 + > Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.c | 8 ++-- > Silicon/Qemu/SbsaQemu/Library/SbsaQemuLib/SbsaQemuLib.c | 8 ++-- > Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c | 48 ++++++++++---------- > 15 files changed, 63 insertions(+), 54 deletions(-) > > -- > 2.31.1 >