From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by mx.groups.io with SMTP id smtpd.web08.1795.1613212166407722241
 for <devel@edk2.groups.io>;
 Sat, 13 Feb 2021 02:29:26 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PR6Co/t8;
 spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org)
Received: by mail.kernel.org (Postfix) with ESMTPSA id BFB4464DDA
	for <devel@edk2.groups.io>; Sat, 13 Feb 2021 10:29:25 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1613212165;
	bh=jQ8jOfvPFN7XFxo1BXFMSKC1d4XDiu+bnwKRy2gKiss=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=PR6Co/t8QzED7muM9ATMuJM45ZXrDs5NmiR+OPK8xc67xMIhL3qdjKc22bF2PPfsL
	 Z28xmDQlVy4V4WCtOCDB8EEKZbNsjAbLfy9zNTroBK9wiml3V1AleYg5o8TVaTt8TY
	 dplwo9yqLR8nF1cLz9e9dRfip+FHVmLOA9u9xjn94sIv6rVHz4QVuFVYP5bI7ka2GY
	 qjSKwE4anWVvPb5F5EAZlZ1/zkuvPgjf0YRtQxA0EgM/jg5xehIhjnDIF1/IR5cU42
	 +TRWT5stgQiiqy8l7iKEC6Aos1E2mxSmrk0Xd/3XKJIThTQZ9C+R2X2rQO7fAEnhFN
	 0cT1GxzWf0LUg==
Received: by mail-ot1-f46.google.com with SMTP id i20so1646318otl.7
        for <devel@edk2.groups.io>; Sat, 13 Feb 2021 02:29:25 -0800 (PST)
X-Gm-Message-State: AOAM530/ZizIlJeRu3sChOyxN7fZ7h7YsJDQ1TrxjAXSFnzii3+9J0Py
	iUF1EHTV3x6+m6ZWjTNlcDXV9eggE5RUBocmz2M=
X-Google-Smtp-Source: ABdhPJyfV01r7x0dUnAGWGwElyOjfY5I77rpaIclIIEoADHOlDYEhFcsyeUdV730rctJ5cZojvwMPnQvRNnhGAXxZL4=
X-Received: by 2002:a05:6830:1285:: with SMTP id z5mr5154734otp.90.1613212165115;
 Sat, 13 Feb 2021 02:29:25 -0800 (PST)
MIME-Version: 1.0
References: <20210115061404.13552-1-sughosh.ganu@linaro.org> <20210115061404.13552-5-sughosh.ganu@linaro.org>
In-Reply-To: <20210115061404.13552-5-sughosh.ganu@linaro.org>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Sat, 13 Feb 2021 11:29:14 +0100
X-Gmail-Original-Message-ID: <CAMj1kXFPgb9ASkKyxEuA97vOrnH4tFK9eKayxNYgxspsLzCvUw@mail.gmail.com>
Message-ID: <CAMj1kXFPgb9ASkKyxEuA97vOrnH4tFK9eKayxNYgxspsLzCvUw@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH v3 04/13] ArmPkg: Introduce support for PcdFfaEnable
To: devel@edk2.groups.io, Sughosh Ganu <sughosh.ganu@linaro.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>, Ard Biesheuvel <ard.biesheuvel@arm.com>, 
	Leif Lindholm <leif@nuviainc.com>, Sahil Malhotra <sahil.malhotra@linaro.org>, 
	Ilias Apalodimas <ilias.apalodimas@linaro.org>
Content-Type: text/plain; charset="UTF-8"

On Fri, 15 Jan 2021 at 07:14, Sughosh Ganu <sughosh.ganu@linaro.org> wrote:
>
> The Secure Partition(SP) can request services from the Secure
> Partition Manager Core(SPMC) either through FF-A calls or through the
> existing SVC calls. Add a feature flag Pcd for enabling the FF-A
> method -- when this is set to FALSE, the SP uses the existing SVC
> calls for making the requests.
>
> Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>
> Changes since V2: None
>
>  ArmPkg/ArmPkg.dec | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec
> index eaf1072d9e..507e16844c 100644
> --- a/ArmPkg/ArmPkg.dec
> +++ b/ArmPkg/ArmPkg.dec
> @@ -78,6 +78,12 @@
>    # Define if the GICv3 controller should use the GICv2 legacy
>    gArmTokenSpaceGuid.PcdArmGicV3WithV2Legacy|FALSE|BOOLEAN|0x00000042
>
> +  ## Used to select method for requesting services from S-EL1.<BR><BR
> +  #   TRUE  - Selects FF-A calls for communication between S-EL0 and SPMC.<BR>
> +  #   FALSE - Selects SVC calls for communication between S-EL0 and SPMC.<BR>
> +  # @Prompt Enable FF-A support.
> +  gArmTokenSpaceGuid.PcdFfaEnable|FALSE|BOOLEAN|0x0000005B
> +
>  [PcdsFeatureFlag.ARM]
>    # Whether to map normal memory as non-shareable. FALSE is the safe choice, but
>    # TRUE may be appropriate to fix performance problems if you don't care about
> --
> 2.17.1
>
>
>
> 
>
>