From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 392877803E8 for ; Wed, 23 Aug 2023 15:20:19 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Gl5qfX8w1xZpvPmgUJRbB6yXQLr0cmJYcaVBenNnRPA=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1692804018; v=1; b=WpD0XyqIq8UYzZnDRyJa3vlB1tKK400eUZ4wv5aIewzs6DWi8Q80dHFGVmeOpPTwptbWVWUT WyiHQhz0PbTfs6Tsn1cY0kgLhhLzWiBGaLx82CUtyy8+ch67tgMGgylhDzjfNTTt5I7w1BxAx0D rkCoY1UVoWXwUGeKz98owR34= X-Received: by 127.0.0.2 with SMTP id 0GcKYY7687511xghZQCIF6VZ; Wed, 23 Aug 2023 08:20:18 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.14375.1692804018048349838 for ; Wed, 23 Aug 2023 08:20:18 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 622B0664D1 for ; Wed, 23 Aug 2023 15:20:17 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89E02C433CB for ; Wed, 23 Aug 2023 15:20:16 +0000 (UTC) X-Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-5009969be25so915952e87.3 for ; Wed, 23 Aug 2023 08:20:16 -0700 (PDT) X-Gm-Message-State: mG7cfn5wapBRjXvGspyz3IT4x7686176AA= X-Google-Smtp-Source: AGHT+IFtMFkMWhoKztgp//4MK8Y6d1u36QgnlEaOv9MrbrcSp+O9GDI1CB1WpqFsQpF5qYxFy0eLJ5IuJKYHDnbliuw= X-Received: by 2002:a05:6512:318b:b0:4fe:3724:fdac with SMTP id i11-20020a056512318b00b004fe3724fdacmr10709855lfe.47.1692804014436; Wed, 23 Aug 2023 08:20:14 -0700 (PDT) MIME-Version: 1.0 References: <20230823151522.168518-1-quic_llindhol@quicinc.com> In-Reply-To: <20230823151522.168518-1-quic_llindhol@quicinc.com> From: "Ard Biesheuvel" Date: Wed, 23 Aug 2023 17:20:03 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [RFC PATCH 1/1] BaseTools: drop tautological warning overrides for CLANGDWARF To: devel@edk2.groups.io, quic_llindhol@quicinc.com Cc: Ajay Iyengar , Rebecca Cran , Liming Gao , Bob Feng , Yuwei Chen , Ard Biesheuvel Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=WpD0XyqI; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, 23 Aug 2023 at 17:15, Leif Lindholm wro= te: > > The CLANGDWARF progfile sets both -Wno-tautological-compare and > -Wno-tautological-constant-out-of-range-compare, but this prevents > compile-time detection of certain errors. > Drop these flags. > > Signed-off-by: Leif Lindholm > Cc: Rebecca Cran > Cc: Liming Gao > Cc: Bob Feng > Cc: Yuwei Chen > Cc: Ard Biesheuvel Acked-by: Ard Biesheuvel > --- > > Does anyone remember why these were added? I added those when I first introduced Clang 3.5 support, and I am quite sure i only added the options that were needed to complete the build. But I don't remember which exact issue was solved by each option 5c02fc49aea5 ("BaseTools: add CLANG35 toolchain with AARCH64 support") > I'm not running into any issues across armvirtqemu, qemusbsa, ovmfx64, ov= mfriscv64. > > > BaseTools/Conf/tools_def.template | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def= .template > index 1bf62362b611..5bd5283655ea 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -1859,7 +1859,7 @@ DEFINE CLANGDWARF_X64_DLINK2_FLAGS =3D -Wl,-= -defsym=3DPECOFF_HEADER_SIZE=3D0x22 > DEFINE CLANGDWARF_IA32_TARGET =3D -target i686-pc-linux-gnu > DEFINE CLANGDWARF_X64_TARGET =3D -target x86_64-pc-linux-gn= u > > -DEFINE CLANGDWARF_WARNING_OVERRIDES =3D -Wno-parentheses-equality -Wn= o-tautological-compare -Wno-tautological-constant-out-of-range-compare -Wno= -empty-body -Wno-unused-const-variable -Wno-varargs -Wno-unknown-warning-op= tion -Wno-unused-but-set-variable -Wno-unused-const-variable -Wno-unaligned= -access -Wno-unneeded-internal-declaration > +DEFINE CLANGDWARF_WARNING_OVERRIDES =3D -Wno-parentheses-equality -Wn= o-empty-body -Wno-unused-const-variable -Wno-varargs -Wno-unknown-warning-o= ption -Wno-unused-but-set-variable -Wno-unused-const-variable -Wno-unaligne= d-access -Wno-unneeded-internal-declaration > DEFINE CLANGDWARF_ALL_CC_FLAGS =3D DEF(GCC48_ALL_CC_FLAGS) DEF(C= LANGDWARF_WARNING_OVERRIDES) -fno-stack-protector -mms-bitfields -Wno-addre= ss -Wno-shift-negative-value -Wno-unknown-pragmas -Wno-incompatible-library= -redeclaration -fno-asynchronous-unwind-tables -mno-sse -mno-mmx -msoft-flo= at -mno-implicit-float -ftrap-function=3Dundefined_behavior_has_been_optim= ized_away_by_clang -funsigned-char -fno-ms-extensions -Wno-null-dereference > > ########################### > -- > 2.39.2 > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107982): https://edk2.groups.io/g/devel/message/107982 Mute This Topic: https://groups.io/mt/100916818/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-