From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web09.24518.1662384184766312612 for ; Mon, 05 Sep 2022 06:23:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ccGHxGHl; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0D3DDB81199 for ; Mon, 5 Sep 2022 13:23:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BED57C433D7 for ; Mon, 5 Sep 2022 13:23:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662384180; bh=tq0b3vM8bEIDAhOVUrsB9IjtXVMPv1LQTucXf9MAjRo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ccGHxGHldZVV/0ICJVxn+I2OI2z6N3w+AyqHARSsklmmO1Q93pzgjsFmx3Umm5Zqo EScF7138HREqE4mrjwUNyoGKGei6CJRQad9ngLl+oXiYTaq9nO2sji2ecq7K2ox2NJ vIe6ctRsrY/MtTvtJg8oZ1P5O1XH5kCUa8234ZXwP8lJfOE5WbrfwsguM3diqcJB4N oxWJQxyVHEiz57viJKYsdenUPH0JZo3RAd+4jiSwPnABuF4c6PpcbtgV0u+ilDJhHI igOgfApiwjMQ2oSjkLVuWND5mhMXtzJio5eDvuqRoZbYuCwhooDDpFTvfjZB0ucdzx hthUHodkZEkOQ== Received: by mail-lj1-f175.google.com with SMTP id k18so9195522lji.13 for ; Mon, 05 Sep 2022 06:23:00 -0700 (PDT) X-Gm-Message-State: ACgBeo0KeQc+KobtsbhES2YyoA0mjQ+jnKRD30a/YywXppCPw1z+KrZH l9MKZcIOBq8IGtAgB5rVjM6+vgu+KBCUBg0ne/E= X-Google-Smtp-Source: AA6agR5WF2DY2CxSZY/Jht3j+TiJTxZFmisaed58pgPFlzL83BZh7273X21alwYQtNPtOasl2Eved59n/qX+GtopnSg= X-Received: by 2002:a2e:3006:0:b0:266:6677:5125 with SMTP id w6-20020a2e3006000000b0026666775125mr10453070ljw.352.1662384178770; Mon, 05 Sep 2022 06:22:58 -0700 (PDT) MIME-Version: 1.0 References: <20220902021206.184028-1-jianyong.wu@arm.com> In-Reply-To: <20220902021206.184028-1-jianyong.wu@arm.com> From: "Ard Biesheuvel" Date: Mon, 5 Sep 2022 15:22:47 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v3 0/2] CloudHv/arm: Add specific mem info lib To: devel@edk2.groups.io, jianyong.wu@arm.com Cc: Sami.Mujawar@arm.com, ardb+tianocore@kernel.org, justin.he@arm.com Content-Type: text/plain; charset="UTF-8" On Fri, 2 Sept 2022 at 04:12, Jianyong Wu wrote: > > Currently, the meminfo lib for CloudHv/arm is reusing QEMU's. As the memory > layout for cloud hypervisor is changed, it needs a new meminfo lib. > > Signed-off-by: Jianyong Wu > > Jianyong Wu (2): > CloudHv/arm: add PeiMemInfoLib > CloudHv/arm: switch PeiMemLib to its own > Please address the following coding style issues 2022-09-05T13:07:52.6615653Z ERROR - EFI coding style error 2022-09-05T13:07:52.6617613Z ERROR - *Error code: 4002 2022-09-05T13:07:52.6618262Z ERROR - *Function header doesn't exist 2022-09-05T13:07:52.6619906Z ERROR - *file: //home/vsts/work/1/s/Build/.pytool/Plugin/EccCheck/ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c 2022-09-05T13:07:52.6621135Z ERROR - *Line number: 25 2022-09-05T13:07:52.6622262Z ERROR - *Function [CloudHvVirtMemInfoPeiLibConstructor] has NO comment immediately preceding it. 2022-09-05T13:07:52.6623456Z ERROR - 2022-09-05T13:07:52.6624009Z ERROR - EFI coding style error 2022-09-05T13:07:52.6625006Z ERROR - *Error code: 5007 2022-09-05T13:07:52.6626154Z ERROR - *There should be no initialization of a variable as part of its declaration 2022-09-05T13:07:52.6627510Z ERROR - *file: //home/vsts/work/1/s/Build/.pytool/Plugin/EccCheck/ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c 2022-09-05T13:07:52.6628717Z ERROR - *Line number: 171 2022-09-05T13:07:52.6633439Z ERROR - *Variable Name: Index 2022-09-05T13:07:52.6634155Z ERROR - 2022-09-05T13:07:52.6634676Z ERROR - EFI coding style error 2022-09-05T13:07:52.6635217Z ERROR - *Error code: 5007 2022-09-05T13:07:52.6641270Z ERROR - *There should be no initialization of a variable as part of its declaration 2022-09-05T13:07:52.6644330Z ERROR - *file: //home/vsts/work/1/s/Build/.pytool/Plugin/EccCheck/ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c 2022-09-05T13:07:52.6645757Z ERROR - *Line number: 171 2022-09-05T13:07:52.6646858Z ERROR - *Variable Name: MemNodeIndex 2022-09-05T13:07:52.6648247Z ERROR - 2022-09-05T13:07:52.6649628Z ERROR - EFI coding style error 2022-09-05T13:07:52.6650730Z ERROR - *Error code: 8003 2022-09-05T13:07:52.6652153Z ERROR - *The #ifndef at the start of an include file should have one postfix underscore, and no prefix underscore character '_' 2022-09-05T13:07:52.6653700Z ERROR - *file: //home/vsts/work/1/s/Build/.pytool/Plugin/EccCheck/ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.h 2022-09-05T13:07:52.6655658Z ERROR - *Line number: 9 2022-09-05T13:07:52.6656423Z ERROR - *The #ifndef name [_CLOUDHV_VIRT_MEM_INFO_LIB_H_] does not follow the rules 2022-09-05T13:07:52.6658050Z ERROR - 2022-09-05T13:07:52.6658635Z ERROR - EFI coding style error 2022-09-05T13:07:52.6659800Z ERROR - *Error code: 9001 2022-09-05T13:07:52.6661130Z ERROR - *The file headers should follow Doxygen special documentation blocks in section 2.3.5 2022-09-05T13:07:52.6662905Z ERROR - *file: //home/vsts/work/1/s/Build/.pytool/Plugin/EccCheck/ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoPeiLib.inf 2022-09-05T13:07:52.6663715Z ERROR - *Line number: 1 2022-09-05T13:07:52.6666838Z ERROR - *INF/DEC/DSC/FDF file header comment should begin with "## @file" or "# @file" at the very top file