From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A806974003D for ; Tue, 12 Dec 2023 08:11:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6eOr57o7Z8qZ27ZQUIGppKOZNMt5oRDJSRu6XUAGJR4=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702368693; v=1; b=ZfOig1nUO+u5mIiQmrxzBviDUUpQIQ32bg+N46UlWTvfpLTGZqG5ZgFzneqd8vEd/jskQHoP xNzpCIV7Kbx+jwmvxeZcMg3L1OVELxuxt22j0227w9vB6ajHOvwKcfcsKBHj+VEr+30fvH4rT+3 ZhbCwZ0obKTJtLSkqwx4Q9lE= X-Received: by 127.0.0.2 with SMTP id qat5YY7687511xLcRHjrYvu5; Tue, 12 Dec 2023 00:11:33 -0800 X-Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web10.12003.1702368692300476195 for ; Tue, 12 Dec 2023 00:11:32 -0800 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 25DA0B8121D for ; Tue, 12 Dec 2023 08:11:30 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8303DC433CB for ; Tue, 12 Dec 2023 08:11:29 +0000 (UTC) X-Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2c9f62447c2so53824651fa.0 for ; Tue, 12 Dec 2023 00:11:29 -0800 (PST) X-Gm-Message-State: MI46eUyPF3KIX9qrPieXn399x7686176AA= X-Google-Smtp-Source: AGHT+IHcJthPlU0Qvf1sTSBmRUEuc1nwvOrHgcpDtK1wQnnRjRNQHa67zPOQ+po9gPB7UhkZC6cYNSyv2P2OXG5saOo= X-Received: by 2002:a2e:a544:0:b0:2c9:f643:d6d7 with SMTP id e4-20020a2ea544000000b002c9f643d6d7mr4427281ljn.8.1702368687749; Tue, 12 Dec 2023 00:11:27 -0800 (PST) MIME-Version: 1.0 References: <20231031173700.647004-1-ngompa@fedoraproject.org> <58ec87dc-ce03-6ad8-681a-d815bc5c39f9@arm.com> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 12 Dec 2023 09:11:16 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery To: devel@edk2.groups.io, ngompa13@gmail.com, "Liming Gao (Byosoft address)" , Michael Kinney , Leif Lindholm Cc: Laszlo Ersek , Jeremy Linton , Pete Batard , =?UTF-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , Gerd Hoffmann , Samer El-Haj-Mahmoud Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ZfOig1nU; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io (cc Mike, Leif) On Thu, 7 Dec 2023 at 08:40, Ard Biesheuvel wrote: > > (cc Liming) > > On Thu, 7 Dec 2023 at 05:48, Neal Gompa wrote: > > > > On Fri, Nov 24, 2023 at 6:36=E2=80=AFPM Neal Gompa = wrote: > > > > > > On Thu, Nov 2, 2023 at 6:35=E2=80=AFAM Laszlo Ersek wrote: > > > > > > > > On 10/31/23 23:27, Jeremy Linton wrote: > > > > > On 10/31/23 12:37, Neal Gompa via groups.io wrote: > > > > >> From: Neal Gompa > > > > >> > > > > >> Currently, the ReadyToBoot event is only signaled when a formal = Boot > > > > >> Manager option is executed (in BmBoot.c -> EfiBootManagerBoot ()= ). > > > > >> > > > > >> However, the introduction of Platform Recovery in UEFI 2.5 makes= it > > > > >> necessary to signal ReadyToBoot when a Platform Recovery boot lo= ader > > > > >> runs because otherwise it may lead to the execution of a boot lo= ader > > > > >> that has similar requirements to a regular one that is not launc= hed > > > > >> as a Boot Manager option. > > > > >> > > > > >> This is especially critical to ensuring that the graphical conso= le > > > > >> is actually usable during platform recovery, as some platforms d= o > > > > >> rely on the ConsolePrefDxe driver, which only performs console > > > > >> initialization after ReadyToBoot is triggered. > > > > >> > > > > >> This patch fixes that behavior by calling EfiSignalEventReadyToB= oot () > > > > >> in EfiBootManagerProcessLoadOption () when invoking platform rec= overy, > > > > >> which is the function that sets up the platform recovery boot pr= ocess. > > > > >> > > > > >> The expected behavior has been clarified in the UEFI 2.10 specif= ication > > > > >> to explicitly indicate this behavior is required for correct ope= ration. > > > > >> > > > > >> This is a rebased version of the patch originally written by Pet= e Batard. > > > > > > > > > > Took me a bit to swap in that whole conversation again, and reche= ck the > > > > > spec's and code paths, but this all looks fine to me and should a= llow > > > > > the PFTF build to drop the similar patch from Pete that has been = carried > > > > > downstream for the past couple years. > > > > > > > > > > As for testing the previous patch has been in the field for a cou= ple > > > > > years now and i'm not aware of it causing any issues. The additio= nal > > > > > restriction of limiting it to platform recovery logically makes s= ense, > > > > > and as far as I can see shouldn't cause any problems. > > > > > > > > > > So, > > > > > > > > > > Reviewed-by: Jeremy Linton > > > > > > > > > > > > > > > As a PS: I also went to check the ready to boot behavior for OsRe= covery > > > > > and realized that apparently none of that support was ever merged= ? > > > > > > > > What else is there, outside of this patch, in need of upstreaming? > > > > > > > > > That seems a bit of an oversight since its been in the spec for a= few years now. > > > > > > > > "ready-to-boot for OsRecovery" is new in UEFI 2.10 (according to th= e > > > > commit message), which is quite recent ("Aug 29, 2022"). > > > > > > > > I couldn't find the Mantis ticket in the Revision History (for 2.10= ) though. > > > > > > > > > > Is there anything else holding up committing this patch? Jeremy and > > > you reviewed it earlier in the month... > > > > > > > Friendly ping again? It's been a month now... > > > > Apologies for the delay - Liming, can we progress with this? Can we please make some progress with this? This has been in limbo for far too long. Thanks, -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112360): https://edk2.groups.io/g/devel/message/112360 Mute This Topic: https://groups.io/mt/102302654/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-