From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web12.20956.1630929902337820805 for ; Mon, 06 Sep 2021 05:05:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VPEfDc/D; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 5C41661027 for ; Mon, 6 Sep 2021 12:05:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630929900; bh=0RSKKIaHd2rgyKUCxsQTEOGh/Bk0XvdSmOrQr1H/P9E=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=VPEfDc/D3rccYGaNTygHdhr9z8xnEmhNicqS0aMnKxAgrx29H4TnGLGjE8fXzEeEi v1oGjGI1tKNQArW3aSdiwVexToFQ0GJLxeWhFG3XN3wkiR1mKi92d5SI0gA6ssm2B4 BXua4QA71dx08Lgf8WQ/rXMh4CjT3JcRcbxcyXCald2ZxqALRsIFVjvakI9xPJLYzt Pf793/FGAjnmZvhiPohrE3nzSgvuXKE2rMOyfkkUV0mo3VBRhdT6QmB09zjWvZINdo ofUWKeB8g3CRaLowuAk4Vtk3EaxEUQyFcgk9EWLO+FQCIaAYizla1b2hwaO3wfhRlt wIJ4VwQfqMEkg== Received: by mail-oi1-f171.google.com with SMTP id n27so8652867oij.0 for ; Mon, 06 Sep 2021 05:05:00 -0700 (PDT) X-Gm-Message-State: AOAM532b9rSu1tU+uZqUnRYTYtpVcv5YamSjdG3PiRCp+/87ElRYVSQA C44oy0HM8MOkO9dBNJwudpwhOEWtEtags1byqm4= X-Google-Smtp-Source: ABdhPJwqxAx/qlIajCduoEki6beuN/e+Uq5FmZAy0kBtVD9t7sgSXdVnK99z8AAI4zSwvI4qWZJYVrxSCA288IKycjk= X-Received: by 2002:aca:eb97:: with SMTP id j145mr8182953oih.33.1630929899714; Mon, 06 Sep 2021 05:04:59 -0700 (PDT) MIME-Version: 1.0 References: <005f01d7a2bb$6d8e5ef0$48ab1cd0$@byosoft.com.cn> In-Reply-To: From: "Ard Biesheuvel" Date: Mon, 6 Sep 2021 14:04:48 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package To: "Yao, Jiewen" Cc: "Chang, Abner" , "devel@edk2.groups.io" , gaoliming , Ard Biesheuvel , "Kinney, Michael D" , Leif Lindholm , "Ni, Ray" , "Schaefer, Daniel" , Sunil V L , Ard Biesheuvel , Gerd Hoffmann Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 6 Sept 2021 at 13:44, Yao, Jiewen wrote: > > I think it makes sense to put Fdt to OvmfPkg. I suggest an Fdt folder and= put all things there. > > > > I also think we define Fdt feature in https://github.com/tianocore/edk2/b= lob/master/Maintainers.txt to add reviewer there to help review the code. > > Agreed. > > > > > > From: Chang, Abner (HPS SW/FW Technologist) > Sent: Monday, September 6, 2021 7:09 PM > To: Yao, Jiewen ; devel@edk2.groups.io; gaoliming <= gaoliming@byosoft.com.cn> > Cc: 'Ard Biesheuvel' ; Kinney, Michael D ; 'Leif Lindholm' ; Ni, Ray ; Schaefer, Daniel ; 'Sunil V L' ; 'Ard Biesheuvel' ; 'Gerd Ho= ffmann' > Subject: RE: [edk2-devel] [RFC] RISC-V QEMU virtual package > > > > Hi Jiewen, > > We currently only use below modules from ArmVirtPkg, > > ArmVirtPkg/Library > > FdtPciPcdProducerLib > FdtPciHostBridgeLib > > ArmVirtPkg/ > > VirtioFdtDxe > FdtClientDxe > HighMemDxe > > Above modules are related to the extraction of the platform configuration= from FDT. We also use ArmPkg/DriverArmPciCpuIoDxe, we can have RISC-V ins= tance of CpuIoDxe but still leverage PCD produced by FdtPciPcdProducerLib. > > Another library is QemuFwCfgLib from ArmVirtPkg/Library, I think we can h= ave RISC-V own instance because there is a one instance under OvmfPkg alrea= dy. > > > > Thanks > > Abner > > > > > > From: Yao, Jiewen [mailto:jiewen.yao@intel.com] > Sent: Monday, September 6, 2021 2:16 PM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) ; gaoliming > Cc: 'Ard Biesheuvel' ; Kinney, Michael D ; 'Leif Lindholm' ; Ni, Ray ; Schaefer, Daniel ; 'Sunil V L' ; 'Ard Biesheuvel' ; 'Gerd Ho= ffmann' > Subject: RE: [edk2-devel] [RFC] RISC-V QEMU virtual package > > > > Do you have a list of which module you want to move to Ovmf? > > > > I think we can discuss case by case. > > > > From: devel@edk2.groups.io On Behalf Of Abner Chan= g > Sent: Monday, September 6, 2021 12:16 PM > To: gaoliming ; devel@edk2.groups.io > Cc: 'Ard Biesheuvel' ; Kinney, Michael D ; 'Leif Lindholm' ; Ni, Ray ; Schaefer, Daniel ; 'Sunil V L' ; Yao, Jiewen ; 'Ard Biesheuvel' <= ardb+tianocore@kernel.org>; 'Gerd Hoffmann' > Subject: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package > > > > Thanks Liming. To have those modules under OvmfPkg also makes sense to me= . See how others think of this. > > > > Abner > > > > From: gaoliming [mailto:gaoliming@byosoft.com.cn] > Sent: Monday, September 6, 2021 9:07 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > Cc: 'Ard Biesheuvel' ; 'Michael D Kinney' ; 'Leif Lindholm' ; ray.ni@intel.co= m; Schaefer, Daniel ; 'Sunil V L' ; jiewen.yao@intel.com; 'Ard Biesheuvel' ; 'Gerd Hoffmann' > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [RFC] RISC-V QEMU virtual packa= ge > > > > Abner: > > If these modules are shared by ARM and RISC-V, they should not be ARM sp= ecific modules. I prefer to move them into OvmfPkg. Now, ArmVirtPkg also in= cludes the modules from OvmfPkg. > > > > I also include OVMF package maintainers for this discussion. > > > > Thanks > > Liming > > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Abner Chang > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B49=E6=9C=885=E6=97=A5 1= 1:15 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > =E6=8A=84=E9=80=81: Ard Biesheuvel ; Michael D Ki= nney ; Leif Lindholm ; ray.n= i@intel.com; Liming Gao ; Schaefer, Daniel ; Sunil V L > =E4=B8=BB=E9=A2=98: [edk2-devel] [RFC] RISC-V QEMU virtual package > > > > Hi all, > > We currently have RISC-V edk2 OVMF package that can boot to Linux kernel = on QEMU RISC-V virt platform. > > First at all, we would like to create a folder RiscvVirtPkg under edk2 re= po and integrated in the Platform CI build. > > > > Second, RISC-V edk2 OVMF package leverages some edk2 libraries and driver= s from ArmVirtPkg, such as FDT related modules for PCI bus, host bridge and= etc. We would like to move those generic virtual drivers to > > a common folder for ARM and RISC-V (I don=E2=80=99t think this way is nec= essary though). Or can we move those to just under OvmfPkg because OvmfPkg = also provides some common drivers for the processor architectures. > > Thoughts? > > > > Thanks > > Abner > >=20