From: "Ard Biesheuvel" <ardb@kernel.org>
To: Michael Kubacki <mikuback@linux.microsoft.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
Alexei Fedorov <Alexei.Fedorov@arm.com>,
Ankit Sinha <ankit.sinha@intel.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Bret Barkelew <Bret.Barkelew@microsoft.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Guomin Jiang <guomin.jiang@intel.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Michael D Kinney <michael.d.kinney@intel.com>,
Nate DeSimone <nathaniel.l.desimone@intel.com>,
Ray Ni <ray.ni@intel.com>, Sami Mujawar <sami.mujawar@arm.com>,
Sean Brogan <sean.brogan@microsoft.com>,
Supreeth Venkatesh <supreeth.venkatesh@arm.com>,
Wei6 Xu <wei6.xu@intel.com>
Subject: Re: [PATCH v1 0/8] Fix new typos reported
Date: Tue, 17 May 2022 18:13:39 +0200 [thread overview]
Message-ID: <CAMj1kXFT=-An6J2QMU26ozX3pFwJwC+iF8qmAamRbUu-BT+zgg@mail.gmail.com> (raw)
In-Reply-To: <20220517160043.1210-1-mikuback@linux.microsoft.com>
Hello Michael,
Thanks for taking care of this. However, I strongly feel that
automation is increasing my workload here rather than the other way
around, for dubious benefits, so as a package maintainer, I am
inclined to disable the spell checks altogether for all the packages I
am in charge of.
On Tue, 17 May 2022 at 18:01, <mikuback@linux.microsoft.com> wrote:
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> The SpellCheck plugin began reporting new typos that were previously
> missed. This is impacting edk2 pull requests from being completed.
>
> A change in the cspell plugin or some other upstream component may
> have caused them to appear now. This patch series mitigates the
> issue by fixing legitimate spelling issues and adding new ignored
> words if appropriate.
>
> Fixes in ArmPkg were deferred due to the number of reported issues
> in the package. The maintainers should follow up by reviewing the
> extended word list for SpellCheck in ArmPkg.ci.yaml and determining
> the best resolution for each item.
>
> That follow up task for ArmPkg was filed in the following BZ:
> https://bugzilla.tianocore.org/show_bug.cgi?id=3929
>
> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Cc: Wei6 Xu <wei6.xu@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>
> Michael Kubacki (8):
> PrmPkg: Fix new typos reported
> StandaloneMmPkg: Fix new typos reported
> DynamicTablesPkg: Fix new typos reported
> UnitTestFrameworkPkg: Fix new typos reported
> FatPkg: Fix new typos reported
> FmpDevicePkg: Fix new typos reported
> ArmPkg: Ignore new typos reported
> ArmVirtPkg: Add new ignored spelling errors
>
> DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 2 +-
> DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c | 2 +-
> DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 2 +-
> DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c | 2 +-
> DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c | 2 +-
> DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c | 2 +-
> DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c | 4 +-
> DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.c | 2 +-
> DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c | 2 +-
> FatPkg/EnhancedFatDxe/FileSpace.c | 2 +-
> FatPkg/EnhancedFatDxe/ReadWrite.c | 2 +-
> FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c | 2 +-
> PrmPkg/Application/PrmInfo/PrmInfo.c | 2 +-
> PrmPkg/Library/DxePrmModuleDiscoveryLib/DxePrmModuleDiscoveryLib.c | 2 +-
> PrmPkg/PrmLoaderDxe/PrmLoaderDxe.c | 2 +-
> PrmPkg/Test/UnitTest/Library/UefiBootServicesTableLibUnitTest/UefiBootServicesTableLibUnitTestImage.c | 2 +-
> PrmPkg/Test/UnitTest/Library/UefiBootServicesTableLibUnitTest/UefiBootServicesTableLibUnitTestProtocol.c | 2 +-
> StandaloneMmPkg/Core/Dependency.c | 2 +-
> StandaloneMmPkg/Core/Dispatcher.c | 18 +++----
> UnitTestFrameworkPkg/Library/Posix/MemoryAllocationLibPosix/MemoryAllocationLibPosix.c | 18 +++----
> UnitTestFrameworkPkg/Library/UnitTestBootLibNull/UnitTestBootLibNull.c | 2 +-
> UnitTestFrameworkPkg/Library/UnitTestBootLibUsbClass/UnitTestBootLibUsbClass.c | 2 +-
> UnitTestFrameworkPkg/Library/UnitTestLib/Log.c | 2 +-
> UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c | 2 +-
> UnitTestFrameworkPkg/Test/UnitTest/Sample/SampleUnitTest/SampleUnitTest.c | 2 +-
> ArmPkg/ArmPkg.ci.yaml | 55 +++++++++++++++++++-
> ArmVirtPkg/ArmVirtPkg.ci.yaml | 25 +++++----
> DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 31 ++++++++---
> DynamicTablesPkg/Include/Library/DynamicPlatRepoLib.h | 4 +-
> DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.h | 2 +-
> DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.h | 2 +-
> DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.h | 2 +-
> DynamicTablesPkg/Readme.md | 4 +-
> FatPkg/EnhancedFatDxe/Fat.h | 2 +-
> FatPkg/FatPkg.ci.yaml | 22 ++++++--
> FmpDevicePkg/FmpDevicePkg.ci.yaml | 4 ++
> PrmPkg/Include/Library/PrmModuleDiscoveryLib.h | 2 +-
> PrmPkg/PrmLoaderDxe/PrmAcpiTable.h | 4 +-
> PrmPkg/PrmPkg.ci.yaml | 9 ++++
> PrmPkg/Test/UnitTest/Library/UefiBootServicesTableLibUnitTest/UefiBootServicesTableLibUnitTest.h | 4 +-
> StandaloneMmPkg/Include/Guid/MmCoreData.h | 2 +-
> StandaloneMmPkg/StandaloneMmPkg.ci.yaml | 9 ++++
> UnitTestFrameworkPkg/PrivateInclude/Library/UnitTestBootLib.h | 2 +-
> UnitTestFrameworkPkg/PrivateInclude/UnitTestFrameworkTypes.h | 2 +-
> UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 29 +++++++----
> 45 files changed, 209 insertions(+), 91 deletions(-)
>
> --
> 2.28.0.windows.1
>
next prev parent reply other threads:[~2022-05-17 16:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 16:00 [PATCH v1 0/8] Fix new typos reported Michael Kubacki
2022-05-17 16:00 ` [PATCH v1 1/8] PrmPkg: " Michael Kubacki
2022-05-17 16:00 ` [PATCH v1 2/8] StandaloneMmPkg: " Michael Kubacki
2022-05-17 16:19 ` Sami Mujawar
2022-05-17 17:23 ` Michael Kubacki
2022-05-17 16:00 ` [PATCH v1 3/8] DynamicTablesPkg: " Michael Kubacki
2022-05-17 16:27 ` Sami Mujawar
2022-05-17 16:00 ` [PATCH v1 4/8] UnitTestFrameworkPkg: " Michael Kubacki
2022-05-17 16:00 ` [PATCH v1 5/8] FatPkg: " Michael Kubacki
2022-05-18 0:58 ` Ni, Ray
2022-05-17 16:00 ` [PATCH v1 6/8] FmpDevicePkg: " Michael Kubacki
2022-05-17 16:00 ` [PATCH v1 7/8] ArmPkg: Ignore " Michael Kubacki
2022-05-17 16:00 ` [PATCH v1 8/8] ArmVirtPkg: Add new ignored spelling errors Michael Kubacki
2022-05-17 16:13 ` Ard Biesheuvel [this message]
2022-05-17 16:25 ` [edk2-devel] [PATCH v1 0/8] Fix new typos reported Michael Kubacki
2022-05-17 17:31 ` Ard Biesheuvel
2022-05-17 19:32 ` Michael Kubacki
2022-05-17 20:06 ` Ard Biesheuvel
2022-05-17 23:50 ` Michael Kubacki
2022-05-18 1:18 ` 回复: " gaoliming
2022-05-18 2:07 ` Michael Kubacki
2022-05-18 6:43 ` 回复: " gaoliming
2022-05-18 14:52 ` Michael Kubacki
2022-05-19 1:23 ` 回复: " gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXFT=-An6J2QMU26ozX3pFwJwC+iF8qmAamRbUu-BT+zgg@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox