From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web08.9375.1652804032809451499 for ; Tue, 17 May 2022 09:13:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pdd2lV/e; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 275B861255 for ; Tue, 17 May 2022 16:13:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74B25C36AE3 for ; Tue, 17 May 2022 16:13:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652804031; bh=Pe0I3J5uZ47EvcaHJHv6Bywerx/1VUALZxbMgRCbCdU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=pdd2lV/eD0ZTFxKShXqhAC1tFGfo77+m9IwTL83iILFL3q/9OJaMgPGOWEgdp9DpM jKR3bCrfn2U75gNHmggbPtPY1A5VynCu/fXU1pXCOzWYEWuCbK88f070F9c1q7wyT6 D4AVe5D9u7vxi747im+ykKHI8P3Cy7kyn6iniFWsgeIVfcsBFOGJ4oVIHr2CFJvy6v ETw6ObQwK5A9cpoNFLJdr9BmBRHBaOVtqByTEpRMBX5dsSLuP+253B+5r0uob4mbuw YQgSZcxmHgRGPEuEqWvKL5Q5KpM8/YAZQeNZ2EcS4qpE5ooU9ra355RAaKc6lDVLBd UOpcvoyODDukg== Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-f1d5464c48so287452fac.6 for ; Tue, 17 May 2022 09:13:51 -0700 (PDT) X-Gm-Message-State: AOAM531ioKnXEgju7rWGUqdJsc1WazvGv2D+4AImV1EfEqeviun61TE3 rrK3c6DNoPz+8ux8T1y890ouxsii8/+st26uf5U= X-Google-Smtp-Source: ABdhPJy4JENwIfZCSupIX7LNYy4HKx9pBO2etedN7Yy5wtepJO4vjrVAtoeE8EKztWFfX2dZzhCA+ZxID9q/U18IqRM= X-Received: by 2002:a05:6870:eaa5:b0:da:b3f:2b45 with SMTP id s37-20020a056870eaa500b000da0b3f2b45mr19029520oap.228.1652804030518; Tue, 17 May 2022 09:13:50 -0700 (PDT) MIME-Version: 1.0 References: <20220517160043.1210-1-mikuback@linux.microsoft.com> In-Reply-To: <20220517160043.1210-1-mikuback@linux.microsoft.com> From: "Ard Biesheuvel" Date: Tue, 17 May 2022 18:13:39 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 0/8] Fix new typos reported To: Michael Kubacki Cc: edk2-devel-groups-io , Alexei Fedorov , Ankit Sinha , Ard Biesheuvel , Bret Barkelew , Gerd Hoffmann , Guomin Jiang , Jiewen Yao , Leif Lindholm , Liming Gao , Michael D Kinney , Nate DeSimone , Ray Ni , Sami Mujawar , Sean Brogan , Supreeth Venkatesh , Wei6 Xu Content-Type: text/plain; charset="UTF-8" Hello Michael, Thanks for taking care of this. However, I strongly feel that automation is increasing my workload here rather than the other way around, for dubious benefits, so as a package maintainer, I am inclined to disable the spell checks altogether for all the packages I am in charge of. On Tue, 17 May 2022 at 18:01, wrote: > > From: Michael Kubacki > > The SpellCheck plugin began reporting new typos that were previously > missed. This is impacting edk2 pull requests from being completed. > > A change in the cspell plugin or some other upstream component may > have caused them to appear now. This patch series mitigates the > issue by fixing legitimate spelling issues and adding new ignored > words if appropriate. > > Fixes in ArmPkg were deferred due to the number of reported issues > in the package. The maintainers should follow up by reviewing the > extended word list for SpellCheck in ArmPkg.ci.yaml and determining > the best resolution for each item. > > That follow up task for ArmPkg was filed in the following BZ: > https://bugzilla.tianocore.org/show_bug.cgi?id=3929 > > Cc: Alexei Fedorov > Cc: Ankit Sinha > Cc: Ard Biesheuvel > Cc: Bret Barkelew > Cc: Gerd Hoffmann > Cc: Guomin Jiang > Cc: Jiewen Yao > Cc: Leif Lindholm > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Michael Kubacki > Cc: Nate DeSimone > Cc: Ray Ni > Cc: Sami Mujawar > Cc: Sean Brogan > Cc: Supreeth Venkatesh > Cc: Wei6 Xu > Signed-off-by: Michael Kubacki > > Michael Kubacki (8): > PrmPkg: Fix new typos reported > StandaloneMmPkg: Fix new typos reported > DynamicTablesPkg: Fix new typos reported > UnitTestFrameworkPkg: Fix new typos reported > FatPkg: Fix new typos reported > FmpDevicePkg: Fix new typos reported > ArmPkg: Ignore new typos reported > ArmVirtPkg: Add new ignored spelling errors > > DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 2 +- > DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c | 2 +- > DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 2 +- > DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c | 2 +- > DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c | 2 +- > DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c | 2 +- > DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c | 4 +- > DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.c | 2 +- > DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c | 2 +- > FatPkg/EnhancedFatDxe/FileSpace.c | 2 +- > FatPkg/EnhancedFatDxe/ReadWrite.c | 2 +- > FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c | 2 +- > PrmPkg/Application/PrmInfo/PrmInfo.c | 2 +- > PrmPkg/Library/DxePrmModuleDiscoveryLib/DxePrmModuleDiscoveryLib.c | 2 +- > PrmPkg/PrmLoaderDxe/PrmLoaderDxe.c | 2 +- > PrmPkg/Test/UnitTest/Library/UefiBootServicesTableLibUnitTest/UefiBootServicesTableLibUnitTestImage.c | 2 +- > PrmPkg/Test/UnitTest/Library/UefiBootServicesTableLibUnitTest/UefiBootServicesTableLibUnitTestProtocol.c | 2 +- > StandaloneMmPkg/Core/Dependency.c | 2 +- > StandaloneMmPkg/Core/Dispatcher.c | 18 +++---- > UnitTestFrameworkPkg/Library/Posix/MemoryAllocationLibPosix/MemoryAllocationLibPosix.c | 18 +++---- > UnitTestFrameworkPkg/Library/UnitTestBootLibNull/UnitTestBootLibNull.c | 2 +- > UnitTestFrameworkPkg/Library/UnitTestBootLibUsbClass/UnitTestBootLibUsbClass.c | 2 +- > UnitTestFrameworkPkg/Library/UnitTestLib/Log.c | 2 +- > UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c | 2 +- > UnitTestFrameworkPkg/Test/UnitTest/Sample/SampleUnitTest/SampleUnitTest.c | 2 +- > ArmPkg/ArmPkg.ci.yaml | 55 +++++++++++++++++++- > ArmVirtPkg/ArmVirtPkg.ci.yaml | 25 +++++---- > DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 31 ++++++++--- > DynamicTablesPkg/Include/Library/DynamicPlatRepoLib.h | 4 +- > DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.h | 2 +- > DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.h | 2 +- > DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.h | 2 +- > DynamicTablesPkg/Readme.md | 4 +- > FatPkg/EnhancedFatDxe/Fat.h | 2 +- > FatPkg/FatPkg.ci.yaml | 22 ++++++-- > FmpDevicePkg/FmpDevicePkg.ci.yaml | 4 ++ > PrmPkg/Include/Library/PrmModuleDiscoveryLib.h | 2 +- > PrmPkg/PrmLoaderDxe/PrmAcpiTable.h | 4 +- > PrmPkg/PrmPkg.ci.yaml | 9 ++++ > PrmPkg/Test/UnitTest/Library/UefiBootServicesTableLibUnitTest/UefiBootServicesTableLibUnitTest.h | 4 +- > StandaloneMmPkg/Include/Guid/MmCoreData.h | 2 +- > StandaloneMmPkg/StandaloneMmPkg.ci.yaml | 9 ++++ > UnitTestFrameworkPkg/PrivateInclude/Library/UnitTestBootLib.h | 2 +- > UnitTestFrameworkPkg/PrivateInclude/UnitTestFrameworkTypes.h | 2 +- > UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 29 +++++++---- > 45 files changed, 209 insertions(+), 91 deletions(-) > > -- > 2.28.0.windows.1 >