From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 26F8774003A for ; Fri, 4 Aug 2023 13:17:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=YLo7eEme5qMxiO5Z+rabPKccnhE8ZLgVCz4xvZwg+t0=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1691155066; v=1; b=ZA//0FDLiO2kSzMpSK3kOY56eqXuyWFaR+iJ+1A4Ea/NFVhK0qcg3/+hqzp3jHW5dKZwxKA2 /gy6TxfiT4M+oeJuIq2cLc3+raR9pSTBMAc9xjnzEoYgFqA0S3L64oadPHBSvR8ipnjwmiT8BEi Kf9uImj6OX8+vqVmL6ot1v6g= X-Received: by 127.0.0.2 with SMTP id 8nR3YY7687511xmaoYvZRV7A; Fri, 04 Aug 2023 06:17:46 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.10818.1691155066005157324 for ; Fri, 04 Aug 2023 06:17:46 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6567B61FEB for ; Fri, 4 Aug 2023 13:17:45 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA4A2C433CC for ; Fri, 4 Aug 2023 13:17:44 +0000 (UTC) X-Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2b9c0391749so34869211fa.0 for ; Fri, 04 Aug 2023 06:17:44 -0700 (PDT) X-Gm-Message-State: 3STmSM0apzojvh5jJpNJZu5Ux7686176AA= X-Google-Smtp-Source: AGHT+IFycX9EUFe3CggzevHLmeZJHGp+HikwEL/GMx1EVprqLI2T3oIq3dKPZseZZErg3fkpX6OVQd5yaCfJebT/GyA= X-Received: by 2002:a05:651c:14c:b0:2b9:cf47:ce69 with SMTP id c12-20020a05651c014c00b002b9cf47ce69mr1514054ljd.48.1691155062818; Fri, 04 Aug 2023 06:17:42 -0700 (PDT) MIME-Version: 1.0 References: <20230803114425.318246-1-osteffen@redhat.com> <001ed4ff-89fa-c7bf-3a29-305a28b94b41@linux.microsoft.com> In-Reply-To: From: "Ard Biesheuvel" Date: Fri, 4 Aug 2023 15:17:31 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP in tests To: "Kinney, Michael D" Cc: "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" , "osteffen@redhat.com" , "Feng, Bob C" , Gerd Hoffmann , "Yao, Jiewen" , "Justen, Jordan L" , "Gao, Liming" , Rebecca Cran , Sean Brogan , "Chen, Christine" , Laszlo Ersek Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="ZA//0FDL"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, 3 Aug 2023 at 23:25, Ard Biesheuvel wrote: > > On Thu, 3 Aug 2023 at 21:21, Kinney, Michael D > wrote: > > > > Hi Ard, > > > > This is the email with the analysis and the flag > > setting required for SMP to work with SMM enabled for > > IA32/X64 QEMU. > > > > https://edk2.groups.io/g/devel/message/102364 > > > > > > I tried latest version of QEMU earlier in the Summer > > and did not see any improvements. > > > > Ah thanks, I had forgotten all about that rabbit hole you went down :-) > > So let's respin this with -smp 4 --accel=tcg,thread=single. It is > still an improvement to exercise the MP code even if it doesn't > strictly execute concurrently. (It will be very hard to > catch/reproduce true concurrency issues in TCG anyway) > Something like this is what I had in mind: --- a/OvmfPkg/PlatformCI/PlatformBuildLib.py +++ b/OvmfPkg/PlatformCI/PlatformBuildLib.py @@ -195,6 +195,7 @@ class PlatformBuilder( UefiBuilder, BuildSettingsManager): args = "-debugcon stdio" # write messages to stdio args += " -global isa-debugcon.iobase=0x402" # debug messages out thru virtual io port args += " -net none" # turn off network + args += " -smp 4" args += f" -drive file=fat:rw:{VirtualDrive},format=raw,media=disk" # Mount disk with startup.nsh if (self.env.GetValue("QEMU_HEADLESS").upper() == "TRUE"): @@ -202,6 +203,7 @@ class PlatformBuilder( UefiBuilder, BuildSettingsManager): if (self.env.GetBuildValue("SMM_REQUIRE") == "1"): args += " -machine q35,smm=on" #,accel=(tcg|kvm)" + args += " --accel tcg,thread=single" #args += " -m ..." args += " -global driver=cfi.pflash01,property=secure,value=on" args += " -drive if=pflash,format=raw,unit=0,file=" + os.path.join(OutputPath_FV, "OVMF_CODE.fd") + ",readonly=on" I can just fold that in if nobody minds. I suspect the time limit increase may not be needed either this way. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107566): https://edk2.groups.io/g/devel/message/107566 Mute This Topic: https://groups.io/mt/100524063/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-