From: "Ard Biesheuvel" <ardb@kernel.org>
To: Dandan Bi <dandan.bi@intel.com>
Cc: devel@edk2.groups.io,
Michael D Kinney <michael.d.kinney@intel.com>,
Sean Brogan <sean.brogan@microsoft.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>,
Leif Lindholm <leif@nuviainc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Laszlo Ersek <lersek@redhat.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Jian J Wang <jian.j.wang@intel.com>,
Sami Mujawar <Sami.Mujawar@arm.com>,
Alexei Fedorov <Alexei.Fedorov@arm.com>,
Andrew Fish <afish@apple.com>, Ray Ni <ray.ni@intel.com>,
Chasel Chiu <chasel.chiu@intel.com>,
Nate DeSimone <nathaniel.l.desimone@intel.com>,
Star Zeng <star.zeng@intel.com>,
Zhichao Gao <zhichao.gao@intel.com>,
Hao A Wu <hao.a.wu@intel.com>, Maurice Ma <maurice.ma@intel.com>,
Guo Dong <guo.dong@intel.com>,
Benjamin You <benjamin.you@intel.com>,
Eric Dong <eric.dong@intel.com>,
Maciej Rabeda <maciej.rabeda@linux.intel.com>,
Jiaxin Wu <jiaxin.wu@intel.com>, Siyuan Fu <siyuan.fu@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Supreeth Venkatesh <supreeth.venkatesh@arm.com>,
Abner Chang <abner.chang@hpe.com>,
Nickle Wang <nickle.wang@hpe.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Zhiguang Liu <zhiguang.liu@intel.com>
Subject: Re: [patch V3 00/29] Add a new library class RegisterFilterLib in edk2 to filter/trace port IO/MMIO/MSR access
Date: Fri, 26 Mar 2021 08:57:37 +0100 [thread overview]
Message-ID: <CAMj1kXFU1STBqDLiOuKmr7B1tH_szqfxbsoeuDsChrkGEpHpHg@mail.gmail.com> (raw)
In-Reply-To: <20210326072346.4212-1-dandan.bi@intel.com>
On Fri, 26 Mar 2021 at 08:24, Dandan Bi <dandan.bi@intel.com> wrote:
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
> RFC: https://edk2.groups.io/g/devel/message/72530
> Branch for this change: https://github.com/dandanbi/edk2/tree/RegisterFilterLibV3
>
> Patch 1 is to add RegisterFilterLib Library Class in edk2 to filter/trace port IO/MMIO/MSR access and add a RegisterFilterLibNull instance.
> Patch 2 is to add the MdeLibs.dsc.inc file to MdePkg for some default libraries provided by MdePkg and add RegisterFilterLib into it as the first version of MdeLibs.dsc.inc.
> Last 2 patches are to update APIs in IoLib and BaseLib to filter/trace port IO/MMIO/MSR access.
> Remaining patches are to update related dsc files to consume MdeLibs.dsc.inc for RegisterFilterLib.
> Will submit patch 1 and 2 firstly.
> And then update related dsc files in edk2 and edk2platform repo to consume MdeLibs.dsc.inc for RegisterFilterLib.
> At last will submit the patches to update IoLib and BaseLib to filter/trace port IO/MMIO/MSR access.
> --
> V3:
> 1. Don't assume Library instances in MdeLibs.dsc.inc are must in common [LibraryClasses] section.
> Can specify different [LibraryClasses] section for the libary instances in MdeLibs.dsc.inc.
> 2. Update plaftom dsc to consume the MdeLibs.dsc outside the [LibraryClasses] section.
> 3. Pick up the R-B for patch 1, patch 28, patch 29.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Sami Mujawar <Sami.Mujawar@arm.com>
> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: Benjamin You <benjamin.you@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
>
> Dandan Bi (29):
> MdePkg: Add RegisterFilterLib class and NULL instance
> MdePkg: Add MdeLibs.dsc.inc file to MdePkg
> ArmPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> ArmPlatformPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> ArmVirtPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> CryptoPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> DynamicTablesPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> EmbeddedPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> EmulatorPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> FatPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> FmpDevicePkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> IntelFsp2Pkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> IntelFsp2WrapperPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> MdeModulePkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> MdePkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> NetworkPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> OvmfPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> PcAtChipsetPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> RedfishPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> SecurityPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> ShellPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> SignedCapsulePkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> SourceLevelDebugPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> StandaloneMmPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> UefiCpuPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> UefiPayloadPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> UnitTestFrameworkPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
> MdePkg/IoLib: Filter/trace port IO/MMIO access
> MdePkg/Baseib: Filter/trace MSR access for IA32/X64
>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
> ArmPkg/ArmPkg.dsc | 2 +
> ArmPlatformPkg/ArmPlatformPkg.dsc | 2 +
> ArmVirtPkg/ArmVirt.dsc.inc | 4 +-
> CryptoPkg/CryptoPkg.dsc | 5 +-
> DynamicTablesPkg/DynamicTablesPkg.dsc | 2 +
> EmbeddedPkg/EmbeddedPkg.dsc | 5 +-
> EmulatorPkg/EmulatorPkg.dsc | 4 +-
> FatPkg/FatPkg.dsc | 4 +-
> FmpDevicePkg/FmpDevicePkg.dsc | 4 +-
> IntelFsp2Pkg/IntelFsp2Pkg.dsc | 4 +-
> IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc | 2 +
> IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc | 4 +-
> MdeModulePkg/MdeModulePkg.dsc | 4 +-
> MdePkg/Include/Library/RegisterFilterLib.h | 243 ++++++++++++++++
> .../BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 3 +-
> .../BaseIoLibIntrinsicArmVirt.inf | 3 +-
> .../BaseIoLibIntrinsicInternal.h | 3 +-
> .../BaseIoLibIntrinsicSev.inf | 3 +-
> MdePkg/Library/BaseIoLibIntrinsic/IoLib.c | 95 ++++--
> .../Library/BaseIoLibIntrinsic/IoLibArmVirt.c | 82 +++++-
> MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c | 58 +++-
> MdePkg/Library/BaseIoLibIntrinsic/IoLibMsc.c | 81 ++++--
> MdePkg/Library/BaseIoLibIntrinsic/IoLibNoIo.c | 74 ++++-
> MdePkg/Library/BaseLib/BaseLib.inf | 5 +-
> MdePkg/Library/BaseLib/Ia32/GccInlinePriv.c | 38 ++-
> MdePkg/Library/BaseLib/Ia32/ReadMsr64.c | 38 ++-
> MdePkg/Library/BaseLib/Ia32/WriteMsr64.c | 22 +-
> MdePkg/Library/BaseLib/X64/GccInlinePriv.c | 43 ++-
> MdePkg/Library/BaseLib/X64/ReadMsr64.c | 15 +-
> MdePkg/Library/BaseLib/X64/WriteMsr64.c | 13 +-
> .../RegisterFilterLibNull.c | 271 ++++++++++++++++++
> .../RegisterFilterLibNull.inf | 23 ++
> .../RegisterFilterLibNull.uni | 13 +
> MdePkg/MdeLibs.dsc.inc | 15 +
> MdePkg/MdePkg.dec | 7 +-
> MdePkg/MdePkg.dsc | 6 +-
> NetworkPkg/NetworkPkg.dsc | 4 +-
> OvmfPkg/AmdSev/AmdSevX64.dsc | 5 +-
> OvmfPkg/Bhyve/BhyveX64.dsc | 5 +-
> OvmfPkg/OvmfPkgIa32.dsc | 5 +-
> OvmfPkg/OvmfPkgIa32X64.dsc | 5 +-
> OvmfPkg/OvmfPkgX64.dsc | 5 +-
> OvmfPkg/OvmfXen.dsc | 5 +-
> PcAtChipsetPkg/PcAtChipsetPkg.dsc | 4 +-
> RedfishPkg/RedfishPkg.dsc | 4 +-
> SecurityPkg/SecurityPkg.dsc | 4 +-
> ShellPkg/ShellPkg.dsc | 4 +-
> SignedCapsulePkg/SignedCapsulePkg.dsc | 4 +-
> SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 4 +-
> StandaloneMmPkg/StandaloneMmPkg.dsc | 5 +-
> UefiCpuPkg/UefiCpuPkg.dsc | 4 +-
> UefiPayloadPkg/UefiPayloadPkg.dsc | 5 +-
> .../UnitTestFrameworkPkgTarget.dsc.inc | 4 +-
> 53 files changed, 1131 insertions(+), 145 deletions(-)
> create mode 100644 MdePkg/Include/Library/RegisterFilterLib.h
> create mode 100644 MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.c
> create mode 100644 MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
> create mode 100644 MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.uni
> create mode 100644 MdePkg/MdeLibs.dsc.inc
>
> --
> 2.18.0.windows.1
>
prev parent reply other threads:[~2021-03-26 7:57 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 7:23 [patch V3 00/29] Add a new library class RegisterFilterLib in edk2 to filter/trace port IO/MMIO/MSR access Dandan Bi
2021-03-26 7:23 ` [patch V3 01/29] MdePkg: Add RegisterFilterLib class and NULL instance Dandan Bi
2021-03-26 7:23 ` [patch V3 02/29] MdePkg: Add MdeLibs.dsc.inc file to MdePkg Dandan Bi
2021-03-26 7:23 ` [patch V3 03/29] ArmPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib Dandan Bi
2021-03-26 7:23 ` [patch V3 04/29] ArmPlatformPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 05/29] ArmVirtPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 06/29] CryptoPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 07/29] DynamicTablesPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 08/29] EmbeddedPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 09/29] EmulatorPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 10/29] FatPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 11/29] FmpDevicePkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 12/29] IntelFsp2Pkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 13/29] IntelFsp2WrapperPkg: " Dandan Bi
2021-03-26 8:11 ` Chiu, Chasel
2021-03-26 7:23 ` [patch V3 14/29] MdeModulePkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 15/29] MdePkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 16/29] NetworkPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 17/29] OvmfPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 18/29] PcAtChipsetPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 19/29] RedfishPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 20/29] SecurityPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 21/29] ShellPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 22/29] SignedCapsulePkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 23/29] SourceLevelDebugPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 24/29] StandaloneMmPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 25/29] UefiCpuPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 26/29] UefiPayloadPkg: " Dandan Bi
2021-03-26 14:39 ` Guo Dong
2021-03-26 7:23 ` [patch V3 27/29] UnitTestFrameworkPkg: " Dandan Bi
2021-03-26 16:35 ` Michael D Kinney
2021-03-26 7:23 ` [patch V3 28/29] MdePkg/IoLib: Filter/trace port IO/MMIO access Dandan Bi
2021-03-26 7:23 ` [patch V3 29/29] MdePkg/Baseib: Filter/trace MSR access for IA32/X64 Dandan Bi
2021-03-26 7:57 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXFU1STBqDLiOuKmr7B1tH_szqfxbsoeuDsChrkGEpHpHg@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox