Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs

["Ard Biesheuvel" <ardb@kernel.org>]

On Thu, 6 Oct 2022 at 16:23, Jeff Brasen via groups.io
<jbrasen=nvidia.com@groups.io> wrote:
>
> Any additional thoughts on this patch?
>

If you resend it using a mail client that doesn't corrupt all the
whitespace, I can merge it for you (with Zhichao's ack).


> > -----Original Message-----
> > From: Jeff Brasen
> > Sent: Tuesday, July 19, 2022 9:14 AM
> > To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> > Cc: jian.j.wang@intel.com; zhichao.gao@intel.com; ray.ni@intel.com
> > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib:
> > Add Disk Info support for Ufs
> >
> > Yes, Universal Flash Storage is based on the SCSI architectural model and
> > installs gEfiExtScsiPassThruProtocolGuid to function.
> >
> > Thanks,
> > Jeff
> >
> > > -----Original Message-----
> > > From: gaoliming <gaoliming@byosoft.com.cn>
> > > Sent: Monday, July 18, 2022 7:44 PM
> > > To: devel@edk2.groups.io; Jeff Brasen <jbrasen@nvidia.com>
> > > Cc: jian.j.wang@intel.com; zhichao.gao@intel.com; ray.ni@intel.com
> > > Subject: 回复: [edk2-devel] [PATCH]
> > MdeModulePkg/UefiBootManagerLib:
> > > Add Disk Info support for Ufs
> > >
> > > External email: Use caution opening links or attachments
> > >
> > >
> > > Jeff:
> > >   I want to confirm why UFS apply the same rule to SCSI. Does UFS
> > > follows SCSI spec?
> > >
> > > Thanks
> > > Liming
> > > > -----邮件原件-----
> > > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Jeff
> > Brasen
> > > via
> > > > groups.io
> > > > 发送时间: 2022年6月15日 1:54
> > > > 收件人: devel@edk2.groups.io
> > > > 抄送: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> > > > zhichao.gao@intel.com; ray.ni@intel.com; Jeff Brasen
> > > > <jbrasen@nvidia.com>
> > > > 主题: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add
> > > Disk
> > > > Info support for Ufs
> > > >
> > > > Add support for getting disk info from UFS devices.
> > > >
> > > > Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> > > > ---
> > > >  MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c    | 3
> > > > ++-
> > > >  MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf |
> > 1
> > > +
> > > >  2 files changed, 3 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git
> > > > a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > > > b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > > > index fac33b9ee9..87b82f299f 100644
> > > > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > > > +++
> > b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > > > @@ -195,7 +195,8 @@ BmGetDescriptionFromDiskInfo (
> > > >
> > > >
> > > >        BmEliminateExtraSpaces (Description);
> > > >
> > > >      }
> > > >
> > > > -  } else if (CompareGuid (&DiskInfo->Interface,
> > > > &gEfiDiskInfoScsiInterfaceGuid)) {
> > > >
> > > > +  } else if (CompareGuid (&DiskInfo->Interface,
> > > > &gEfiDiskInfoScsiInterfaceGuid) ||
> > > >
> > > > +             CompareGuid (&DiskInfo->Interface,
> > > > &gEfiDiskInfoUfsInterfaceGuid)) {
> > > >
> > > >      BufferSize = sizeof (EFI_SCSI_INQUIRY_DATA);
> > > >
> > > >      Status     = DiskInfo->Inquiry (
> > > >
> > > >                               DiskInfo,
> > > >
> > > > diff --git
> > > > a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > > > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > > > index fe05d5f1cc..2fc0a80a4e 100644
> > > > ---
> > > a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > > > +++
> > > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > > > @@ -85,6 +85,7 @@
> > > >    gEfiDiskInfoIdeInterfaceGuid                  ##
> > > > SOMETIMES_CONSUMES ## GUID
> > > >
> > > >    gEfiDiskInfoScsiInterfaceGuid                 ##
> > > > SOMETIMES_CONSUMES ## GUID
> > > >
> > > >    gEfiDiskInfoSdMmcInterfaceGuid                ##
> > > > SOMETIMES_CONSUMES ## GUID
> > > >
> > > > +  gEfiDiskInfoUfsInterfaceGuid                  ##
> > > > SOMETIMES_CONSUMES ## GUID
> > > >
> > > >
> > > >
> > > >  [Protocols]
> > > >
> > > >    gEfiPciRootBridgeIoProtocolGuid               ## CONSUMES
> > > >
> > > > --
> > > > 2.25.1
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
>
>
>
> 
>
>